All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Jean-Christophe Dubois <jcd@tribudubois.net>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, Bin Meng <bin.meng@windriver.com>,
	qemu-arm@nongnu.org
Subject: Re: [PATCH 3/3] hw/arm: sabrelite: Connect the Ethernet PHY at address 6
Date: Mon, 14 Dec 2020 10:40:43 +0000	[thread overview]
Message-ID: <878sa0vfc5.fsf@linaro.org> (raw)
In-Reply-To: <1607937538-69471-4-git-send-email-bmeng.cn@gmail.com>


Bin Meng <bmeng.cn@gmail.com> writes:

> From: Bin Meng <bin.meng@windriver.com>
>
> At present, when booting U-Boot on QEMU sabrelite, we see:
>
>   Net:   Board Net Initialization Failed
>   No ethernet found.
>
> U-Boot scans PHY at address 4/5/6/7 (see board_eth_init() in the
> U-Boot source: board/boundary/nitrogen6x/nitrogen6x.c). On the real
> board, the Ethernet PHY is at address 6. Adjust this by updating the
> "fec-phy-num" property of the fsl_imx6 SoC object.
>
> With this change, U-Boot sees the PHY but complains MAC address:
>
>   Net:   using phy at 6
>   FEC [PRIME]
>   Error: FEC address not set.
>
> This is due to U-Boot tries to read the MAC address from the fuse,
> which QEMU does not have any valid content filled in. However this
> does not prevent the Ethernet from working in QEMU. We just need to
> set up the MAC address later in the U-Boot command shell, by:
>
>   => setenv ethaddr 00:11:22:33:44:55
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

As you are giving this board some attention is there any chance you
could be persuaded to add an entry in docs/system/arm (linked from
docs/system/target-arm.rst) to briefly describe the board and what is
known to work and boot on it?

-- 
Alex Bennée

WARNING: multiple messages have this Message-ID (diff)
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Bin Meng <bin.meng@windriver.com>,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	Jean-Christophe Dubois <jcd@tribudubois.net>
Subject: Re: [PATCH 3/3] hw/arm: sabrelite: Connect the Ethernet PHY at address 6
Date: Mon, 14 Dec 2020 10:40:43 +0000	[thread overview]
Message-ID: <878sa0vfc5.fsf@linaro.org> (raw)
In-Reply-To: <1607937538-69471-4-git-send-email-bmeng.cn@gmail.com>


Bin Meng <bmeng.cn@gmail.com> writes:

> From: Bin Meng <bin.meng@windriver.com>
>
> At present, when booting U-Boot on QEMU sabrelite, we see:
>
>   Net:   Board Net Initialization Failed
>   No ethernet found.
>
> U-Boot scans PHY at address 4/5/6/7 (see board_eth_init() in the
> U-Boot source: board/boundary/nitrogen6x/nitrogen6x.c). On the real
> board, the Ethernet PHY is at address 6. Adjust this by updating the
> "fec-phy-num" property of the fsl_imx6 SoC object.
>
> With this change, U-Boot sees the PHY but complains MAC address:
>
>   Net:   using phy at 6
>   FEC [PRIME]
>   Error: FEC address not set.
>
> This is due to U-Boot tries to read the MAC address from the fuse,
> which QEMU does not have any valid content filled in. However this
> does not prevent the Ethernet from working in QEMU. We just need to
> set up the MAC address later in the U-Boot command shell, by:
>
>   => setenv ethaddr 00:11:22:33:44:55
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

As you are giving this board some attention is there any chance you
could be persuaded to add an entry in docs/system/arm (linked from
docs/system/target-arm.rst) to briefly describe the board and what is
known to work and boot on it?

-- 
Alex Bennée


  reply	other threads:[~2020-12-14 10:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14  9:18 [PATCH 0/3] hw/arm: sabrelite: Improve emulation fidelity to allow booting upstream U-Boot Bin Meng
2020-12-14  9:18 ` [PATCH 1/3] hw/misc: imx6_ccm: Update PMU_MISC0 reset value Bin Meng
2020-12-14 10:26   ` Alex Bennée
2020-12-14 10:26     ` Alex Bennée
2020-12-14 10:43     ` Bin Meng
2020-12-14 10:43       ` Bin Meng
2020-12-14 15:02       ` Alex Bennée
2020-12-14 19:05       ` Alex Bennée
2020-12-14  9:18 ` [PATCH 2/3] hw/msic: imx6_ccm: Correct register value for silicon type Bin Meng
2020-12-14  9:18 ` [PATCH 3/3] hw/arm: sabrelite: Connect the Ethernet PHY at address 6 Bin Meng
2020-12-14 10:40   ` Alex Bennée [this message]
2020-12-14 10:40     ` Alex Bennée
2020-12-14 10:50     ` Bin Meng
2020-12-14 10:50       ` Bin Meng
2020-12-14 10:23 ` [PATCH 0/3] hw/arm: sabrelite: Improve emulation fidelity to allow booting upstream U-Boot Alex Bennée
2020-12-14 10:23   ` Alex Bennée
2020-12-14 10:30   ` Bin Meng
2020-12-14 10:30     ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sa0vfc5.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=bin.meng@windriver.com \
    --cc=bmeng.cn@gmail.com \
    --cc=jcd@tribudubois.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.