From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: fam@euphon.net, berrange@redhat.com, stefanb@linux.vnet.ibm.com,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
f4bug@amsat.org, cota@braap.org, stefanha@redhat.com,
marcandre.lureau@redhat.com, pbonzini@redhat.com,
aurelien@aurel32.net
Subject: Re: [PATCH v1 6/6] gitlab: add --without-default-features build
Date: Wed, 09 Dec 2020 18:32:19 +0000 [thread overview]
Message-ID: <878sa6de19.fsf@linaro.org> (raw)
In-Reply-To: <0d1a0b59-ecbc-208f-8eb7-0aa323930cd9@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 09/12/2020 18.00, Alex Bennée wrote:
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> .gitlab-ci.yml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 878d114d40..f87584ca8f 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -441,6 +441,13 @@ build-without-default-devices:
>> IMAGE: debian-amd64
>> CONFIGURE_ARGS: --without-default-devices --disable-user
>>
>> +build-without-default-features:
>> + <<: *native_build_job_definition
>> + variables:
>> + IMAGE: centos8
>> + CONFIGURE_ARGS: --without-default-devices --without-default-features --disable-user
>> + MAKE_CHECK_ARGS: check-unit
>
> I wonder whether we'd rather want to check without
> "--without-default-devices" here to see whether all code compiles fine with
> "--without-default-features" ... ?
Yeah at the moment the full-fat without everything doesn't achieve much.
So how about I swap the IMAGE around with the previous build and drop
the --without-default-devices?
>
> Thomas
--
Alex Bennée
next prev parent reply other threads:[~2020-12-09 19:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 17:00 [PATCH v1 0/6] testing/next (without-features, gitlab, python) Alex Bennée
2020-12-09 17:00 ` [PATCH v1 1/6] configure: include moxie-softmmu in deprecated_targets_list Alex Bennée
2020-12-09 17:00 ` [PATCH v1 2/6] gitlab: include aarch64-softmmu and ppc64-softmmu cross-system-build Alex Bennée
2020-12-09 17:08 ` Thomas Huth
2020-12-09 18:19 ` Richard Henderson
2020-12-09 17:00 ` [PATCH v1 3/6] configure: add --without-default-features Alex Bennée
2020-12-10 0:08 ` Paolo Bonzini
2020-12-09 17:00 ` [PATCH v1 4/6] python: add __repr__ to ConsoleSocket to aid debugging Alex Bennée
2020-12-09 17:00 ` [PATCH v1 5/6] gitlab: move --without-default-devices build from Travis Alex Bennée
2020-12-09 17:10 ` Thomas Huth
2020-12-09 17:00 ` [PATCH v1 6/6] gitlab: add --without-default-features build Alex Bennée
2020-12-09 17:13 ` Thomas Huth
2020-12-09 18:32 ` Alex Bennée [this message]
2020-12-10 5:51 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sa6de19.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.