From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: berrange@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] qemu-option: warn for short-form boolean options
Date: Mon, 09 Nov 2020 08:59:48 +0100 [thread overview]
Message-ID: <878sbbarkb.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <3c094f89-11b6-b6cc-690b-df688e425fd9@redhat.com> (Paolo Bonzini's message of "Fri, 6 Nov 2020 19:20:33 +0100")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 06/11/20 17:49, Markus Armbruster wrote:
>>> Deprecate all this, except for -chardev and -spice where it is in
>>> wide use.
>> I consider this a misuse of deprecation, to be frank. If something is
>> known to be unused, we just remove it. Deprecation is precisely for
>> things that are used. I'm with Daniel here: let's deprecate this sugar
>> everywhere.
>> Wide use may justify extending the deprecation grace period.
>
> Fair enough. However now that I think of it I'd have to remove the
> coverage of the "feature" in tests, because they'd warn.
Either that, or do what we do elsewhere when warnings get in the way of
testing: suppress them when testing. I wouldn't bother here unless it's
easy.
next prev parent reply other threads:[~2020-11-09 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 14:27 [PATCH for-5.2 0/2] deprecate short-form boolean options Paolo Bonzini
2020-11-05 14:27 ` [PATCH 1/2] qemu-option: move help handling to get_opt_name_value Paolo Bonzini
2020-11-06 15:10 ` Markus Armbruster
2020-11-06 16:55 ` Markus Armbruster
2020-11-05 14:27 ` [PATCH 2/2] qemu-option: warn for short-form boolean options Paolo Bonzini
2020-11-06 16:49 ` Markus Armbruster
2020-11-06 18:20 ` Paolo Bonzini
2020-11-09 7:59 ` Markus Armbruster [this message]
2020-11-05 14:36 ` [PATCH for-5.2 0/2] deprecate " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sbbarkb.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.