From: "Aurélien Aptel" <aaptel@suse.com>
To: Paul Aurich <paul@darkrain42.org>,
linux-cifs@vger.kernel.org, sfrench@samba.org
Cc: paul@darkrain42.org, Ronnie Sahlberg <lsahlber@redhat.com>
Subject: Re: [PATCH v3] cifs: Fix leak when handling lease break for cached root fid
Date: Mon, 06 Jul 2020 10:30:27 +0200 [thread overview]
Message-ID: <878sfx6o64.fsf@suse.com> (raw)
In-Reply-To: <20200702164411.108672-1-paul@darkrain42.org>
Paul Aurich <paul@darkrain42.org> writes:
> Changes since v2:
> - address sparse lock warnings by inlining smb2_tcon_has_lease and
> hardcoding some return values (seems to help sparse's analysis)
Ah, I think the issue is not the inlining but rather you need to
instruct sparse that smb2_tcon_hash_lease is expected to release the
lock.
https://www.kernel.org/doc/html/v4.12/dev-tools/sparse.html#using-sparse-for-lock-checking
Probably with __releases somewhere in the func prototype.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2020-07-06 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 16:44 [PATCH v3] cifs: Fix leak when handling lease break for cached root fid Paul Aurich
2020-07-06 8:30 ` Aurélien Aptel [this message]
2020-07-06 19:26 ` Paul Aurich
2020-07-07 7:03 ` lock checking issues (was: Re: [PATCH v3] cifs: Fix leak when handling lease break for cached root fid) Aurélien Aptel
2020-07-07 13:05 ` Luc Van Oostenryck
2020-07-07 20:34 ` Paul Aurich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sfx6o64.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=paul@darkrain42.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.