From: "Aurélien Aptel" <aaptel@suse.com>
To: Kenneth D'souza <kdsouza@redhat.com>, linux-cifs@vger.kernel.org
Cc: smfrench@gmail.com, kdsouza@redhat.com, rbergant@redhat.com
Subject: Re: [PATCH v2] cifs: dump Security Type info in DebugData
Date: Thu, 04 Jun 2020 19:21:40 +0200 [thread overview]
Message-ID: <878sh2iw63.fsf@suse.com> (raw)
In-Reply-To: <20200604154441.23822-1-kdsouza@redhat.com>
Kenneth D'souza <kdsouza@redhat.com> writes:
> Currently the end user is unaware with what sec type the
> cifs share is mounted if no sec=<type> option is parsed.
> With this patch one can easily check from DebugData.
LGTM but I would move the security_types next to the enum definition in
cifsglob.h somehow, so that it will be harder to forget to update one if
the other changes.
Since it is in a header, maybe via an inline func with a
switch... simple but more verbose. Or X-macros [1] magic (might be
overkill).
1: https://www.geeksforgeeks.org/x-macros-in-c/
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2020-06-04 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 15:44 [PATCH v2] cifs: dump Security Type info in DebugData Kenneth D'souza
2020-06-04 17:21 ` Aurélien Aptel [this message]
2020-06-05 15:20 ` Kenneth Dsouza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sh2iw63.fsf@suse.com \
--to=aaptel@suse.com \
--cc=kdsouza@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=rbergant@redhat.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.