All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix Sphinx build duplicate label warning
Date: Mon, 20 Apr 2020 09:40:18 +0300	[thread overview]
Message-ID: <878siq3bjh.fsf@intel.com> (raw)
In-Reply-To: <158713249868.2062.16583016796681686099@build.alporthouse.com>

On Fri, 17 Apr 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-04-17 14:01:09)
>> Fix the warning caused by enabling the autosectionlabel extension in the
>> kernel Sphinx build:
>> 
>> Documentation/gpu/i915.rst:610: WARNING: duplicate label
>> gpu/i915:layout, other instance in Documentation/gpu/i915.rst
>> 
>> In the warning message, Sphinx is unable to reference the labels in
>> their true locations in the kernel-doc comments in source. In this case,
>> there's "Layout" sections in both gt/intel_workarounds.c and
>> i915_reg.h. Rename the section in the latter to "File Layout".
>> 
>> Fixes: 58ad30cf91f0 ("docs: fix reference to core-api/namespaces.rst")
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed is probably too strong, but I comprehend your problem
> statement, if not entirely grokking Sphinx,

Thanks for the review, pushed with some more explanation of the exact
failure mode added to the commit message.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-04-20  6:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 13:01 [Intel-gfx] [PATCH] drm/i915: fix Sphinx build duplicate label warning Jani Nikula
2020-04-17 14:08 ` Chris Wilson
2020-04-20  6:40   ` Jani Nikula [this message]
2020-04-17 17:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-19  3:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878siq3bjh.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.