[Buildroot] [PATCH 1/1] package/connman: enable wireguard

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:

 > On Sun, Mar 8, 2020 at 12:17 PM Peter Korsgaard <peter@korsgaard.com> wrote:
 >> 
 >> >>>>> "Petr" == Petr Vorel <petr.vorel@gmail.com> writes:
 >> 
 >> Hi,
 >> 
 >> >> > +config BR2_PACKAGE_CONNMAN_WIREGUARD
 >> >> > + bool "enable wireguard support"
 >> >> > + select BR2_PACKAGE_LIBMNL
 >> 
 >> >> We already had a patch from Petr at
 >> >> http://patchwork.ozlabs.org/patch/1246181/ to add Wireguard support,
 >> >> but he was also selecting BR2_PACKAGE_WIREGUARD_TOOLS.
 >> 
 >> >> Could you or Petr clarify this ?
 >> > configure.ac
 >> > found_libmnl="no"
 >> > if (test "${firewall_type}" = "nftables" -o \
 >> >              "${enable_wireguard}" != "no"); then
 >> >      PKG_CHECK_MODULES(LIBMNL, [libmnl >= 1.0.0], [found_libmnl="yes"],
 >> >              AC_MSG_ERROR([libmnl >= 1.0.0 not found]))
 >> >      AC_SUBST(LIBMNL_CFLAGS)
 >> >      AC_SUBST(LIBMNL_LIBS)
 >> > fi
 >> > AM_CONDITIONAL(LIBMNL, test "${found_libmnl}" != "no")
 >> 
 >> > IMHO this means that libmnl is required for nftables and wireguard.
 >> 
 >> Yes. What about wireguard-tools? Are they used by connman or does it
 >> directly talk the netlink protocol? I guess the latter given the libmnl
 >> dependency?
 > Yeah, connman seemed to build fine with wireguard support without
 > wireguard-tools.

Well, a wireguard-tools dependency issue would probably be visible at
runtime as it would then just call out to those binaries.

Looking at the code, I see that is not the case and connman directly
talks the netlink interface of the kernel driver:

https://git.kernel.org/pub/scm/network/connman/connman.git/tree/vpn/plugins/libwireguard.c

-- 
Bye, Peter Korsgaard