All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] set minimum cmake version to 3.10
Date: Mon, 03 Feb 2020 16:13:46 +0100	[thread overview]
Message-ID: <878slj3dqt.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200203142738.1558715-1-aduskett@gmail.com> (Adam Duskett's message of "Mon, 3 Feb 2020 06:27:38 -0800")

>>>>> "Adam" == Adam Duskett <aduskett@gmail.com> writes:

 > The CMakeLists.txt file uses the CMP0091 which is an MSVC runtime library flag
 > abstraction macro.

 > Because we are not building ninja for Microsoft, it is safe to remove this
 > macro and set the minimum version to 3.10.

There's unfortunately still another issue:

http://autobuild.buildroot.net/results/615/6150430d396b74a81be87d942ca571c7c15dfc52/build-end.log

CMakeLists.txt hardcodes -fdiagnostic-color, which is only supported
from gcc 4.9, breaking builds on old autobuilders:

https://gcc.gnu.org/gcc-4.9/changes.html

We don't really care about coloured error messages, so I guess we can
just patch away that line.

Care to send a patch doing that?

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2020-02-03 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 14:27 [Buildroot] [PATCH 1/1] set minimum cmake version to 3.10 Adam Duskett
2020-02-03 14:52 ` Thomas Petazzoni
2020-02-03 15:13 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878slj3dqt.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.