From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 3/3] drm/i915/i915: assume vbt is 4-byte aligned into oprom Date: Thu, 21 Nov 2019 15:09:03 +0200 Message-ID: <878so9wf4g.fsf@intel.com> References: <20191120234608.17775-1-lucas.demarchi@intel.com> <20191120234608.17775-3-lucas.demarchi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29E4A89D30 for ; Thu, 21 Nov 2019 13:09:09 +0000 (UTC) In-Reply-To: <20191120234608.17775-3-lucas.demarchi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMCBOb3YgMjAxOSwgTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBpbnRl bC5jb20+IHdyb3RlOgo+IFRoZSB1bmFsaWduZWQgaW9yZWFkMzIoKSB3aWxsIG1ha2UgdXMgcmVh ZCBieXRlIGJ5IGJ5dGUgbG9va2luZyBmb3IgdGhlCj4gdmJ0LiBXZSBjb3VsZCBqdXN0IGFzIHdl bGwgaGF2ZSBkb25lIGEgaW9yZWFkOCgpICsgYSBzaGlmdCBhbmQgYXZvaWQgdGhlCj4gZXh0cmEg Y29uZnVzaW9uIG9uIGhvdyB3ZSBhcmUgbG9va2luZyBmb3IgIiRWQlQiLgo+Cj4gSG93ZXZlciB3 aGVuIHVzaW5nIEFDUEkgaXQncyBndWFyYW50ZWVkIHRoZSBWQlQgaXMgNC1ieXRlIGFsaWduZWQK PiBwZXIgc3BlYywgc28gd2UgY2FuIHByb2JhYmx5IGFzc3VtZSBpdCBoZXJlIGFzIHdlbGwuCj4K PiBTaWduZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9iaW9zLmMgfCAx OSArKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyks IDEzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfYmlvcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9i aW9zLmMKPiBpbmRleCBhYTliMTgyZWZlZTUuLjZiZjU3YjFhZDA1NiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Jpb3MuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYmlvcy5jCj4gQEAgLTE5MDIsMjcgKzE5MDIsMjAg QEAgc3RhdGljIHN0cnVjdCB2YnRfaGVhZGVyICpvcHJvbV9nZXRfdmJ0KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgCXZvaWQgX19pb21lbSAqcCA9IE5VTEwsICpvcHJvbTsK PiAgCXN0cnVjdCB2YnRfaGVhZGVyICp2YnQ7Cj4gIAl1MTYgdmJ0X3NpemU7Cj4gLQlzaXplX3Qg aSwgc2l6ZTsKPiArCXNpemVfdCBzaXplOwo+ICAKPiAgCW9wcm9tID0gcGNpX21hcF9yb20ocGRl diwgJnNpemUpOwo+ICAJaWYgKCFvcHJvbSkKPiAgCQlyZXR1cm4gTlVMTDsKPiAgCj4gIAkvKiBT Y291ciBtZW1vcnkgbG9va2luZyBmb3IgdGhlIFZCVCBzaWduYXR1cmUuICovCj4gLQlmb3IgKGkg PSAwOyBpICsgNCA8IHNpemU7IGkrKykgewo+IC0JCWlmIChpb3JlYWQzMihvcHJvbSArIGkpICE9 ICooKGNvbnN0IHUzMiAqKSIkVkJUIikpCj4gLQkJCWNvbnRpbnVlOwo+IC0KPiAtCQlwID0gb3By b20gKyBpOwo+IC0JCXNpemUgLT0gaTsKPiAtCQlicmVhazsKPiAtCX0KPiAtCj4gLQlpZiAoIXAp Cj4gLQkJZ290byBlcnJfdW5tYXBfb3Byb207Cj4gKwlmb3IgKHAgPSBvcHJvbTsgc2l6ZSA+PSA0 OyBwICs9IDQsIHNpemUgLT0gNCkKPiArCQlpZiAoaW9yZWFkMzIocCkgPT0gKigoY29uc3QgdTMy ICopIiRWQlQiKSkKPiArCQkJYnJlYWs7CgpJIHRoaW5rIHRoZSBvcmlnaW5hbCBpcyBlYXNpZXIg dG8gcmVhZC4gWW91IG9ubHkgcmVhbGx5IG5lZWQgdG8gY2hhbmdlCiJpKysiIHRvICJpICs9IDQi IGFuZCBiZSBkb25lIHdpdGggaXQuCgpCUiwKSmFuaS4KCj4gIAo+ICAJaWYgKHNpemVvZihzdHJ1 Y3QgdmJ0X2hlYWRlcikgPiBzaXplKSB7Cj4gLQkJRFJNX0RFQlVHX0RSSVZFUigiVkJUIGhlYWRl ciBpbmNvbXBsZXRlXG4iKTsKPiArCQlpZiAoc2l6ZSA+PSA0KQo+ICsJCQlEUk1fREVCVUdfRFJJ VkVSKCJWQlQgaGVhZGVyIGluY29tcGxldGVcbiIpOwo+ICAJCWdvdG8gZXJyX3VubWFwX29wcm9t Owo+ICAJfQoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F91C432C0 for ; Thu, 21 Nov 2019 13:09:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7159A20731 for ; Thu, 21 Nov 2019 13:09:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7159A20731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1658089D30; Thu, 21 Nov 2019 13:09:10 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29E4A89D30 for ; Thu, 21 Nov 2019 13:09:09 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 05:09:08 -0800 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="201118118" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 05:09:06 -0800 From: Jani Nikula To: Lucas De Marchi , intel-gfx@lists.freedesktop.org In-Reply-To: <20191120234608.17775-3-lucas.demarchi@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191120234608.17775-1-lucas.demarchi@intel.com> <20191120234608.17775-3-lucas.demarchi@intel.com> Date: Thu, 21 Nov 2019 15:09:03 +0200 Message-ID: <878so9wf4g.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/i915: assume vbt is 4-byte aligned into oprom X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191121130903.CYS3j4GoG26sl4MVKqHju-SQSAP3oSRgKAqiff2vR2M@z> T24gV2VkLCAyMCBOb3YgMjAxOSwgTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBpbnRl bC5jb20+IHdyb3RlOgo+IFRoZSB1bmFsaWduZWQgaW9yZWFkMzIoKSB3aWxsIG1ha2UgdXMgcmVh ZCBieXRlIGJ5IGJ5dGUgbG9va2luZyBmb3IgdGhlCj4gdmJ0LiBXZSBjb3VsZCBqdXN0IGFzIHdl bGwgaGF2ZSBkb25lIGEgaW9yZWFkOCgpICsgYSBzaGlmdCBhbmQgYXZvaWQgdGhlCj4gZXh0cmEg Y29uZnVzaW9uIG9uIGhvdyB3ZSBhcmUgbG9va2luZyBmb3IgIiRWQlQiLgo+Cj4gSG93ZXZlciB3 aGVuIHVzaW5nIEFDUEkgaXQncyBndWFyYW50ZWVkIHRoZSBWQlQgaXMgNC1ieXRlIGFsaWduZWQK PiBwZXIgc3BlYywgc28gd2UgY2FuIHByb2JhYmx5IGFzc3VtZSBpdCBoZXJlIGFzIHdlbGwuCj4K PiBTaWduZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9iaW9zLmMgfCAx OSArKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyks IDEzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfYmlvcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9i aW9zLmMKPiBpbmRleCBhYTliMTgyZWZlZTUuLjZiZjU3YjFhZDA1NiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Jpb3MuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYmlvcy5jCj4gQEAgLTE5MDIsMjcgKzE5MDIsMjAg QEAgc3RhdGljIHN0cnVjdCB2YnRfaGVhZGVyICpvcHJvbV9nZXRfdmJ0KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgCXZvaWQgX19pb21lbSAqcCA9IE5VTEwsICpvcHJvbTsK PiAgCXN0cnVjdCB2YnRfaGVhZGVyICp2YnQ7Cj4gIAl1MTYgdmJ0X3NpemU7Cj4gLQlzaXplX3Qg aSwgc2l6ZTsKPiArCXNpemVfdCBzaXplOwo+ICAKPiAgCW9wcm9tID0gcGNpX21hcF9yb20ocGRl diwgJnNpemUpOwo+ICAJaWYgKCFvcHJvbSkKPiAgCQlyZXR1cm4gTlVMTDsKPiAgCj4gIAkvKiBT Y291ciBtZW1vcnkgbG9va2luZyBmb3IgdGhlIFZCVCBzaWduYXR1cmUuICovCj4gLQlmb3IgKGkg PSAwOyBpICsgNCA8IHNpemU7IGkrKykgewo+IC0JCWlmIChpb3JlYWQzMihvcHJvbSArIGkpICE9 ICooKGNvbnN0IHUzMiAqKSIkVkJUIikpCj4gLQkJCWNvbnRpbnVlOwo+IC0KPiAtCQlwID0gb3By b20gKyBpOwo+IC0JCXNpemUgLT0gaTsKPiAtCQlicmVhazsKPiAtCX0KPiAtCj4gLQlpZiAoIXAp Cj4gLQkJZ290byBlcnJfdW5tYXBfb3Byb207Cj4gKwlmb3IgKHAgPSBvcHJvbTsgc2l6ZSA+PSA0 OyBwICs9IDQsIHNpemUgLT0gNCkKPiArCQlpZiAoaW9yZWFkMzIocCkgPT0gKigoY29uc3QgdTMy ICopIiRWQlQiKSkKPiArCQkJYnJlYWs7CgpJIHRoaW5rIHRoZSBvcmlnaW5hbCBpcyBlYXNpZXIg dG8gcmVhZC4gWW91IG9ubHkgcmVhbGx5IG5lZWQgdG8gY2hhbmdlCiJpKysiIHRvICJpICs9IDQi IGFuZCBiZSBkb25lIHdpdGggaXQuCgpCUiwKSmFuaS4KCj4gIAo+ICAJaWYgKHNpemVvZihzdHJ1 Y3QgdmJ0X2hlYWRlcikgPiBzaXplKSB7Cj4gLQkJRFJNX0RFQlVHX0RSSVZFUigiVkJUIGhlYWRl ciBpbmNvbXBsZXRlXG4iKTsKPiArCQlpZiAoc2l6ZSA+PSA0KQo+ICsJCQlEUk1fREVCVUdfRFJJ VkVSKCJWQlQgaGVhZGVyIGluY29tcGxldGVcbiIpOwo+ICAJCWdvdG8gZXJyX3VubWFwX29wcm9t Owo+ICAJfQoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4