From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0NRS-0004lx-D5 for ath10k@lists.infradead.org; Wed, 21 Aug 2019 10:02:11 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C6D2483F40 for ; Wed, 21 Aug 2019 10:02:09 +0000 (UTC) Received: by mail-ed1-f69.google.com with SMTP id z25so991468edm.3 for ; Wed, 21 Aug 2019 03:02:09 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: RE: [PATCH 2/7] ath10k: change max RX bundle size from 8 to 32 for sdio In-Reply-To: <59f668bda688419e9b6f44587d391135@aptaiexm02f.ap.qualcomm.com> References: <1566302108-18219-1-git-send-email-wgong@codeaurora.org> <1566302108-18219-3-git-send-email-wgong@codeaurora.org> <87ef1gt49d.fsf@toke.dk> <59f668bda688419e9b6f44587d391135@aptaiexm02f.ap.qualcomm.com> Date: Wed, 21 Aug 2019 12:02:07 +0200 Message-ID: <878srmsuow.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong , Wen Gong , "ath10k@lists.infradead.org" Cc: "linux-wireless@vger.kernel.org" V2VuIEdvbmcgPHdnb25nQHF0aS5xdWFsY29tbS5jb20+IHdyaXRlczoKCj4+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IGF0aDEwayA8YXRoMTBrLWJvdW5jZXNAbGlzdHMuaW5m cmFkZWFkLm9yZz4gT24gQmVoYWxmIE9mIFRva2UKPj4gSMO4aWxhbmQtSsO4cmdlbnNlbgo+PiBT ZW50OiBUdWVzZGF5LCBBdWd1c3QgMjAsIDIwMTkgODoyMyBQTQo+PiBUbzogV2VuIEdvbmcgPHdn b25nQGNvZGVhdXJvcmEub3JnPjsgYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKPj4gQ2M6IGxp bnV4LXdpcmVsZXNzQHZnZXIua2VybmVsLm9yZwo+PiBTdWJqZWN0OiBbRVhUXSBSZTogW1BBVENI IDIvN10gYXRoMTBrOiBjaGFuZ2UgbWF4IFJYIGJ1bmRsZSBzaXplIGZyb20gOCB0bwo+PiAzMiBm b3Igc2Rpbwo+PiAKPj4gV2VuIEdvbmcgPHdnb25nQGNvZGVhdXJvcmEub3JnPiB3cml0ZXM6Cj4+ IAo+PiA+IFRoZSBtYXggYnVuZGxlIHNpemUgc3VwcG9ydCBieSBmaXJtd2FyZSBpcyAzMiwgY2hh bmdlIGl0IGZyb20gOCB0byAzMgo+PiA+IHdpbGwgaGVscCBwZXJmb3JtYW5jZS4gVGhpcyByZXN1 bHRzIGluIHNpZ25pZmljYW50IHBlcmZvcm1hbmNlCj4+ID4gaW1wcm92ZW1lbnQgb24gUlggcGF0 aC4KPj4gCj4+IFdoYXQgaGFwcGVucyB3aGVuIHRoZSBoYXJkd2FyZSBkb2Vzbid0IGhhdmUgZW5v dWdoIGRhdGEgdG8gZmlsbCBhCj4+IGJ1bmRsZT8gRG9lcyBpdCBzZW5kIGEgc21hbGxlciBvbmUs IG9yIGRvZXMgaXQgd2FpdCB1bnRpbCBpdCBjYW4gZmlsbAo+PiBpdD8KPj4gCj4KPiBUaGUgYnVu ZGxlIGlzIGZpbGxlZCBieSBmaXJtd2FyZS4gCj4gSXQgd2lsbCBub3Qgd2FpdCB1bnRpbCBpdCBj YW4gZmlsbCBpdC4KPiBGb3IgZXhhbXBsZSwgaWYgeW91IGRvIHBpbmcgcGVyIHNlY29uZCwgaXQg d2lsbCBoYXZlIG9ubHkgMSBwaW5nIHBhY2tldAo+IEluIHRoZSBidW5kbGUuCgpSaWdodCwgY29v bC4KCi1Ub2tlCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B598C3A59B for ; Wed, 21 Aug 2019 10:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FBD22332A for ; Wed, 21 Aug 2019 10:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727266AbfHUKCK convert rfc822-to-8bit (ORCPT ); Wed, 21 Aug 2019 06:02:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34144 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfHUKCK (ORCPT ); Wed, 21 Aug 2019 06:02:10 -0400 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1C74185362 for ; Wed, 21 Aug 2019 10:02:10 +0000 (UTC) Received: by mail-ed1-f70.google.com with SMTP id i10so1083682edv.14 for ; Wed, 21 Aug 2019 03:02:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=07D+Vb3VLQ7yy1uusVKQzDL7GcVauqDp+oTev9vZRJc=; b=n22YNFtMQQGwB463pN4pfu1RpN6HMReIJMzY7/LqH1FxqcKxkLRTKn50kBMfte/VKA bnqg2/q1kvHu/UdDouqUYQMj0I/ckVd2ybusDjZ2Z2BEhAQu7Sx2fmm6RD8wIcbJVHv8 YgcyYRXiErOOheAr4YNqT0Hj+hpM4Rm1yWUyKZ9aDScrPvYAdwsUxpFTu43FlkQKMg9n W5Khb2U8eh3tVr/+hi3lAEYvbWZzavOFTmwf/hS3cdBw5c4qCxqDn6RxKzon1+pGI3e1 vNXkcTg1C0D3RELjFbHMmtFNj+50nJxlWsoLq+xNb7t/e/7hzm3ejTNF+YY5gwbpkzg5 c35g== X-Gm-Message-State: APjAAAUo/fpfSJ5LDySHRKGbvI/btL0ud+TijKTe/AFFxv+vz0CNOhVU w76wHIIDwsA+lZ426OwkuFVJVI5+qbyiQNWUVj72ydw57JW/40WmY/lKP4+Hfe5kFjyL2jkcyLA 18H6cVn4amT8K3iS5EnHXgpDDJo8= X-Received: by 2002:a17:906:80da:: with SMTP id a26mr14494756ejx.222.1566381728590; Wed, 21 Aug 2019 03:02:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqw0JI0SafZ9Vvbuugd0J1jl5yuOT94aDRH1vgoNYwg1udQjTld/BlgZzN9lZuYSJZCyNtPcGQ== X-Received: by 2002:a17:906:80da:: with SMTP id a26mr14494741ejx.222.1566381728442; Wed, 21 Aug 2019 03:02:08 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id v6sm3043620ejx.28.2019.08.21.03.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2019 03:02:07 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 27C49181CEF; Wed, 21 Aug 2019 12:02:07 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Wen Gong , Wen Gong , "ath10k\@lists.infradead.org" Cc: "linux-wireless\@vger.kernel.org" Subject: RE: [PATCH 2/7] ath10k: change max RX bundle size from 8 to 32 for sdio In-Reply-To: <59f668bda688419e9b6f44587d391135@aptaiexm02f.ap.qualcomm.com> References: <1566302108-18219-1-git-send-email-wgong@codeaurora.org> <1566302108-18219-3-git-send-email-wgong@codeaurora.org> <87ef1gt49d.fsf@toke.dk> <59f668bda688419e9b6f44587d391135@aptaiexm02f.ap.qualcomm.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 21 Aug 2019 12:02:07 +0200 Message-ID: <878srmsuow.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong writes: >> -----Original Message----- >> From: ath10k On Behalf Of Toke >> Høiland-Jørgensen >> Sent: Tuesday, August 20, 2019 8:23 PM >> To: Wen Gong ; ath10k@lists.infradead.org >> Cc: linux-wireless@vger.kernel.org >> Subject: [EXT] Re: [PATCH 2/7] ath10k: change max RX bundle size from 8 to >> 32 for sdio >> >> Wen Gong writes: >> >> > The max bundle size support by firmware is 32, change it from 8 to 32 >> > will help performance. This results in significant performance >> > improvement on RX path. >> >> What happens when the hardware doesn't have enough data to fill a >> bundle? Does it send a smaller one, or does it wait until it can fill >> it? >> > > The bundle is filled by firmware. > It will not wait until it can fill it. > For example, if you do ping per second, it will have only 1 ping packet > In the bundle. Right, cool. -Toke