All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rouven Czerwinski <rouven@czerwinskis.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH] crypto: caam - Always do rng selftest
Date: Mon, 05 Aug 2019 17:22:13 +0200	[thread overview]
Message-ID: <878ss7myca.fsf@czerwinskis.de> (raw)
In-Reply-To: <20190805142405.25n73rcixhctzsvh@pengutronix.de>


Roland Hieber <rhi@pengutronix.de> writes:

> On Mon, Aug 05, 2019 at 04:09:27PM +0200, Sascha Hauer wrote:
>> -	if (caam_need_rng_software_selftest()) {
>> +	if (!(rd_reg32(&ctrl->r4tst[0].rdsta) & RDSTA_IFMASK)) {
>
> I'm not sure if I would understand that condition some years later
> without a comment, but then I'm not very versed in the NXP CAAM and the
> rest of the code also does many things like that without explaining
> them, so I guess it's okay :D
>
>  - Roland

Maybe:
/*
 * According to 6.10.74.1 of the i.MX6UL Security Reference Manual,
 * RDSTA_IF1 and RDSTA_IF2 (contained in RDSTA_IFMASK) are flags whether
 * the state handles have been instantiated.
 */

We can probably run the self test a second time by skipping the
instantiation descriptors and only executing the self test sequence.
I don't know if thats really worth it though.

Regards,
Rouven Czerwinski

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-08-05 15:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-05 14:09 [PATCH] crypto: caam - Always do rng selftest Sascha Hauer
2019-08-05 14:24 ` Roland Hieber
2019-08-05 15:22   ` Rouven Czerwinski [this message]
2019-08-06  7:19   ` Sascha Hauer
2020-07-08 11:18 ` Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878ss7myca.fsf@czerwinskis.de \
    --to=rouven@czerwinskis.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.