All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/irq: make i945gm_vblank_work_func() static again
Date: Thu, 27 Jun 2019 13:26:16 +0300	[thread overview]
Message-ID: <878stnqq7r.fsf@intel.com> (raw)
In-Reply-To: <156163038452.20851.16048224810916743715@skylake-alporthouse-com>

On Thu, 27 Jun 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-06-27 10:19:14)
>> The static keyword was apparently accidentally removed in commit
>> 08fa8fd0faa5 ("drm/i915: Switch to per-crtc vblank vfuncs"), leading to
>> sparse warning:
>> 
>> drivers/gpu/drm/i915/i915_irq.c:3382:6: warning: symbol
>> 'i945gm_vblank_work_func' was not declared. Should it be static?
>> 
>> Make the function static again.
>> 
>> Fixes: 08fa8fd0faa5 ("drm/i915: Switch to per-crtc vblank vfuncs")
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> 3 people (well 2 and a robot) send patches for the same compiler
> warning! That means something, right?

That writing patches is more rewarding than reading patches written by
others...? ;)

> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks, likewise, let's see whose patch passes CI first. Looks like your
patch regresses module reload. :D

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-06-27 10:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27  9:19 [PATCH] drm/i915/irq: make i945gm_vblank_work_func() static again Jani Nikula
2019-06-27 10:13 ` Chris Wilson
2019-06-27 10:26   ` Jani Nikula [this message]
2019-06-27 10:28     ` Chris Wilson
2019-06-27 13:12       ` Chris Wilson
2019-06-27 15:16 ` ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878stnqq7r.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.