All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] t0001: fix on case-insensitive filesystems
Date: Fri, 21 Jun 2019 21:33:02 +0200	[thread overview]
Message-ID: <878stu91jl.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20190609201302.GX8616@genre.crustytoothpaste.net>


On Sun, Jun 09 2019, brian m. carlson wrote:

> On 2019-06-08 at 14:43:43, Johannes Schindelin via GitGitGadget wrote:
>> diff --git a/t/t0001-init.sh b/t/t0001-init.sh
>> index 42a263cada..f54a69e2d9 100755
>> --- a/t/t0001-init.sh
>> +++ b/t/t0001-init.sh
>> @@ -307,10 +307,20 @@ test_expect_success 'init prefers command line to GIT_DIR' '
>>  	test_path_is_missing otherdir/refs
>>  '
>>
>> +downcase_on_case_insensitive_fs () {
>> +	test false = "$(git config --get core.filemode)" || return 0
>> +	for f
>
> TIL that “for f” is equivalent to “for f in "$@"”. Thanks for teaching
> me something new.

See also test_have_prereq in test-lib-functions.sh where this trick is
combined with IFS to loop over a "param,like,this" split by ",".

  parent reply	other threads:[~2019-06-21 19:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-08 14:43 [PATCH 0/1] Fix a test on NTFS (and probably HFS+) Johannes Schindelin via GitGitGadget
2019-06-08 14:43 ` [PATCH 1/1] t0001: fix on case-insensitive filesystems Johannes Schindelin via GitGitGadget
2019-06-09 19:23   ` Martin Ågren
2019-06-19 20:24     ` Johannes Schindelin
2019-06-09 20:13   ` brian m. carlson
2019-06-10 16:32     ` Junio C Hamano
2019-06-19 20:17       ` Johannes Schindelin
2019-06-21 19:33     ` Ævar Arnfjörð Bjarmason [this message]
     [not found] ` <pull.151.v2.git.gitgitgadget@gmail.com>
     [not found]   ` <c2fdcf28e725c91a1a48c34226223866ad14bc0a.1560978437.git.gitgitgadget@gmail.com>
2019-06-21 14:34     ` [PATCH v2 " Johannes Schindelin
2019-06-21 17:31       ` Junio C Hamano
2019-06-24 10:13         ` Johannes Schindelin
2019-06-24 17:09           ` Junio C Hamano
2019-06-24 17:38             ` Johannes Schindelin
2019-06-24 19:22               ` Junio C Hamano
     [not found]   ` <pull.151.v3.git.gitgitgadget@gmail.com>
     [not found]     ` <1f0ceee8687e9032a7777f764b34b1c9ccc68f38.1561379363.git.gitgitgadget@gmail.com>
2019-06-24 17:40       ` [PATCH v3 " Johannes Schindelin
2019-06-24 18:55         ` Junio C Hamano
2019-06-25 10:50           ` vger vs GitGitGadget, was " Johannes Schindelin
2019-06-25 19:42             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878stu91jl.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.