From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>,
John Crispin <john@phrozen.org>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Shashidhar Lakkavalli <slakkavalli@datto.com>,
Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
Subject: Re: [RFC V3 1/2] mac80211: add hw 80211 encapsulation offloading support
Date: Tue, 02 Apr 2019 15:28:13 +0200 [thread overview]
Message-ID: <878swspmdu.fsf@toke.dk> (raw)
In-Reply-To: <5647fa751aed450f09312c35f8d5becd47e26b66.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
> On Tue, 2019-04-02 at 11:50 +0200, Toke Høiland-Jørgensen wrote:
>
> [snip, you really should try that sometimes ;-)]
>
>> ieee80211_queue_skb() calls ieee80211_get_txq() which treats skb-
>> datalike it contains an 802.11 header. That is probably not the
>> intention here, is it?
>
> Indeed, that makes no sense.
>
>> I guess we could augment the TXQ stuctures to also handle 802.3 frames
>> (and introduce ieee80211_queue_skb_8023())? Or would it be better to
>> have a qdisc on 802.3-mode interfaces and push packets back to that? I
>> guess we'd still benefit from per-station queueing of packets even if
>> they are Ethernet frames, which would mean amending the TXQs would be
>> better?
>
> TXQs would be better, yes. We should do that.
Cool. Glad that we agree ;)
-Toke
next prev parent reply other threads:[~2019-04-02 13:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 13:14 [RFC V3 0/2] mac80211: add 802.11 encapsulation offloading John Crispin
2019-04-01 13:14 ` [RFC V3 1/2] mac80211: add hw 80211 encapsulation offloading support John Crispin
2019-04-02 9:31 ` Sebastian Gottschall
2019-04-02 14:39 ` John Crispin
2019-04-02 16:33 ` Sebastian Gottschall
2019-04-02 9:50 ` Toke Høiland-Jørgensen
2019-04-02 12:44 ` Johannes Berg
2019-04-02 13:28 ` Toke Høiland-Jørgensen [this message]
2019-04-02 14:37 ` John Crispin
2019-04-10 7:28 ` John Crispin
2019-04-10 10:16 ` Toke Høiland-Jørgensen
2019-04-08 19:28 ` Johannes Berg
2019-04-01 13:14 ` [RFC V3 2/2] ath10k: add tx hw 802.11 encapusaltion " John Crispin
2019-04-01 13:20 ` Ben Greear
2019-04-01 14:02 ` John Crispin
2019-04-02 9:27 ` Sebastian Gottschall
2019-04-02 14:38 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878swspmdu.fsf@toke.dk \
--to=toke@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=john@phrozen.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=slakkavalli@datto.com \
--cc=vthiagar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.