From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH] drm/i915/icl: Sanitize DDI port clock
 gating for DSI ports
Date: Mon, 03 Dec 2018 16:10:05 +0200
Message-ID: <878t168zwi.fsf@intel.com>
References: <20181127163606.28841-1-imre.deak@intel.com>
 <87y39c7zcw.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id CCAC26E044
 for <intel-gfx@lists.freedesktop.org>; Mon,  3 Dec 2018 14:09:46 +0000 (UTC)
In-Reply-To: <87y39c7zcw.fsf@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Imre Deak <imre.deak@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAyOSBOb3YgMjAxOCwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4g
d3JvdGU6Cj4gT24gVHVlLCAyNyBOb3YgMjAxOCwgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwu
Y29tPiB3cm90ZToKPj4gVGhlIHJlcXVpcmVtZW50IGZvciB0aGUgRERJIHBvcnQgY2xvY2sgZ2F0
aW5nIGZvciBhIHBvcnQgaW4gRFNJIG1vZGUgaXMKPj4gdGhlIG9wcG9zaXRlIHdydC4gdGhlIGNh
c2Ugd2hlbiB0aGUgcG9ydCBpcyBpbiBEREkgbW9kZTogdGhlIGNsb2NrCj4+IHNob3VsZCBiZSBn
YXRlZCB3aGVuIHRoZSBwb3J0IGlzIGFjdGl2ZSBhbmQgdW5nYXRlZCB3aGVuIHRoZSBwb3J0IGlz
Cj4+IGluYWN0aXZlLiBOb3RlIHRoYXQgd2UgY2Fubm90IHNpbXBseSBrZWVwIHRoZSBEREkgY2xv
Y2sgZ2F0ZWQgd2hlbiB0aGUKPj4gcG9ydCB3aWxsIGJlIG9ubHkgdXNlZCBpbiBEU0kgbW9kZTog
aXQgbXVzdCBiZSBnYXRlZC91bmdhdGVkIGF0IGEKPj4gc3BlY2lmaWMgc3BvdCBpbiB0aGUgRFNJ
IGVuYWJsZS9kaXNhYmxlIHNlcXVlbmNlLgo+Pgo+PiBFbnN1cmUgdGhlIGFib3ZlIGZvciBhbGwg
cG9ydHMgb2YgYSBEU0kgZW5jb2RlciwgYWxzbyBhZGRpbmcgYSBzYW5pdHkKPj4gY2hlY2sgdGhh
dCB3ZSBoYXZlbid0IHJlZ2lzdGVyZWQgYW5vdGhlciBlbmNvZGVyIHVzaW5nIHRoZSBzYW1lIHBv
cnQKPj4gKFZCVCBzaG91bGQgbmV2ZXIgYWxsb3cgdGhpcyB0byBoYXBwZW4pLgo+Pgo+PiBDYzog
TWFkaGF2IENoYXVoYW4gPG1hZGhhdi5jaGF1aGFuQGludGVsLmNvbT4KPj4gQ2M6IFZhbmRpdGEg
S3Vsa2FybmkgPHZhbmRpdGEua3Vsa2FybmlAaW50ZWwuY29tPgo+PiBDYzogSmFuaSBOaWt1bGEg
PGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly
amFsYUBsaW51eC5pbnRlbC5jb20+Cj4+IENjOiBDbGludCBUYXlsb3IgPGNsaW50b24uYS50YXls
b3JAaW50ZWwuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRl
bC5jb20+Cj4KPiBSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNv
bT4KClRoYW5rcyBmb3IgdGhlIHBhdGNoLCBwdXNoZWQgdG8gZGlucSBhcyBwYXJ0IG9mIFsxXS4K
CkJSLApKYW5pLgoKClsxXSBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvc2VyaWVz
LzUxMDExLwoKCj4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyB8
IDY1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPj4gIGRyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2RzaS5oIHwgIDUgKysrKwo+PiAgMiBmaWxlcyBjaGFuZ2VkLCA1
MyBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGRpLmMKPj4gaW5kZXggYWQxMTU0MGFjNDM2Li42ZDAzMmE2YmUxNmMgMTAwNjQ0Cj4+IC0tLSBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2RkaS5jCj4+IEBAIC0yOCw2ICsyOCw3IEBACj4+ICAjaW5jbHVkZSA8ZHJt
L2RybV9zY2RjX2hlbHBlci5oPgo+PiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4+ICAjaW5jbHVk
ZSAiaW50ZWxfZHJ2LmgiCj4+ICsjaW5jbHVkZSAiaW50ZWxfZHNpLmgiCj4+ICAKPj4gIHN0cnVj
dCBkZGlfYnVmX3RyYW5zIHsKPj4gIAl1MzIgdHJhbnMxOwkvKiBiYWxhbmNlIGxlZyBlbmFibGUs
IGRlLWVtcGggbGV2ZWwgKi8KPj4gQEAgLTI4NTQsOCArMjg1NSw5IEBAIHZvaWQgaWNsX3Nhbml0
aXplX2VuY29kZXJfcGxsX21hcHBpbmcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4+
ICB7Cj4+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNv
ZGVyLT5iYXNlLmRldik7Cj4+ICAJdTMyIHZhbDsKPj4gLQllbnVtIHBvcnQgcG9ydCA9IGVuY29k
ZXItPnBvcnQ7Cj4+IC0JYm9vbCBjbGtfZW5hYmxlZDsKPj4gKwllbnVtIHBvcnQgcG9ydDsKPj4g
Kwl1MzIgcG9ydF9tYXNrOwo+PiArCWJvb2wgZGRpX2Nsa19uZWVkZWQ7Cj4+ICAKPj4gIAkvKgo+
PiAgCSAqIEluIGNhc2Ugb2YgRFAgTVNULCB3ZSBzYW5pdGl6ZSB0aGUgcHJpbWFyeSBlbmNvZGVy
IG9ubHksIG5vdCB0aGUKPj4gQEAgLTI4NjQsOSArMjg2Niw2IEBAIHZvaWQgaWNsX3Nhbml0aXpl
X2VuY29kZXJfcGxsX21hcHBpbmcoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4+ICAJ
aWYgKGVuY29kZXItPnR5cGUgPT0gSU5URUxfT1VUUFVUX0RQX01TVCkKPj4gIAkJcmV0dXJuOwo+
PiAgCj4+IC0JdmFsID0gSTkxNV9SRUFEKERQQ0xLQV9DRkdDUjBfSUNMKTsKPj4gLQljbGtfZW5h
YmxlZCA9ICEodmFsICYgaWNsX2RwY2xrYV9jZmdjcjBfY2xrX29mZihkZXZfcHJpdiwgcG9ydCkp
Owo+PiAtCj4+ICAJaWYgKCFlbmNvZGVyLT5iYXNlLmNydGMgJiYgaW50ZWxfZW5jb2Rlcl9pc19k
cChlbmNvZGVyKSkgewo+PiAgCQl1OCBwaXBlX21hc2s7Cj4+ICAJCWJvb2wgaXNfbXN0Owo+PiBA
QCAtMjg4MCwyMCArMjg3OSw1MiBAQCB2b2lkIGljbF9zYW5pdGl6ZV9lbmNvZGVyX3BsbF9tYXBw
aW5nKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+PiAgCQkJcmV0dXJuOwo+PiAgCX0K
Pj4gIAo+PiAtCWlmIChjbGtfZW5hYmxlZCA9PSAhIWVuY29kZXItPmJhc2UuY3J0YykKPj4gLQkJ
cmV0dXJuOwo+PiArCXBvcnRfbWFzayA9IEJJVChlbmNvZGVyLT5wb3J0KTsKPj4gKwlkZGlfY2xr
X25lZWRlZCA9IGVuY29kZXItPmJhc2UuY3J0YzsKPj4gIAo+PiAtCS8qCj4+IC0JICogUHVudCBv
biB0aGUgY2FzZSBub3cgd2hlcmUgY2xvY2sgaXMgZGlzYWJsZWQsIGJ1dCB0aGUgZW5jb2RlciBp
cwo+PiAtCSAqIGVuYWJsZWQsIHNvbWV0aGluZyBlbHNlIGlzIHJlYWxseSBicm9rZW4gdGhlbi4K
Pj4gLQkgKi8KPj4gLQlpZiAoV0FSTl9PTighY2xrX2VuYWJsZWQpKQo+PiAtCQlyZXR1cm47Cj4+
ICsJaWYgKGVuY29kZXItPnR5cGUgPT0gSU5URUxfT1VUUFVUX0RTSSkgewo+PiArCQlzdHJ1Y3Qg
aW50ZWxfZW5jb2RlciAqb3RoZXJfZW5jb2RlcjsKPj4gIAo+PiAtCURSTV9OT1RFKCJQb3J0ICVj
IGlzIGRpc2FibGVkIGJ1dCBpdCBoYXMgYSBtYXBwZWQgUExMLCB1bm1hcCBpdFxuIiwKPj4gLQkJ
IHBvcnRfbmFtZShwb3J0KSk7Cj4+IC0JdmFsIHw9IGljbF9kcGNsa2FfY2ZnY3IwX2Nsa19vZmYo
ZGV2X3ByaXYsIHBvcnQpOwo+PiAtCUk5MTVfV1JJVEUoRFBDTEtBX0NGR0NSMF9JQ0wsIHZhbCk7
Cj4+ICsJCXBvcnRfbWFzayA9IGludGVsX2RzaV9lbmNvZGVyX3BvcnRzKGVuY29kZXIpOwo+PiAr
CQkvKgo+PiArCQkgKiBTYW5pdHkgY2hlY2sgdGhhdCB3ZSBoYXZlbid0IGluY29ycmVjdGx5IHJl
Z2lzdGVyZWQgYW5vdGhlcgo+PiArCQkgKiBlbmNvZGVyIHVzaW5nIGFueSBvZiB0aGUgcG9ydHMg
b2YgdGhpcyBEU0kgZW5jb2Rlci4KPj4gKwkJICovCj4+ICsJCWZvcl9lYWNoX2ludGVsX2VuY29k
ZXIoJmRldl9wcml2LT5kcm0sIG90aGVyX2VuY29kZXIpIHsKPj4gKwkJCWlmIChvdGhlcl9lbmNv
ZGVyID09IGVuY29kZXIpCj4+ICsJCQkJY29udGludWU7Cj4+ICsKPj4gKwkJCWlmIChXQVJOX09O
KHBvcnRfbWFzayAmIEJJVChvdGhlcl9lbmNvZGVyLT5wb3J0KSkpCj4+ICsJCQkJcmV0dXJuOwo+
PiArCQl9Cj4+ICsJCS8qCj4+ICsJCSAqIERTSSBwb3J0cyBzaG91bGQgaGF2ZSB0aGVpciBEREkg
Y2xvY2sgdW5nYXRlZCB3aGVuIGRpc2FibGVkCj4+ICsJCSAqIGFuZCBnYXRlZCB3aGVuIGVuYWJs
ZWQuCj4+ICsJCSAqLwo+PiArCQlkZGlfY2xrX25lZWRlZCA9ICFlbmNvZGVyLT5iYXNlLmNydGM7
Cj4+ICsJfQo+PiArCj4+ICsJdmFsID0gSTkxNV9SRUFEKERQQ0xLQV9DRkdDUjBfSUNMKTsKPj4g
Kwlmb3JfZWFjaF9wb3J0X21hc2tlZChwb3J0LCBwb3J0X21hc2spIHsKPj4gKwkJYm9vbCBkZGlf
Y2xrX3VuZ2F0ZWQgPSAhKHZhbCAmCj4+ICsJCQkJCSBpY2xfZHBjbGthX2NmZ2NyMF9jbGtfb2Zm
KGRldl9wcml2LAo+PiArCQkJCQkJCQkgICBwb3J0KSk7Cj4+ICsKPj4gKwkJaWYgKGRkaV9jbGtf
bmVlZGVkID09IGRkaV9jbGtfdW5nYXRlZCkKPj4gKwkJCWNvbnRpbnVlOwo+PiArCj4+ICsJCS8q
Cj4+ICsJCSAqIFB1bnQgb24gdGhlIGNhc2Ugbm93IHdoZXJlIGNsb2NrIGlzIGdhdGVkLCBidXQg
aXQgd291bGQKPj4gKwkJICogYmUgbmVlZGVkIGJ5IHRoZSBwb3J0LiBTb21ldGhpbmcgZWxzZSBp
cyByZWFsbHkgYnJva2VuIHRoZW4uCj4+ICsJCSAqLwo+PiArCQlpZiAoV0FSTl9PTihkZGlfY2xr
X25lZWRlZCkpCj4+ICsJCQljb250aW51ZTsKPj4gKwo+PiArCQlEUk1fTk9URSgiUG9ydCAlYyBp
cyBkaXNhYmxlZC9pbiBEU0kgbW9kZSB3aXRoIGFuIHVuZ2F0ZWQgRERJIGNsb2NrLCBnYXRlIGl0
XG4iLAo+PiArCQkJIHBvcnRfbmFtZShwb3J0KSk7Cj4+ICsJCXZhbCB8PSBpY2xfZHBjbGthX2Nm
Z2NyMF9jbGtfb2ZmKGRldl9wcml2LCBwb3J0KTsKPj4gKwkJSTkxNV9XUklURShEUENMS0FfQ0ZH
Q1IwX0lDTCwgdmFsKTsKPj4gKwl9Cj4+ICB9Cj4+ICAKPj4gIHN0YXRpYyB2b2lkIGludGVsX2Rk
aV9jbGtfc2VsZWN0KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+PiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9kc2kuaAo+PiBpbmRleCBlZTkzMTM3ZjQ0MzMuLmQ5NjhmMWYxM2UwOSAxMDA2NDQK
Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpLmgKPj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpLmgKPj4gQEAgLTE0Niw2ICsxNDYsMTEgQEAgc3RhdGlj
IGlubGluZSBib29sIGlzX2NtZF9tb2RlKHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSkKPj4g
IAlyZXR1cm4gaW50ZWxfZHNpLT5vcGVyYXRpb25fbW9kZSA9PSBJTlRFTF9EU0lfQ09NTUFORF9N
T0RFOwo+PiAgfQo+PiAgCj4+ICtzdGF0aWMgaW5saW5lIHUxNiBpbnRlbF9kc2lfZW5jb2Rlcl9w
b3J0cyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPj4gK3sKPj4gKwlyZXR1cm4gZW5j
X3RvX2ludGVsX2RzaSgmZW5jb2Rlci0+YmFzZSktPnBvcnRzOwo+PiArfQo+PiArCj4+ICAvKiBp
bnRlbF9kc2kuYyAqLwo+PiAgaW50IGludGVsX2RzaV9iaXRyYXRlKGNvbnN0IHN0cnVjdCBpbnRl
bF9kc2kgKmludGVsX2RzaSk7Cj4+ICBpbnQgaW50ZWxfZHNpX3RscHhfbnMoY29uc3Qgc3RydWN0
IGludGVsX2RzaSAqaW50ZWxfZHNpKTsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3Vy
Y2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr
dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu
dGVsLWdmeAo=