From: Andreas Schwab <schwab@linux-m68k.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org
Subject: Re: m68k allmodconfig build errors
Date: Fri, 20 Jul 2018 09:20:21 +0200 [thread overview]
Message-ID: <878t66idai.fsf@igel.home> (raw)
In-Reply-To: <28ebe45d-3dbd-2a82-f537-b0725f7a2bcf@infradead.org> (Randy Dunlap's message of "Thu, 19 Jul 2018 15:39:50 -0700")
On Jul 19 2018, Randy Dunlap <rdunlap@infradead.org> wrote:
> block/partitions/ldm.o: In function `ldm_partition':
> ldm.c:(.text+0x1900): undefined reference to `strcmp'
> ldm.c:(.text+0x1964): undefined reference to `strcmp'
> drivers/rtc/rtc-proc.o: In function `is_rtc_hctosys':
> rtc-proc.c:(.text+0x290): undefined reference to `strcmp'
> drivers/watchdog/watchdog_pretimeout.o: In function `watchdog_register_governor':
> (.text+0x142): undefined reference to `strcmp'
GCC has optimized strncmp to strcmp, but at a stage where macros are no
longer available. I think the right fix is to use strcmp directly,
since strncmp doesn't make sense here.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2018-07-20 7:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 22:39 m68k allmodconfig build errors Randy Dunlap
2018-07-20 5:17 ` Finn Thain
2018-07-24 1:49 ` Randy Dunlap
2018-07-20 7:20 ` Andreas Schwab [this message]
2018-07-24 1:52 ` Randy Dunlap
2018-07-24 4:49 ` Finn Thain
2018-07-26 19:29 ` Randy Dunlap
2018-07-27 4:44 ` Finn Thain
2018-07-27 8:40 ` Andreas Schwab
2018-07-27 12:51 ` Finn Thain
2018-07-24 17:35 ` Andreas Schwab
2018-09-26 7:44 ` Geert Uytterhoeven
2018-09-26 16:09 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t66idai.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.