From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 1/2] USB: dwc3: get extcon device by OF graph bindings Date: Tue, 15 May 2018 10:26:44 +0300 Message-ID: <878t8l9y6j.fsf@linux.intel.com> References: <20180131155718.5237-1-a.hajda@samsung.com> <20180131155718.5237-2-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: In-Reply-To: <20180131155718.5237-2-a.hajda@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: "open list:DESIGNWARE USB3 DRD IP DRIVER" Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Greg Kroah-Hartman , Inki Dae , Rob Herring , Mark Rutland , Krzysztof Kozlowski , Chanwoo Choi , Laurent Pinchart , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Andrzej Hajda writes: > extcon device is used to detect host/device connection. Since extcon > OF property is deprecated, alternative method should be added. > This method uses OF graph bindings to locate extcon. > > Signed-off-by: Andrzej Hajda > --- > Hi all, > > This patch implements alternative method to get extcon from DWC3. > The code works but is hacky, as DWC3 must traverse different DT nodes > to get extcon, in case of TM2 it is USB-PHY and MUIC, but other > platforms can have different paths. > I would be glad if it can be merged as is for now, but additional work > must be done to make it generic. > I guess on DT binding side it is OK. So the problem should be addressed > in the code. > My rough idea is to implement kind of extcon aliases/forwarder mechanism, > ie. USB-PHY will expect on its output remote port extcon, and it should r= egister > extcon-forwarder pointing to this extcon. This way DWC3 can look for the = extcon > on its PHY phandle, and it will receive via forwarding mechanism extcon > exposed by MUIC. > As I said this is rough idea for discussion, other propositions are welco= me. > > Regards > Andrzej I need someone from devicetree to review and ack patch2 before I can apply them. Either way, this doesn't apply: checking file drivers/usb/dwc3/drd.c Hunk #1 FAILED at 8. Hunk #2 FAILED at 38. 2 out of 2 hunks FAILED =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlr6i7QACgkQzL64meEa mQY04hAAn4K5ITshDV6Wslcg8R9p0Atc9aDKY2Ex7arwPRevurM8JWIspYtY9wuC 9r/nEgyTigQs17cJIxiNUhhLyfrbABiolPoVd43v6/nhLumbBus0Jaa4yA4wacLl vSeM83Pb1TZbpwplM+Yv6cE/1rd0CJ6N9yXuHXzKyf4Bx3EChzZDwznY6ZkI+3kG 7ZKpF3kiziYbsyVA648MN8mWTn0pAQGPrbVolSg0pQH0j5YNKr5JgmszEj73siCW dLrlgzotk9qE/bAymYmKAQT6MXSa/EgfjaPp6E/1cIBW+deR07dzhMjccviEkRm8 UzCYzuRXaIAJHJMsjrNvu/CwEKQBybI2LTarjKLMZeRqKl1LZQViFS8G3ufFoyGB vT8yS49HERV05mUjHeFpCEEzi053Ig3YAAmL+4mMQgbzUp0aVS95OebQk/yA0p0Y 5fDo5lI757bjW6JNySApifuKeW98+fGS2OTeBRFBaWTJB8F1AmSdOrED0yUWn1Ze d51DMQRVHvR8oZI7LNWSsIA+DkHeTCq4PpsI6q4LAs0OiKOpzZOrC/vyKii8tq9a ZLBcL1mPgM2Ua7TTgh0InZ1WV8U6VlpZm1utsH0euBb3SNxwemUks0n5wOxQoFE7 tXdNkcSnXr3UhqilCcIw8ESegy2/UIZNt6gSEPbhEenU9BBpeZA= =6lHx -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] USB: dwc3: get extcon device by OF graph bindings From: Felipe Balbi Message-Id: <878t8l9y6j.fsf@linux.intel.com> Date: Tue, 15 May 2018 10:26:44 +0300 To: Andrzej Hajda , "open list:DESIGNWARE USB3 DRD IP DRIVER" Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Greg Kroah-Hartman , Inki Dae , Rob Herring , Mark Rutland , Krzysztof Kozlowski , Chanwoo Choi , Laurent Pinchart , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org List-ID: QW5kcnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4gd3JpdGVzOgoKPiBleHRjb24gZGV2 aWNlIGlzIHVzZWQgdG8gZGV0ZWN0IGhvc3QvZGV2aWNlIGNvbm5lY3Rpb24uIFNpbmNlIGV4dGNv bgo+IE9GIHByb3BlcnR5IGlzIGRlcHJlY2F0ZWQsIGFsdGVybmF0aXZlIG1ldGhvZCBzaG91bGQg YmUgYWRkZWQuCj4gVGhpcyBtZXRob2QgdXNlcyBPRiBncmFwaCBiaW5kaW5ncyB0byBsb2NhdGUg ZXh0Y29uLgo+Cj4gU2lnbmVkLW9mZi1ieTogQW5kcnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5n LmNvbT4KPiAtLS0KPiBIaSBhbGwsCj4KPiBUaGlzIHBhdGNoIGltcGxlbWVudHMgYWx0ZXJuYXRp dmUgbWV0aG9kIHRvIGdldCBleHRjb24gZnJvbSBEV0MzLgo+IFRoZSBjb2RlIHdvcmtzIGJ1dCBp cyBoYWNreSwgYXMgRFdDMyBtdXN0IHRyYXZlcnNlIGRpZmZlcmVudCBEVCBub2Rlcwo+IHRvIGdl dCBleHRjb24sIGluIGNhc2Ugb2YgVE0yIGl0IGlzIFVTQi1QSFkgYW5kIE1VSUMsIGJ1dCBvdGhl cgo+IHBsYXRmb3JtcyBjYW4gaGF2ZSBkaWZmZXJlbnQgcGF0aHMuCj4gSSB3b3VsZCBiZSBnbGFk IGlmIGl0IGNhbiBiZSBtZXJnZWQgYXMgaXMgZm9yIG5vdywgYnV0IGFkZGl0aW9uYWwgd29yawo+ IG11c3QgYmUgZG9uZSB0byBtYWtlIGl0IGdlbmVyaWMuCj4gSSBndWVzcyBvbiBEVCBiaW5kaW5n IHNpZGUgaXQgaXMgT0suIFNvIHRoZSBwcm9ibGVtIHNob3VsZCBiZSBhZGRyZXNzZWQKPiBpbiB0 aGUgY29kZS4KPiBNeSByb3VnaCBpZGVhIGlzIHRvIGltcGxlbWVudCBraW5kIG9mIGV4dGNvbiBh bGlhc2VzL2ZvcndhcmRlciBtZWNoYW5pc20sCj4gaWUuIFVTQi1QSFkgd2lsbCBleHBlY3Qgb24g aXRzIG91dHB1dCByZW1vdGUgcG9ydCBleHRjb24sIGFuZCBpdCBzaG91bGQgcmVnaXN0ZXIKPiBl eHRjb24tZm9yd2FyZGVyIHBvaW50aW5nIHRvIHRoaXMgZXh0Y29uLiBUaGlzIHdheSBEV0MzIGNh biBsb29rIGZvciB0aGUgZXh0Y29uCj4gb24gaXRzIFBIWSBwaGFuZGxlLCBhbmQgaXQgd2lsbCBy ZWNlaXZlIHZpYSBmb3J3YXJkaW5nIG1lY2hhbmlzbSBleHRjb24KPiBleHBvc2VkIGJ5IE1VSUMu Cj4gQXMgSSBzYWlkIHRoaXMgaXMgcm91Z2ggaWRlYSBmb3IgZGlzY3Vzc2lvbiwgb3RoZXIgcHJv cG9zaXRpb25zIGFyZSB3ZWxjb21lLgo+Cj4gUmVnYXJkcwo+IEFuZHJ6ZWoKCkkgbmVlZCBzb21l b25lIGZyb20gZGV2aWNldHJlZSB0byByZXZpZXcgYW5kIGFjayBwYXRjaDIgYmVmb3JlIEkgY2Fu CmFwcGx5IHRoZW0uIEVpdGhlciB3YXksIHRoaXMgZG9lc24ndCBhcHBseToKCmNoZWNraW5nIGZp bGUgZHJpdmVycy91c2IvZHdjMy9kcmQuYwpIdW5rICMxIEZBSUxFRCBhdCA4LgpIdW5rICMyIEZB SUxFRCBhdCAzOC4KMiBvdXQgb2YgMiBodW5rcyBGQUlMRUQK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZpcQvrzGZRufoKXc3e509rzEWtvs546Mj5uKvn1VdivO0qx0WuUcKCvOeWq6BGJ6g005KXy ARC-Seal: i=1; a=rsa-sha256; t=1526369305; cv=none; d=google.com; s=arc-20160816; b=RxgHXa9l1wjMCzu0ezefUQvYR0Tk1sIoE1M/yfSF3FWKeN/6zH4+EqnJKxjDAUKrws Xbj34BlKOSs9EGhslXIab3RyyenWk7BzV4ksFDBJRy0diUtp9Jj34c6YddFn/3kRLcmq R9syHtrX+aBhF3si6GDk4ndYOKrExdRl2uNNLmupbBmBaUGjITvNGpc4qcj1MbeFu2ER QKpWbC7h+MDLFAhMjM8PkaasipE/emYBPgXUxxoVYtNqvoWfkxoAPY1wKMAPvJUIKjOu LQLgJxvXRNo9em4LFaC6zJqdaz68MgN6ajZU6eozLZed+fy+8Q+QqnInahDnJGhashQ6 3Wvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:arc-authentication-results; bh=S/nEfvjOAg1i6mH9vmk+QII896hGHp1lSazu8+OqT58=; b=Qfv/tDE2bpWgFkagIe6qYASE0D7muuqrWfOQNzUX9HYzIhZAtrx7dPogln+/A2jyn7 bIFMj7xaiaGBVVoX9CPydxYZxE4jfcDADlh05mAgti4t8y+LVK/FstH6k4p4KP/VfzV4 sb/RkmLpN6tZoIilJE1AOwwMZW7KMkC9/x/wskZhHpbzCHDYx53GL6v0G09oeRgjh6NC GKC+yOogV7n/L86k/FF3ewFYGSrzpxnjVMoAa4K13efu60Z5U29HSavl7gecyr58FCvl 5b52OldUm851DhHdzLg0yKGebkmVJ+aB+WM65EyLzgCKOmDmPwDaY0hiPfnAl8LNmhZ2 xmtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of felipe.balbi@linux.intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=felipe.balbi@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of felipe.balbi@linux.intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=felipe.balbi@linux.intel.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,403,1520924400"; d="asc'?scan'208";a="41023027" From: Felipe Balbi To: Andrzej Hajda , "open list\:DESIGNWARE USB3 DRD IP DRIVER" Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Greg Kroah-Hartman , Inki Dae , Rob Herring , Mark Rutland , Krzysztof Kozlowski , Chanwoo Choi , Laurent Pinchart , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 1/2] USB: dwc3: get extcon device by OF graph bindings In-Reply-To: <20180131155718.5237-2-a.hajda@samsung.com> References: <20180131155718.5237-1-a.hajda@samsung.com> <20180131155718.5237-2-a.hajda@samsung.com> Date: Tue, 15 May 2018 10:26:44 +0300 Message-ID: <878t8l9y6j.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1591124175136204750?= X-GMAIL-MSGID: =?utf-8?q?1600514221468588157?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Andrzej Hajda writes: > extcon device is used to detect host/device connection. Since extcon > OF property is deprecated, alternative method should be added. > This method uses OF graph bindings to locate extcon. > > Signed-off-by: Andrzej Hajda > --- > Hi all, > > This patch implements alternative method to get extcon from DWC3. > The code works but is hacky, as DWC3 must traverse different DT nodes > to get extcon, in case of TM2 it is USB-PHY and MUIC, but other > platforms can have different paths. > I would be glad if it can be merged as is for now, but additional work > must be done to make it generic. > I guess on DT binding side it is OK. So the problem should be addressed > in the code. > My rough idea is to implement kind of extcon aliases/forwarder mechanism, > ie. USB-PHY will expect on its output remote port extcon, and it should r= egister > extcon-forwarder pointing to this extcon. This way DWC3 can look for the = extcon > on its PHY phandle, and it will receive via forwarding mechanism extcon > exposed by MUIC. > As I said this is rough idea for discussion, other propositions are welco= me. > > Regards > Andrzej I need someone from devicetree to review and ack patch2 before I can apply them. Either way, this doesn't apply: checking file drivers/usb/dwc3/drd.c Hunk #1 FAILED at 8. Hunk #2 FAILED at 38. 2 out of 2 hunks FAILED =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlr6i7QACgkQzL64meEa mQY04hAAn4K5ITshDV6Wslcg8R9p0Atc9aDKY2Ex7arwPRevurM8JWIspYtY9wuC 9r/nEgyTigQs17cJIxiNUhhLyfrbABiolPoVd43v6/nhLumbBus0Jaa4yA4wacLl vSeM83Pb1TZbpwplM+Yv6cE/1rd0CJ6N9yXuHXzKyf4Bx3EChzZDwznY6ZkI+3kG 7ZKpF3kiziYbsyVA648MN8mWTn0pAQGPrbVolSg0pQH0j5YNKr5JgmszEj73siCW dLrlgzotk9qE/bAymYmKAQT6MXSa/EgfjaPp6E/1cIBW+deR07dzhMjccviEkRm8 UzCYzuRXaIAJHJMsjrNvu/CwEKQBybI2LTarjKLMZeRqKl1LZQViFS8G3ufFoyGB vT8yS49HERV05mUjHeFpCEEzi053Ig3YAAmL+4mMQgbzUp0aVS95OebQk/yA0p0Y 5fDo5lI757bjW6JNySApifuKeW98+fGS2OTeBRFBaWTJB8F1AmSdOrED0yUWn1Ze d51DMQRVHvR8oZI7LNWSsIA+DkHeTCq4PpsI6q4LAs0OiKOpzZOrC/vyKii8tq9a ZLBcL1mPgM2Ua7TTgh0InZ1WV8U6VlpZm1utsH0euBb3SNxwemUks0n5wOxQoFE7 tXdNkcSnXr3UhqilCcIw8ESegy2/UIZNt6gSEPbhEenU9BBpeZA= =6lHx -----END PGP SIGNATURE----- --=-=-=--