diff for duplicates of <878tbdf7wb.fsf@bootlin.com> diff --git a/a/1.txt b/N1/1.txt index 638b557..fa59115 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,25 +1,37 @@ -SGkgUnVzc2VsbCBLaW5nLAogCiBPbiBtZXIuLCBmw6l2ci4gMjggMjAxOCwgUnVzc2VsbCBLaW5n -IC0gQVJNIExpbnV4IDxsaW51eEBhcm1saW51eC5vcmcudWs+IHdyb3RlOgoKPiBPbiBXZWQsIEZl -YiAyOCwgMjAxOCBhdCAwMzo0NzowNFBNICswMTAwLCBHcmVnb3J5IENMRU1FTlQgd3JvdGU6Cj4+ -IEBAIC0yMjksNiArMjMwLDE1IEBAIHN0YXRpYyBpbnQgYXJtYWRhOGtfcGNpZV9wcm9iZShzdHJ1 -Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+PiAgCWlmIChyZXQpCj4+ICAJCXJldHVybiByZXQ7 -Cj4+ICAKPj4gKwlpZiAoSVNfRVJSKHBjaWUtPmNsa19yZWcpICYmIFBUUl9FUlIocGNpZS0+Y2xr -X3JlZykgPT0gLUVQUk9CRV9ERUZFUikgewo+Cj4gWW91IGRvIHJlYWxpc2UgdGhpcyBpcyBuZWVk -bGVzc2x5IGNvbXBsZXguCj4KPiBQb2ludGVyIGVycm9ycyBhcmUgdW5pcXVlLCBzbzoKPgo+IAlp -ZiAocGNpZS0+Y2xrX3JlZyA9PSBFUlJfUFRSKC1FUFJPQkVfREVGRVIpKSB7Cj4KPiB3aWxsIGRv -IHRoZSBzYW1lIHRoaW5nIGJ1dCB3aXRob3V0IHRoZSBjb21wbGV4aXR5LiAgVHJhbnNmb3JtaW5n -IHRoZQo+IGNvbnN0YW50IHJhdGhlciB0aGFuIHRoZSB2YXJpYWJsZSBpcyBhbHNvIGEgZ29vZCBo -YWJiaXQgdG8gZ2V0IGludG8gLQo+IHRoZSBjb21waWxlciBjYW4gb3B0aW1pc2UgdHJhbnNmb3Jt -cyB0byBjb25zdGFudHMsIGJ1dCBjYW4ndCB3aXRoCj4gdmFyaWFibGVzLCBzbyBjb21wYXJpc29u -cyBpbnZvbHZpbmcgdGhpbmdzIGxpa2UgZW5kaWFuIGNvbnZlcnNpb24KPiBzaG91bGQgYWx3YXlz -IGJlIGRvbmUgYnkgdHJhbnNmb3JtaW5nIHRoZSBjb25zdGFudCBub3QgdGhlIHZhcmlhYmxlLgoK -VGhhbmtzIGZvciB0aGUgdGlwLCBJIHdpbGwgdXNlIGl0IGluIHRoZSBuZXh0IHZlcnNpb24uCgpH -cmVnb3J5Cgo+Cj4gLS0gCj4gUk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwOi8vd3d3LmFybWxpbnV4 -Lm9yZy51ay9kZXZlbG9wZXIvcGF0Y2hlcy8KPiBGVFRDIGJyb2FkYmFuZCBmb3IgMC44bWlsZSBs -aW5lIGluIHN1YnVyYmlhOiBzeW5jIGF0IDguOE1icHMgZG93biA2MzBrYnBzIHVwCj4gQWNjb3Jk -aW5nIHRvIHNwZWVkdGVzdC5uZXQ6IDguMjFNYnBzIGRvd24gNTEwa2JwcyB1cAoKLS0gCkdyZWdv -cnkgQ2xlbWVudCwgQm9vdGxpbiAoZm9ybWVybHkgRnJlZSBFbGVjdHJvbnMpCkVtYmVkZGVkIExp -bnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cDovL2Jvb3RsaW4uY29tCgpfX19fX19fX19f -X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h -aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp -c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== +Hi Russell King, + + On mer., f?vr. 28 2018, Russell King - ARM Linux <linux@armlinux.org.uk> wrote: + +> On Wed, Feb 28, 2018 at 03:47:04PM +0100, Gregory CLEMENT wrote: +>> @@ -229,6 +230,15 @@ static int armada8k_pcie_probe(struct platform_device *pdev) +>> if (ret) +>> return ret; +>> +>> + if (IS_ERR(pcie->clk_reg) && PTR_ERR(pcie->clk_reg) == -EPROBE_DEFER) { +> +> You do realise this is needlessly complex. +> +> Pointer errors are unique, so: +> +> if (pcie->clk_reg == ERR_PTR(-EPROBE_DEFER)) { +> +> will do the same thing but without the complexity. Transforming the +> constant rather than the variable is also a good habbit to get into - +> the compiler can optimise transforms to constants, but can't with +> variables, so comparisons involving things like endian conversion +> should always be done by transforming the constant not the variable. + +Thanks for the tip, I will use it in the next version. + +Gregory + +> +> -- +> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ +> FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up +> According to speedtest.net: 8.21Mbps down 510kbps up + +-- +Gregory Clement, Bootlin (formerly Free Electrons) +Embedded Linux and Kernel engineering +http://bootlin.com diff --git a/a/content_digest b/N1/content_digest index b016e4e..5abcb4d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,52 +1,48 @@ "ref\020180228144704.12947-1-gregory.clement@bootlin.com\0" "ref\020180228144704.12947-3-gregory.clement@bootlin.com\0" "ref\020180228152756.GV9418@n2100.armlinux.org.uk\0" - "From\0Gregory CLEMENT <gregory.clement@bootlin.com>\0" - "Subject\0Re: [PATCH 2/2] PCI: armada8k: Fix clock resource by adding a register clock\0" + "From\0gregory.clement@bootlin.com (Gregory CLEMENT)\0" + "Subject\0[PATCH 2/2] PCI: armada8k: Fix clock resource by adding a register clock\0" "Date\0Wed, 28 Feb 2018 16:31:16 +0100\0" - "To\0Russell King - ARM Linux <linux@armlinux.org.uk>\0" - "Cc\0Andrew Lunn <andrew@lunn.ch>" - Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - Jason Cooper <jason@lakedaemon.net> - Antoine Tenart <antoine.tenart@bootlin.com> - linux-pci@vger.kernel.org - Hanna Hawa <hannah@marvell.com> - Omri Itach <omrii@marvell.com> - Nadav Haklai <nadavh@marvell.com> - Shadi Ammouri <shadi@marvell.com> - linux-arm-kernel@lists.infradead.org - Thomas Petazzoni <thomas.petazzoni@bootlin.com> - " Miqu\303\250l Raynal <miquel.raynal@bootlin.com>" - Bjorn Helgaas <bhelgaas@google.com> - Marcin Wojtas <mw@semihalf.com> - Igal Liberman <igall@marvell.com> - " Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "SGkgUnVzc2VsbCBLaW5nLAogCiBPbiBtZXIuLCBmw6l2ci4gMjggMjAxOCwgUnVzc2VsbCBLaW5n\n" - "IC0gQVJNIExpbnV4IDxsaW51eEBhcm1saW51eC5vcmcudWs+IHdyb3RlOgoKPiBPbiBXZWQsIEZl\n" - "YiAyOCwgMjAxOCBhdCAwMzo0NzowNFBNICswMTAwLCBHcmVnb3J5IENMRU1FTlQgd3JvdGU6Cj4+\n" - "IEBAIC0yMjksNiArMjMwLDE1IEBAIHN0YXRpYyBpbnQgYXJtYWRhOGtfcGNpZV9wcm9iZShzdHJ1\n" - "Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+PiAgCWlmIChyZXQpCj4+ICAJCXJldHVybiByZXQ7\n" - "Cj4+ICAKPj4gKwlpZiAoSVNfRVJSKHBjaWUtPmNsa19yZWcpICYmIFBUUl9FUlIocGNpZS0+Y2xr\n" - "X3JlZykgPT0gLUVQUk9CRV9ERUZFUikgewo+Cj4gWW91IGRvIHJlYWxpc2UgdGhpcyBpcyBuZWVk\n" - "bGVzc2x5IGNvbXBsZXguCj4KPiBQb2ludGVyIGVycm9ycyBhcmUgdW5pcXVlLCBzbzoKPgo+IAlp\n" - "ZiAocGNpZS0+Y2xrX3JlZyA9PSBFUlJfUFRSKC1FUFJPQkVfREVGRVIpKSB7Cj4KPiB3aWxsIGRv\n" - "IHRoZSBzYW1lIHRoaW5nIGJ1dCB3aXRob3V0IHRoZSBjb21wbGV4aXR5LiAgVHJhbnNmb3JtaW5n\n" - "IHRoZQo+IGNvbnN0YW50IHJhdGhlciB0aGFuIHRoZSB2YXJpYWJsZSBpcyBhbHNvIGEgZ29vZCBo\n" - "YWJiaXQgdG8gZ2V0IGludG8gLQo+IHRoZSBjb21waWxlciBjYW4gb3B0aW1pc2UgdHJhbnNmb3Jt\n" - "cyB0byBjb25zdGFudHMsIGJ1dCBjYW4ndCB3aXRoCj4gdmFyaWFibGVzLCBzbyBjb21wYXJpc29u\n" - "cyBpbnZvbHZpbmcgdGhpbmdzIGxpa2UgZW5kaWFuIGNvbnZlcnNpb24KPiBzaG91bGQgYWx3YXlz\n" - "IGJlIGRvbmUgYnkgdHJhbnNmb3JtaW5nIHRoZSBjb25zdGFudCBub3QgdGhlIHZhcmlhYmxlLgoK\n" - "VGhhbmtzIGZvciB0aGUgdGlwLCBJIHdpbGwgdXNlIGl0IGluIHRoZSBuZXh0IHZlcnNpb24uCgpH\n" - "cmVnb3J5Cgo+Cj4gLS0gCj4gUk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwOi8vd3d3LmFybWxpbnV4\n" - "Lm9yZy51ay9kZXZlbG9wZXIvcGF0Y2hlcy8KPiBGVFRDIGJyb2FkYmFuZCBmb3IgMC44bWlsZSBs\n" - "aW5lIGluIHN1YnVyYmlhOiBzeW5jIGF0IDguOE1icHMgZG93biA2MzBrYnBzIHVwCj4gQWNjb3Jk\n" - "aW5nIHRvIHNwZWVkdGVzdC5uZXQ6IDguMjFNYnBzIGRvd24gNTEwa2JwcyB1cAoKLS0gCkdyZWdv\n" - "cnkgQ2xlbWVudCwgQm9vdGxpbiAoZm9ybWVybHkgRnJlZSBFbGVjdHJvbnMpCkVtYmVkZGVkIExp\n" - "bnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cDovL2Jvb3RsaW4uY29tCgpfX19fX19fX19f\n" - "X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h\n" - "aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp\n" - c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== + "Hi Russell King,\n" + " \n" + " On mer., f?vr. 28 2018, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:\n" + "\n" + "> On Wed, Feb 28, 2018 at 03:47:04PM +0100, Gregory CLEMENT wrote:\n" + ">> @@ -229,6 +230,15 @@ static int armada8k_pcie_probe(struct platform_device *pdev)\n" + ">> \tif (ret)\n" + ">> \t\treturn ret;\n" + ">> \n" + ">> +\tif (IS_ERR(pcie->clk_reg) && PTR_ERR(pcie->clk_reg) == -EPROBE_DEFER) {\n" + ">\n" + "> You do realise this is needlessly complex.\n" + ">\n" + "> Pointer errors are unique, so:\n" + ">\n" + "> \tif (pcie->clk_reg == ERR_PTR(-EPROBE_DEFER)) {\n" + ">\n" + "> will do the same thing but without the complexity. Transforming the\n" + "> constant rather than the variable is also a good habbit to get into -\n" + "> the compiler can optimise transforms to constants, but can't with\n" + "> variables, so comparisons involving things like endian conversion\n" + "> should always be done by transforming the constant not the variable.\n" + "\n" + "Thanks for the tip, I will use it in the next version.\n" + "\n" + "Gregory\n" + "\n" + ">\n" + "> -- \n" + "> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/\n" + "> FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up\n" + "> According to speedtest.net: 8.21Mbps down 510kbps up\n" + "\n" + "-- \n" + "Gregory Clement, Bootlin (formerly Free Electrons)\n" + "Embedded Linux and Kernel engineering\n" + http://bootlin.com -8fa107332af3681eee9daad53991b7f9fd36fff3741edcaa62dd6e8fcd1b562b +4a5fe0c17ba2091bbacf1d5ee83e7d5febd4e362d29cd94199e5b0d0bad5d628
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.