From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
"Emilio G. Cota" <cota@braap.org>,
hsp.cat7@gmail.com
Subject: Re: [Qemu-devel] [PATCH 00/24] re-factor and add fp16 using glibc soft-fp
Date: Tue, 06 Feb 2018 20:45:38 +0000 [thread overview]
Message-ID: <878tc5x2x9.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA8+zNg8S=sFuUwPKjzzJZFUYDZFU11nH+_M60wuXRAVrQ@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 4 February 2018 at 04:11, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>> Or there's the code from glibc. I know Peter didn't like the idea;
>> debugging this code is fairly painful -- the massive preprocessor
>> macros mean that you can't step through anything. But at least we
>> have a good relationship with glibc, so merging patches back and
>> forth should be easy.
>
> Yeah. I didn't like dealing with this code two decades ago
> when I first encountered it, and it hasn't improved any.
> It's pretty much write-only code, and it isn't going to be
> any fun for debugging.
I think I've managed to pull the performance back on softfloat-v4 thanks
to the attribute(flatten) changes to addsub/div/mul/mulladd.
--
Alex Bennée
next prev parent reply other threads:[~2018-02-06 20:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 4:11 [Qemu-devel] [PATCH 00/24] re-factor and add fp16 using glibc soft-fp Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 01/24] fpu/softfloat: implement float16_squash_input_denormal Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 02/24] include/fpu/softfloat: remove USE_SOFTFLOAT_STRUCT_TYPES Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 03/24] fpu/softfloat-types: new header to prevent excessive re-builds Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 04/24] target/*/cpu.h: remove softfloat.h Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 05/24] include/fpu/softfloat: implement float16_abs helper Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 06/24] include/fpu/softfloat: implement float16_chs helper Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 07/24] include/fpu/softfloat: implement float16_set_sign helper Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 08/24] include/fpu/softfloat: add some float16 constants Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 09/24] fpu/softfloat: improve comments on ARM NaN propagation Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 10/24] fpu/soft-fp: Import soft-fp from glibc Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 11/24] fpu/soft-fp: Adjust soft-fp types Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 12/24] fpu/soft-fp: Add ties_away and to_odd rounding modes Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 13/24] fpu/soft-fp: Add arithmetic macros to half.h Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 14/24] fpu/soft-fp: Adjust _FP_CMP_CHECK_NAN Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 15/24] fpu: Implement add/sub/mul/div with soft-fp.h Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 16/24] fpu: Implement float_to_int/uint " Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 17/24] fpu: Implement int/uint_to_float " Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 18/24] fpu: Implement compares " Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 19/24] fpu: Implement min/max " Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 20/24] fpu: Implement sqrt " Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 21/24] fpu: Implement scalbn " Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 22/24] fpu: Implement float_to_float " Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 23/24] fpu: Implement muladd " Richard Henderson
2018-02-04 4:11 ` [Qemu-devel] [PATCH 24/24] fpu: Implement round_to_int " Richard Henderson
2018-02-04 8:56 ` [Qemu-devel] [PATCH 00/24] re-factor and add fp16 using glibc soft-fp Howard Spoelstra
2018-02-04 15:00 ` Peter Maydell
2018-02-06 20:45 ` Alex Bennée [this message]
2018-02-08 21:04 ` no-reply
2018-02-08 21:11 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tc5x2x9.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=hsp.cat7@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.