From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2 2/3] drm/i915: Move the scheduler feature bits into the purview of the engines Date: Wed, 31 Jan 2018 15:58:17 +0200 Message-ID: <878tcew2o6.fsf@gaia.fi.intel.com> References: <20180131094703.3676-1-chris@chris-wilson.co.uk> <20180131094703.3676-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 477746EBFE for ; Wed, 31 Jan 2018 13:58:37 +0000 (UTC) In-Reply-To: <20180131094703.3676-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUmF0aGVy IHRoYW4gaGF2aW5nIHRoZSBoaWdoIGxldmVsIGlvY3RsIGludGVyZmFjZSBndWVzcyB0aGUgdW5k ZXJseWluZwo+IGltcGxlbWVudGF0aW9uIGRldGFpbHMsIGhhdmluZyB0aGUgaW1wbGVtZW50YXRp b24gZGVjbGFyZSB3aGF0Cj4gY2FwYWJpbGl0aWVzIGl0IGV4cG9ydHMuIFdlIGRlZmluZSBhbiBp bnRlbF9kcml2ZXJfY2Fwcywgc2ltaWxhciB0byB0aGUKPiBpbnRlbF9kZXZpY2VfaW5mbywgd2hp Y2ggaW5zdGVhZCBvZiB0cnlpbmcgdG8gZGVzY3JpYmUgdGhlIEhXIGdpdmVzCj4gZGV0YWlscyBv biB3aGF0IHRoZSBkcml2ZXIgaXRzZWxmIHN1cHBvcnRzLiBUaGlzIGlzIHRoZW4gcG9wdWxhdGVk IGJ5Cj4gdGhlIGVuZ2luZSBiYWNrZW5kIGZvciB0aGUgbmV3IHNjaGVkdWxlciBjYXBhYmlsaXR5 IGZpZWxkIGZvciB1c2UKPiBlbHNld2hlcmUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVG9tYXN6IExpcyA8dG9tYXN6Lmxp c0BpbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4 LmludGVsLmNvbT4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNv bT4KPiBDYzogTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgICAgICAgICAgfCA4ICstLS0t LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICAgfCAyICsrCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgICAgICAgICAgfCAzICsrKwo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jICAgIHwgNyArKysrKy0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmMgfCA2ICsrKysrKwo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kZXZpY2VfaW5mby5oIHwgNyArKysrKysrCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICAgfCA2ICsrKysrKwo+ICA3IGZpbGVzIGNo YW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmMKPiBpbmRleCAxZWMxMmFkZDM0YjIuLjczM2Y3MTYzNzkxNCAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuYwo+IEBAIC0zNzIsMTMgKzM3Miw3IEBAIHN0YXRpYyBpbnQgaTkxNV9n ZXRwYXJhbShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJCXZhbHVlID0g aTkxNV9nZW1fbW1hcF9ndHRfdmVyc2lvbigpOwo+ICAJCWJyZWFrOwo+ICAJY2FzZSBJOTE1X1BB UkFNX0hBU19TQ0hFRFVMRVI6Cj4gLQkJdmFsdWUgPSAwOwo+IC0JCWlmIChkZXZfcHJpdi0+ZW5n aW5lW1JDU10gJiYgZGV2X3ByaXYtPmVuZ2luZVtSQ1NdLT5zY2hlZHVsZSkgewo+IC0JCQl2YWx1 ZSB8PSBJOTE1X1NDSEVEVUxFUl9DQVBfRU5BQkxFRDsKPiAtCQkJdmFsdWUgfD0gSTkxNV9TQ0hF RFVMRVJfQ0FQX1BSSU9SSVRZOwo+IC0JCQlpZiAoSEFTX0xPR0lDQUxfUklOR19QUkVFTVBUSU9O KGRldl9wcml2KSkKPiAtCQkJCXZhbHVlIHw9IEk5MTVfU0NIRURVTEVSX0NBUF9QUkVFTVBUSU9O Owo+IC0JCX0KPiArCQl2YWx1ZSA9IGRldl9wcml2LT5jYXBzLnNjaGVkdWxlcjsKClVzZSB0aGUg c2hpbnkgQ0FQX1BSSU9SSVRZIGluc3RlYWQgb2YgcmNzLT5zY2hlZHVsZSBvbiB0aGUKSTkxNV9D T05URVhUX1BBUkFNX1BSSU9SSVRZIHZhbGlkYXRpb24/CgotTWlrYQoKPiAgCQlicmVhazsKPiAg Cj4gIAljYXNlIEk5MTVfUEFSQU1fTU1BUF9WRVJTSU9OOgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aAo+IGluZGV4IDM4OGI3MmNjY2RlNC4uYWU0MzRjOWQyYjRmIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4gQEAgLTQ2OCw2ICs0NjgsNyBAQCBzdHJ1Y3QgaTkxNV9ncHVfc3RhdGUgewo+ ICAJdTMyIHJlc2V0X2NvdW50Owo+ICAJdTMyIHN1c3BlbmRfY291bnQ7Cj4gIAlzdHJ1Y3QgaW50 ZWxfZGV2aWNlX2luZm8gZGV2aWNlX2luZm87Cj4gKwlzdHJ1Y3QgaW50ZWxfZHJpdmVyX2NhcHMg ZHJpdmVyX2NhcHM7Cj4gIAlzdHJ1Y3QgaTkxNV9wYXJhbXMgcGFyYW1zOwo+ICAKPiAgCXN0cnVj dCBpOTE1X2Vycm9yX3VjIHsKPiBAQCAtMTgwOCw2ICsxODA5LDcgQEAgc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgewo+ICAJc3RydWN0IGttZW1fY2FjaGUgKnByaW9yaXRpZXM7Cj4gIAo+ICAJY29u c3Qgc3RydWN0IGludGVsX2RldmljZV9pbmZvIGluZm87Cj4gKwlzdHJ1Y3QgaW50ZWxfZHJpdmVy X2NhcHMgY2FwczsKPiAgCj4gIAkvKioKPiAgCSAqIERhdGEgU3RvbGVuIE1lbW9yeSAtIGFrYSAi aTkxNSBzdG9sZW4gbWVtb3J5IiBnaXZlcyB1cyB0aGUgc3RhcnQgYW5kCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbS5jCj4gaW5kZXggMDYyYjIxNDA4Njk4Li5hZDdiZDBkYzU3ZWUgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPiBAQCAtMzIyMyw4ICszMjIzLDExIEBAIHZvaWQgaTkxNV9nZW1f c2V0X3dlZGdlZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiAgCQkgKiBzdGFydCB0 byBjb21wbGV0ZSBhbGwgcmVxdWVzdHMuCj4gIAkJICovCj4gIAkJZW5naW5lLT5zdWJtaXRfcmVx dWVzdCA9IG5vcF9jb21wbGV0ZV9zdWJtaXRfcmVxdWVzdDsKPiArCQllbmdpbmUtPnNjaGVkdWxl ID0gTlVMTDsKPiAgCX0KPiAgCj4gKwlpOTE1LT5jYXBzLnNjaGVkdWxlciA9IDA7Cj4gKwo+ICAJ LyoKPiAgCSAqIE1ha2Ugc3VyZSBubyByZXF1ZXN0IGNhbiBzbGlwIHRocm91Z2ggd2l0aG91dCBn ZXR0aW5nIGNvbXBsZXRlZCBieQo+ICAJICogZWl0aGVyIHRoaXMgY2FsbCBoZXJlIHRvIGludGVs X2VuZ2luZV9pbml0X2dsb2JhbF9zZXFubywgb3IgdGhlIG9uZQo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9ncHVfZXJyb3IuYwo+IGluZGV4IGE4MTM1MWQ5ZTNhNi4uYTkyYjBjMDM3N2M3IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4gQEAgLTU3MywxMSArNTczLDEz IEBAIHN0YXRpYyB2b2lkIHByaW50X2Vycm9yX29iaihzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfc3Rh dGVfYnVmICptLAo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBlcnJfcHJpbnRfY2FwYWJpbGl0aWVz KHN0cnVjdCBkcm1faTkxNV9lcnJvcl9zdGF0ZV9idWYgKm0sCj4gLQkJCQkgICBjb25zdCBzdHJ1 Y3QgaW50ZWxfZGV2aWNlX2luZm8gKmluZm8pCj4gKwkJCQkgICBjb25zdCBzdHJ1Y3QgaW50ZWxf ZGV2aWNlX2luZm8gKmluZm8sCj4gKwkJCQkgICBjb25zdCBzdHJ1Y3QgaW50ZWxfZHJpdmVyX2Nh cHMgKmNhcHMpCj4gIHsKPiAgCXN0cnVjdCBkcm1fcHJpbnRlciBwID0gaTkxNV9lcnJvcl9wcmlu dGVyKG0pOwo+ICAKPiAgCWludGVsX2RldmljZV9pbmZvX2R1bXBfZmxhZ3MoaW5mbywgJnApOwo+ ICsJaW50ZWxfZHJpdmVyX2NhcHNfcHJpbnQoY2FwcywgJnApOwo+ICB9Cj4gIAo+ICBzdGF0aWMg dm9pZCBlcnJfcHJpbnRfcGFyYW1zKHN0cnVjdCBkcm1faTkxNV9lcnJvcl9zdGF0ZV9idWYgKm0s Cj4gQEAgLTgwMCw3ICs4MDIsNyBAQCBpbnQgaTkxNV9lcnJvcl9zdGF0ZV90b19zdHIoc3RydWN0 IGRybV9pOTE1X2Vycm9yX3N0YXRlX2J1ZiAqbSwKPiAgCWlmIChlcnJvci0+ZGlzcGxheSkKPiAg CQlpbnRlbF9kaXNwbGF5X3ByaW50X2Vycm9yX3N0YXRlKG0sIGVycm9yLT5kaXNwbGF5KTsKPiAg Cj4gLQllcnJfcHJpbnRfY2FwYWJpbGl0aWVzKG0sICZlcnJvci0+ZGV2aWNlX2luZm8pOwo+ICsJ ZXJyX3ByaW50X2NhcGFiaWxpdGllcyhtLCAmZXJyb3ItPmRldmljZV9pbmZvLCAmZXJyb3ItPmRy aXZlcl9jYXBzKTsKPiAgCWVycl9wcmludF9wYXJhbXMobSwgJmVycm9yLT5wYXJhbXMpOwo+ICAJ ZXJyX3ByaW50X3VjKG0sICZlcnJvci0+dWMpOwo+ICAKPiBAQCAtMTczMSw2ICsxNzMzLDcgQEAg c3RhdGljIHZvaWQgaTkxNV9jYXB0dXJlX2dlbl9zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gIAltZW1jcHkoJmVycm9yLT5kZXZpY2VfaW5mbywKPiAgCSAgICAgICBJ TlRFTF9JTkZPKGRldl9wcml2KSwKPiAgCSAgICAgICBzaXplb2YoZXJyb3ItPmRldmljZV9pbmZv KSk7Cj4gKwllcnJvci0+ZHJpdmVyX2NhcHMgPSBkZXZfcHJpdi0+Y2FwczsKPiAgfQo+ICAKPiAg c3RhdGljIF9fYWx3YXlzX2lubGluZSB2b2lkIGR1cF9wYXJhbShjb25zdCBjaGFyICp0eXBlLCB2 b2lkICp4KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZXZpY2Vf aW5mby5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uYwo+IGluZGV4 IGEyYzE2MTQwMTY5Zi4uMjk4Zjg5OTZjYzU0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kZXZpY2VfaW5mby5jCj4gQEAgLTU4NiwzICs1ODYsOSBAQCB2b2lkIGludGVsX2Rldmlj ZV9pbmZvX3J1bnRpbWVfaW5pdChzdHJ1Y3QgaW50ZWxfZGV2aWNlX2luZm8gKmluZm8pCj4gIAkv KiBJbml0aWFsaXplIGNvbW1hbmQgc3RyZWFtIHRpbWVzdGFtcCBmcmVxdWVuY3kgKi8KPiAgCWlu Zm8tPmNzX3RpbWVzdGFtcF9mcmVxdWVuY3lfa2h6ID0gcmVhZF90aW1lc3RhbXBfZnJlcXVlbmN5 KGRldl9wcml2KTsKPiAgfQo+ICsKPiArdm9pZCBpbnRlbF9kcml2ZXJfY2Fwc19wcmludChjb25z dCBzdHJ1Y3QgaW50ZWxfZHJpdmVyX2NhcHMgKmNhcHMsCj4gKwkJCSAgICAgc3RydWN0IGRybV9w cmludGVyICpwKQo+ICt7Cj4gKwlkcm1fcHJpbnRmKHAsICJzY2hlZHVsZXI6ICV4XG4iLCBjYXBz LT5zY2hlZHVsZXIpOwo+ICt9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RldmljZV9pbmZvLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZXZpY2VfaW5m by5oCj4gaW5kZXggOTU0MjAxOGQxMWQwLi43MWZkZmIwNDUxZWYgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uaAo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmgKPiBAQCAtMTY3LDYgKzE2NywxMCBAQCBzdHJ1 Y3QgaW50ZWxfZGV2aWNlX2luZm8gewo+ICAJfSBjb2xvcjsKPiAgfTsKPiAgCj4gK3N0cnVjdCBp bnRlbF9kcml2ZXJfY2FwcyB7Cj4gKwl1bnNpZ25lZCBpbnQgc2NoZWR1bGVyOwo+ICt9Owo+ICsK PiAgc3RhdGljIGlubGluZSB1bnNpZ25lZCBpbnQgc3NldV9zdWJzbGljZV90b3RhbChjb25zdCBz dHJ1Y3Qgc3NldV9kZXZfaW5mbyAqc3NldSkKPiAgewo+ICAJcmV0dXJuIGh3ZWlnaHQ4KHNzZXUt PnNsaWNlX21hc2spICogaHdlaWdodDgoc3NldS0+c3Vic2xpY2VfbWFzayk7Cj4gQEAgLTE4Miw0 ICsxODYsNyBAQCB2b2lkIGludGVsX2RldmljZV9pbmZvX2R1bXBfZmxhZ3MoY29uc3Qgc3RydWN0 IGludGVsX2RldmljZV9pbmZvICppbmZvLAo+ICB2b2lkIGludGVsX2RldmljZV9pbmZvX2R1bXBf cnVudGltZShjb25zdCBzdHJ1Y3QgaW50ZWxfZGV2aWNlX2luZm8gKmluZm8sCj4gIAkJCQkgICAg c3RydWN0IGRybV9wcmludGVyICpwKTsKPiAgCj4gK3ZvaWQgaW50ZWxfZHJpdmVyX2NhcHNfcHJp bnQoY29uc3Qgc3RydWN0IGludGVsX2RyaXZlcl9jYXBzICpjYXBzLAo+ICsJCQkgICAgIHN0cnVj dCBkcm1fcHJpbnRlciAqcCk7Cj4gKwo+ICAjZW5kaWYKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMu Ywo+IGluZGV4IDJmYTMyOGQ1MTJmYy4uNTM5MDg5NDAwMWYwIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfbHJjLmMKPiBAQCAtMTkwNiw2ICsxOTA2LDEyIEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0 c19zZXRfZGVmYXVsdF9zdWJtaXNzaW9uKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkK PiAgCWVuZ2luZS0+dW5wYXJrID0gTlVMTDsKPiAgCj4gIAllbmdpbmUtPmZsYWdzIHw9IEk5MTVf RU5HSU5FX1NVUFBPUlRTX1NUQVRTOwo+ICsKPiArCWVuZ2luZS0+aTkxNS0+Y2Fwcy5zY2hlZHVs ZXIgPQo+ICsJCUk5MTVfU0NIRURVTEVSX0NBUF9FTkFCTEVEIHwKPiArCQlJOTE1X1NDSEVEVUxF Ul9DQVBfUFJJT1JJVFk7Cj4gKwlpZiAoSEFTX0xPR0lDQUxfUklOR19QUkVFTVBUSU9OKGVuZ2lu ZS0+aTkxNSkpCj4gKwkJZW5naW5lLT5pOTE1LT5jYXBzLnNjaGVkdWxlciB8PSBJOTE1X1NDSEVE VUxFUl9DQVBfUFJFRU1QVElPTjsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQKPiAtLSAKPiAyLjE1 LjEKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK