From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric@anholt.net (Eric Anholt) Date: Thu, 31 Aug 2017 10:58:44 -0700 Subject: [PATCH 7/7] drm/pl111: Add handling of Versatile platforms In-Reply-To: <20170830180711.2791-8-linus.walleij@linaro.org> References: <20170830180711.2791-1-linus.walleij@linaro.org> <20170830180711.2791-8-linus.walleij@linaro.org> Message-ID: <878thzzkiz.fsf@anholt.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Linus Walleij writes: > The ARM reference designs in the Versatile family: Integrator, > Versatile and RealView can make use of the new DRM driver as well. > We just need to create a bit of platform-specific code for them > that we isolate to its own file. > > Signed-off-by: Linus Walleij > --- > drivers/gpu/drm/pl111/Makefile | 1 + > drivers/gpu/drm/pl111/pl111_display.c | 7 - > drivers/gpu/drm/pl111/pl111_drv.c | 5 + > drivers/gpu/drm/pl111/pl111_versatile.c | 270 ++++++++++++++++++++++++++++++++ > drivers/gpu/drm/pl111/pl111_versatile.h | 9 ++ > 5 files changed, 285 insertions(+), 7 deletions(-) > create mode 100644 drivers/gpu/drm/pl111/pl111_versatile.c > create mode 100644 drivers/gpu/drm/pl111/pl111_versatile.h > > diff --git a/drivers/gpu/drm/pl111/Makefile b/drivers/gpu/drm/pl111/Makefile > index c5f8f9684848..fce1453a93e1 100644 > --- a/drivers/gpu/drm/pl111/Makefile > +++ b/drivers/gpu/drm/pl111/Makefile > @@ -1,4 +1,5 @@ > pl111_drm-y += pl111_display.o \ > + pl111_versatile.o \ > pl111_drv.o > > pl111_drm-$(CONFIG_DEBUG_FS) += pl111_debugfs.o > diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c > index 37f409867934..f7b043f4fed6 100644 > --- a/drivers/gpu/drm/pl111/pl111_display.c > +++ b/drivers/gpu/drm/pl111/pl111_display.c > @@ -454,13 +454,6 @@ int pl111_display_init(struct drm_device *drm) > } > of_node_put(endpoint); > > - if (tft_r0b0g0[0] != 0 || > - tft_r0b0g0[1] != 8 || > - tft_r0b0g0[2] != 16) { > - dev_err(dev, "arm,pl11x,tft-r0g0b0-pads != [0,8,16] not yet supported\n"); > - return -EINVAL; > - } I had a note in the DOC section of pl111_drv.c about needing to filter available formats based on this property. Could you update that with some explanation of the new state of things? (Do we actually need to filter the formats?) I haven't verified that we get the same pin routing setup as the fbdev driver did for these platforms, but even if they don't match yet this seems like an excellent start and we can make sure we sort them out as we add panel drivers. I've verified that my Cygnus board continues working with your series. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 832 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 7/7] drm/pl111: Add handling of Versatile platforms Date: Thu, 31 Aug 2017 10:58:44 -0700 Message-ID: <878thzzkiz.fsf@anholt.net> References: <20170830180711.2791-1-linus.walleij@linaro.org> <20170830180711.2791-8-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1246290783==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A8746E751 for ; Thu, 31 Aug 2017 18:04:58 +0000 (UTC) In-Reply-To: <20170830180711.2791-8-linus.walleij@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij , Daniel Vetter , Jani Nikula , Sean Paul Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1246290783== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Linus Walleij writes: > The ARM reference designs in the Versatile family: Integrator, > Versatile and RealView can make use of the new DRM driver as well. > We just need to create a bit of platform-specific code for them > that we isolate to its own file. > > Signed-off-by: Linus Walleij > --- > drivers/gpu/drm/pl111/Makefile | 1 + > drivers/gpu/drm/pl111/pl111_display.c | 7 - > drivers/gpu/drm/pl111/pl111_drv.c | 5 + > drivers/gpu/drm/pl111/pl111_versatile.c | 270 ++++++++++++++++++++++++++= ++++++ > drivers/gpu/drm/pl111/pl111_versatile.h | 9 ++ > 5 files changed, 285 insertions(+), 7 deletions(-) > create mode 100644 drivers/gpu/drm/pl111/pl111_versatile.c > create mode 100644 drivers/gpu/drm/pl111/pl111_versatile.h > > diff --git a/drivers/gpu/drm/pl111/Makefile b/drivers/gpu/drm/pl111/Makef= ile > index c5f8f9684848..fce1453a93e1 100644 > --- a/drivers/gpu/drm/pl111/Makefile > +++ b/drivers/gpu/drm/pl111/Makefile > @@ -1,4 +1,5 @@ > pl111_drm-y +=3D pl111_display.o \ > + pl111_versatile.o \ > pl111_drv.o >=20=20 > pl111_drm-$(CONFIG_DEBUG_FS) +=3D pl111_debugfs.o > diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl11= 1/pl111_display.c > index 37f409867934..f7b043f4fed6 100644 > --- a/drivers/gpu/drm/pl111/pl111_display.c > +++ b/drivers/gpu/drm/pl111/pl111_display.c > @@ -454,13 +454,6 @@ int pl111_display_init(struct drm_device *drm) > } > of_node_put(endpoint); >=20=20 > - if (tft_r0b0g0[0] !=3D 0 || > - tft_r0b0g0[1] !=3D 8 || > - tft_r0b0g0[2] !=3D 16) { > - dev_err(dev, "arm,pl11x,tft-r0g0b0-pads !=3D [0,8,16] not yet supporte= d\n"); > - return -EINVAL; > - } I had a note in the DOC section of pl111_drv.c about needing to filter available formats based on this property. Could you update that with some explanation of the new state of things? (Do we actually need to filter the formats?) I haven't verified that we get the same pin routing setup as the fbdev driver did for these platforms, but even if they don't match yet this seems like an excellent start and we can make sure we sort them out as we add panel drivers. I've verified that my Cygnus board continues working with your series. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlmoTlQACgkQtdYpNtH8 nujQjA/9HYBftgl8Qznr4uIQjT0xE79Vd0O2lsOZaapa72TqfCGc8Hn7nQUDepmk RmUdb2/9VvzDnVjMvLODRnywWmzGtM62EF1XMVWpW2HY39S0N/ne664rkUg7peDt q+aatQyrYeSDs3/2x/DuFJGxWJk1XXUxrYcDbuZ9IcWO4l9Bi7IutOld8fllL2RS K31oZKo3gcghRhVP60bWfnVa7y8oRjJVEYh/pz+/n8hkq1tzwsEXzgZ1ozAkclJ9 Wbt8xmE2YzQ/ie8Wl1hWVctLAoGKQhoKnDX07LhlSxVDHo3Koe2EusNvfhTw+A52 ziGN/eB3maO22FkC0aeTYA1aWhIQFM0O5ptIrjx7P5TIkMc7J3nIYjg2O2roi2u6 rcDdLNP52LpANBtnoEDAEyzGJLtdpYWf1+COdcD4HlLo/1qyqs/qiQH53ul2dJnh sdrHe71h79kKq39bT3b4qDBUWILxPg2MX2PxBEZNbsBlnctX46uCsQ2Tn247ZieZ x57+0dtaC4ZkLrlWRQ2ICcoB9emTUr/MpZgW4+JA5oJkXZpo6utWrDIfDgaWaGFL JpHyR3aAwZmsF8UJPShGLV/jw/cNCshvx0g3rCboCqAkvyjQbw7tz10kfptQq0AU HQUsl3cbPN2EhM8S1OozDbyEMu43F4qsqwrPe8DczyqXi7HVEx8= =ZGEF -----END PGP SIGNATURE----- --=-=-=-- --===============1246290783== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1246290783==--