From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org,
Avraham Stern <avraham.stern@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [PATCH 2/3] iwlwifi: mvm: start mac queues when deferred tx frames are purged
Date: Mon, 07 Aug 2017 15:58:27 +0300 [thread overview]
Message-ID: <878tivleks.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170805184743.23650-3-luca@coelho.fi> (Luca Coelho's message of "Sat, 5 Aug 2017 21:47:42 +0300")
Luca Coelho <luca@coelho.fi> writes:
> From: Avraham Stern <avraham.stern@intel.com>
>
> Under DQA, when tx is deferred because a queue needs to be allocated,
> the mac queue for that TID is stopped until the new stream is added.
> If at this point the station that this stream belongs to is removed,
> all the deferred tx frames are purged, but the mac queue is not
> restarted. As a result, all following tx on this queue will not be
> transmitted.
>
> Fix this by starting the relevant mac queues when the deferred tx
> frames are purged.
>
> Fixes: 24afba7690e4 ("iwlwifi: mvm: support bss dynamic alloc/dealloc of queues")
> Signed-off-by: Avraham Stern <avraham.stern@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
The commit log is not really explaining the bug from user's point of
view.
--
Kalle Valo
next prev parent reply other threads:[~2017-08-07 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-05 18:47 [PATCH 0/3] iwlwifi: fixes intended for 4.13 2017-08-05 Luca Coelho
2017-08-05 18:47 ` [PATCH 1/3] iwlwifi: mvm: Fix a memory leak in an error handling path in 'iwl_mvm_sar_get_wgds_table()' Luca Coelho
2017-08-07 12:57 ` Kalle Valo
2017-08-07 13:11 ` Luca Coelho
2017-08-07 13:37 ` Kalle Valo
2017-08-07 13:47 ` Luca Coelho
2017-08-05 18:47 ` [PATCH 2/3] iwlwifi: mvm: start mac queues when deferred tx frames are purged Luca Coelho
2017-08-07 12:58 ` Kalle Valo [this message]
2017-08-05 18:47 ` [PATCH 3/3] iwlwifi: mvm: don't WARN when a legit race happens in A-MPDU Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tivleks.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=avraham.stern@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.