From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1dXSvL-0002FG-1M for mharc-qemu-trivial@gnu.org; Tue, 18 Jul 2017 09:52:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXSvI-0002Dr-OG for qemu-trivial@nongnu.org; Tue, 18 Jul 2017 09:52:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXSvE-0006BG-OG for qemu-trivial@nongnu.org; Tue, 18 Jul 2017 09:52:24 -0400 Received: from mail-wr0-x22e.google.com ([2a00:1450:400c:c0c::22e]:36675) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXSvE-00069G-Fi for qemu-trivial@nongnu.org; Tue, 18 Jul 2017 09:52:20 -0400 Received: by mail-wr0-x22e.google.com with SMTP id y43so30418724wrd.3 for ; Tue, 18 Jul 2017 06:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=3Eh65VlCQQc5FqMu8YwVDmWBvGmp/cHSzV3KX4kJFko=; b=AODEjW3R3vJhLDIx02G3LBs57X0h1n3H1iJRY8NQguJ2PvjAWDg0o9re6zFqjI2YNI wfmDcRcT/OZuWX6lVoQcu7tVNJBNx4Mx9foGEZsa0b8o0OJe1G6Z+T6k6K/RAhD1pAjj CeVYWACSa4sB3zHoV8ui4QE07g82xZow2wPdw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=3Eh65VlCQQc5FqMu8YwVDmWBvGmp/cHSzV3KX4kJFko=; b=m4gYKoYTACe+cpVI0iTLGUlDHLTvVBKSvVsdsHY/H+9Ao5zn+Ypcof5jGQ36skIJT6 hHOvZ1wb/FxHUosNihiJjyzsbczRInpj+zGJTV14bKWm5qUh96vCFV+/Vzq2J7O/h48X YQfR6V32sFaBYU65gMujwLNYbGps9WZB26xTXnX2Zdb0kVwkPSTNeCt+QgCl8t3Yb5aF 1CWulaL8LhABZR+7JCtIvRNO3FhO+mkUUKpp09aEIfIR6hLy9NQDq9z/Zw1FQcRpx6qU kN0LOniuGFhLDPpM8nWx2yYCxZfRz2Sdfehn46TKYNjwyHQsPhPmVmJa1FcbJ+Zi94Tx U5sQ== X-Gm-Message-State: AIVw113DipS7+YMWnHMQsSUsT4mWqZhLv9l0aUNWyqZg5kkYNl/HZskD Ypn2imGvmWSDoaMS X-Received: by 10.223.177.26 with SMTP id l26mr1255297wra.65.1500385939095; Tue, 18 Jul 2017 06:52:19 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 94sm3248690wrb.55.2017.07.18.06.52.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jul 2017 06:52:17 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTPS id EA76A3E0128; Tue, 18 Jul 2017 14:52:16 +0100 (BST) References: <20170718061005.29518-1-f4bug@amsat.org> <20170718061005.29518-27-f4bug@amsat.org> <87bmoi806u.fsf@linaro.org> User-agent: mu4e 0.9.19; emacs 25.2.50.3 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu trival , QEMU , Richard Henderson In-reply-to: Date: Tue, 18 Jul 2017 14:52:16 +0100 Message-ID: <878tjl97jj.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22e Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 26/29] tests/tcg: use ARRAY_SIZE macro X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 13:52:26 -0000 Marc-André Lureau writes: > Hi > > On Tue, Jul 18, 2017 at 4:16 AM, Alex Bennée wrote: >> >> Marc-André Lureau writes: >> >>> Hi >>> >>> On Mon, Jul 17, 2017 at 11:10 PM, Philippe Mathieu-Daudé >>> wrote: >>>> Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci >>>> >>>> Signed-off-by: Philippe Mathieu-Daudé >>>> --- >>>> tests/tcg/alpha/test-cond.c | 2 +- >>>> tests/tcg/alpha/test-ovf.c | 2 +- >>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>> >>> >>> I think those do not include osdep.h >>> >>> (sigh, tests/tcg would need some love ;) >> >> Pranith has had a couple of revs at this: >> >> Subject: [PATCH v5 00/19] Cleanup of TCG tests >> Date: Thu, 1 Dec 2016 00:14:14 -0500 >> Message-Id: <20161201051433.17168-1-bobby.prani@gmail.com> >> >> We have the cross-compilers available as a fallback via docker although >> not every one can seamlessly use it for building stuff. Is getting a >> working cross-compiler setup too much of a hurdle fore those that want >> to build cross-arch tests? > > Yes, I also did some experiments in cleaning up tests/tcg > (https://github.com/elmarco/qemu/tree/tcg-tests) > > The trouble is I don't see an official/automated way to run tests/tcg > tests. Which cross-compiler should I use? When I played with this, > they all had various quirks, on Fedora, Debian or crosstool-ng. Debian at least have put a lot of work into getting cross-compilers installed as part of the native distro with good multi-arch support. We now use plain Debian 9 for most of the QEMU cross compiles - a few older architectures still need Debian 8 with the emdebian overlay. > I haven't looked at the docker tests, is this running tests/tcg test > somehow? No but as tests/tcg are all pretty simple and have less cross-compile dependencies than QEMU itself it is fairly trivial to invoke docker to do a cross-build for you in-place. e.g.: docker run --rm -t -u (id -u) -v (pwd):(pwd) -w (pwd) qemu:debian-armhf-cross arm-linux-gnueabihf-gcc tests/tcg/hello-arm.c This is perhaps a bad example as there is a bit-rot that needs fixing. The alternative is to mine the users PATH for fairly standard cross-compile prefixes which work at least on Debian systems. I recently submitted a patch to RISU that allowed you to use either in its build-all-arches script: https://git.linaro.org/people/peter.maydell/risu.git/tree/build-all-archs -- Alex Bennée From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXSvI-0002Dp-Mw for qemu-devel@nongnu.org; Tue, 18 Jul 2017 09:52:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXSvE-0006B9-O7 for qemu-devel@nongnu.org; Tue, 18 Jul 2017 09:52:24 -0400 Received: from mail-wr0-x233.google.com ([2a00:1450:400c:c0c::233]:35499) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXSvE-00069F-Hx for qemu-devel@nongnu.org; Tue, 18 Jul 2017 09:52:20 -0400 Received: by mail-wr0-x233.google.com with SMTP id w4so29786517wrb.2 for ; Tue, 18 Jul 2017 06:52:20 -0700 (PDT) References: <20170718061005.29518-1-f4bug@amsat.org> <20170718061005.29518-27-f4bug@amsat.org> <87bmoi806u.fsf@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Tue, 18 Jul 2017 14:52:16 +0100 Message-ID: <878tjl97jj.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 26/29] tests/tcg: use ARRAY_SIZE macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu trival , QEMU , Richard Henderson Marc-André Lureau writes: > Hi > > On Tue, Jul 18, 2017 at 4:16 AM, Alex Bennée wrote: >> >> Marc-André Lureau writes: >> >>> Hi >>> >>> On Mon, Jul 17, 2017 at 11:10 PM, Philippe Mathieu-Daudé >>> wrote: >>>> Applied using the Coccinelle semantic patch scripts/coccinelle/use_osdep.cocci >>>> >>>> Signed-off-by: Philippe Mathieu-Daudé >>>> --- >>>> tests/tcg/alpha/test-cond.c | 2 +- >>>> tests/tcg/alpha/test-ovf.c | 2 +- >>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>> >>> >>> I think those do not include osdep.h >>> >>> (sigh, tests/tcg would need some love ;) >> >> Pranith has had a couple of revs at this: >> >> Subject: [PATCH v5 00/19] Cleanup of TCG tests >> Date: Thu, 1 Dec 2016 00:14:14 -0500 >> Message-Id: <20161201051433.17168-1-bobby.prani@gmail.com> >> >> We have the cross-compilers available as a fallback via docker although >> not every one can seamlessly use it for building stuff. Is getting a >> working cross-compiler setup too much of a hurdle fore those that want >> to build cross-arch tests? > > Yes, I also did some experiments in cleaning up tests/tcg > (https://github.com/elmarco/qemu/tree/tcg-tests) > > The trouble is I don't see an official/automated way to run tests/tcg > tests. Which cross-compiler should I use? When I played with this, > they all had various quirks, on Fedora, Debian or crosstool-ng. Debian at least have put a lot of work into getting cross-compilers installed as part of the native distro with good multi-arch support. We now use plain Debian 9 for most of the QEMU cross compiles - a few older architectures still need Debian 8 with the emdebian overlay. > I haven't looked at the docker tests, is this running tests/tcg test > somehow? No but as tests/tcg are all pretty simple and have less cross-compile dependencies than QEMU itself it is fairly trivial to invoke docker to do a cross-build for you in-place. e.g.: docker run --rm -t -u (id -u) -v (pwd):(pwd) -w (pwd) qemu:debian-armhf-cross arm-linux-gnueabihf-gcc tests/tcg/hello-arm.c This is perhaps a bad example as there is a bit-rot that needs fixing. The alternative is to mine the users PATH for fairly standard cross-compile prefixes which work at least on Debian systems. I recently submitted a patch to RISU that allowed you to use either in its build-all-arches script: https://git.linaro.org/people/peter.maydell/risu.git/tree/build-all-archs -- Alex Bennée