From: Jani Nikula <jani.nikula@linux.intel.com>
To: David Binderman <dcb314@hotmail.com>,
"daniel.vetter@intel.com" <daniel.vetter@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: mahesh1.kumar@intel.com
Subject: Re: drivers/gpu/drm/i915/intel_pm.c:4467: bad comparison ?
Date: Mon, 17 Jul 2017 12:52:21 +0300 [thread overview]
Message-ID: <878tjnjsq2.fsf@nikula.org> (raw)
In-Reply-To: <AM4PR08MB11565D68B8ADDAC7A76C46FB9CA00@AM4PR08MB1156.eurprd08.prod.outlook.com>
On Mon, 17 Jul 2017, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
Hello. No need to include LKML for stuff like this. But Cc'd the folks
from the broken commit.
> drivers/gpu/drm/i915/intel_pm.c:4467]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.
>
> Source code is
>
> else if ((ddb_allocation && ddb_allocation /
> fixed_16_16_to_u32_round_up(plane_blocks_per_line)) >= 1)
Broken by
commit d555cb5827d603244969e08444340e3db78c8a37
Author: Kumar, Mahesh <mahesh1.kumar@intel.com>
Date: Wed May 17 17:28:29 2017 +0530
drm/i915/skl+: use linetime latency if ddb size is not available
The broken code has since been removed by bb9d85f6e9de ("drm/i915/skl:
New ddb allocation algorithm") but restored by 9a30a26122c3 ("Revert
"drm/i915/skl: New ddb allocation algorithm""). *sigh*.
Mahesh et al, please figure it out.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-07-17 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 7:46 drivers/gpu/drm/i915/intel_pm.c:4467: bad comparison ? David Binderman
2017-07-17 9:52 ` Jani Nikula [this message]
2017-07-17 10:32 ` Mahesh Kumar
2017-07-17 10:31 ` Maarten Lankhorst
2017-07-17 10:40 ` Mahesh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tjnjsq2.fsf@nikula.org \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@intel.com \
--cc=dcb314@hotmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mahesh1.kumar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.