From: Juan Quintela <quintela@redhat.com>
To: Felipe Franciosi <felipe@nutanix.com>
Cc: Peter Xu <peterx@redhat.com>,
"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
amit Shah <amit.shah@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Malcolm Crossley <malcolm@nutanix.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 3/4] migration: set bytes_xfer_* outside of autoconverge logic
Date: Tue, 30 May 2017 18:14:58 +0200 [thread overview]
Message-ID: <878tlee2yl.fsf@secure.mitica> (raw)
In-Reply-To: <1495642203-12702-4-git-send-email-felipe@nutanix.com> (Felipe Franciosi's message of "Wed, 24 May 2017 17:10:02 +0100")
Felipe Franciosi <felipe@nutanix.com> wrote:
> The bytes_xfer_now/prev counters are only used by the auto convergence
> logic. However, they are used alongside the dirty_pages_rate counter,
> which is calculated (and required) outside of this logic. The problem
> with this approach is that if the auto convergence capability is changed
> while a migration is ongoing, the relationship of the counters will be
> broken.
>
> This moves the management of bytes_xfer_now/prev counters outside of the
> auto convergence logic to address this issue.
>
> Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2017-05-30 16:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 16:09 [Qemu-devel] [PATCH 0/4] migration: autoconverge counter fixes Felipe Franciosi
2017-05-24 16:10 ` [Qemu-devel] [PATCH 1/4] migration: keep bytes_xfer_prev init'd to zero Felipe Franciosi
2017-05-25 0:50 ` Peter Xu
2017-05-30 16:14 ` Juan Quintela
2017-05-24 16:10 ` [Qemu-devel] [PATCH 2/4] migration: set dirty_pages_rate before autoconverge logic Felipe Franciosi
2017-05-25 0:40 ` Peter Xu
2017-05-25 10:52 ` Felipe Franciosi
2017-05-25 11:10 ` Peter Xu
2017-05-30 16:14 ` Juan Quintela
2017-05-24 16:10 ` [Qemu-devel] [PATCH 3/4] migration: set bytes_xfer_* outside of " Felipe Franciosi
2017-05-25 0:40 ` Peter Xu
2017-05-30 16:14 ` Juan Quintela [this message]
2017-05-24 16:10 ` [Qemu-devel] [PATCH 4/4] migration: use dirty_rate_high_cnt more aggressively Felipe Franciosi
2017-05-24 16:25 ` Daniel P. Berrange
2017-05-24 16:36 ` Felipe Franciosi
2017-05-25 1:03 ` Peter Xu
2017-05-25 11:20 ` Felipe Franciosi
2017-05-26 2:45 ` Peter Xu
2017-05-30 16:17 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tlee2yl.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=felipe@nutanix.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=malcolm@nutanix.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.