All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karl Tomlinson <bugs+kernel@karlt.net>
To: linux-bcache@vger.kernel.org
Subject: Re: hang during suspend to RAM when bcache cache device is attached
Date: Fri, 19 May 2017 14:12:28 +1200	[thread overview]
Message-ID: <878tltr3w3.fsf@karlt.net> (raw)
In-Reply-To: <alpine.LRH.2.11.1705181701520.19359@mail.ewheeler.net> (Eric Wheeler's message of "Thu, 18 May 2017 17:03:33 +0000 (UTC)")

Eric Wheeler writes:

> Try the patch below, this is the only deadlock fix that isn't upstream 
> that I'm aware of.  Your trace above doesn't indicate any bcache 
> functions, so this could be hard to troubleshoot.

Thanks for the suggestion, but I think I've found the real cause.

I wasn't able to reproduce with 4.11.1, which I suspect is due to
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/drivers/nvme/host/core.c?h=v4.11.1&id=302ad8cc09339ea261eef58a8d5f4a116a8ffda5
which fixes an issue that matches the symptoms I've seen.

The history of that change is
http://lists.infradead.org/pipermail/linux-nvme/2017-March/008593.html
https://patchwork.kernel.org/patch/9589187/
http://lists.infradead.org/pipermail/linux-nvme/2017-January/007617.html

FWIW I was not able to reproduce with a filesystem directly on an
nvme partition, but I guess stacked devices or bcache changed
things enough to trigger.

      reply	other threads:[~2017-05-19  2:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17  7:01 hang during suspend to RAM when bcache cache device is attached Karl Tomlinson
2017-05-17 21:50 ` Karl Tomlinson
2017-05-18 17:03   ` Eric Wheeler
2017-05-19  2:12     ` Karl Tomlinson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tltr3w3.fsf@karlt.net \
    --to=bugs+kernel@karlt.net \
    --cc=linux-bcache@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.