From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dABeD-0002UG-7V for qemu-devel@nongnu.org; Mon, 15 May 2017 04:46:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dABe9-00045h-0E for qemu-devel@nongnu.org; Mon, 15 May 2017 04:46:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35172) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dABe8-00045T-Qm for qemu-devel@nongnu.org; Mon, 15 May 2017 04:46:28 -0400 From: Markus Armbruster References: <20170503203604.31462-1-ehabkost@redhat.com> <20170503203604.31462-4-ehabkost@redhat.com> Date: Mon, 15 May 2017 10:46:22 +0200 In-Reply-To: <20170503203604.31462-4-ehabkost@redhat.com> (Eduardo Habkost's message of "Wed, 3 May 2017 17:35:46 -0300") Message-ID: <878tly33tt.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RESEND v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Juergen Gross , Peter Maydell , Thomas Huth , sstabellini@kernel.org, Alexander Graf , Marcel Apfelbaum , Laszlo Ersek Stefano Stabellini , Anthony Perard , xen-devel@lists.xenproject.org Stefano or Anthony, please review. Eduardo Habkost writes: > xen-backend can be plugged/unplugged dynamically when using the > Xen accelerator, so keep the user_creatable flag on the device > class and remove the FIXME comment. > > Cc: Juergen Gross , > Cc: Peter Maydell , > Cc: Thomas Huth > Cc: sstabellini@kernel.org > Cc: Markus Armbruster , > Cc: Marcel Apfelbaum , > Cc: Laszlo Ersek > Acked-by: Juergen Gross > Acked-by: Marcel Apfelbaum > Signed-off-by: Eduardo Habkost > --- > Changes series v1 -> v2: > * (New patch added to series) > --- > hw/xen/xen_backend.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c > index 67cb4cb9f0..2b91d2d458 100644 > --- a/hw/xen/xen_backend.c > +++ b/hw/xen/xen_backend.c > @@ -619,10 +619,7 @@ static void xendev_class_init(ObjectClass *klass, void *data) > > dc->props = xendev_properties; > set_bit(DEVICE_CATEGORY_MISC, dc->categories); > - /* > - * FIXME: Set only because we are not sure yet if this device > - * will be outside the q35 sysbus whitelist. > - */ > + /* xen-backend devices can be plugged/unplugged dynamically */ > dc->user_creatable = true; > } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH RESEND v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag Date: Mon, 15 May 2017 10:46:22 +0200 Message-ID: <878tly33tt.fsf@dusky.pond.sub.org> References: <20170503203604.31462-1-ehabkost@redhat.com> <20170503203604.31462-4-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dABeD-00051Z-PE for xen-devel@lists.xenproject.org; Mon, 15 May 2017 08:46:33 +0000 In-Reply-To: <20170503203604.31462-4-ehabkost@redhat.com> (Eduardo Habkost's message of "Wed, 3 May 2017 17:35:46 -0300") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Eduardo Habkost Cc: Juergen Gross , Peter Maydell , Thomas Huth , Stefano Stabellini , qemu-devel@nongnu.org, Alexander Graf , Anthony Perard , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Laszlo Ersek List-Id: xen-devel@lists.xenproject.org U3RlZmFubyBvciBBbnRob255LCBwbGVhc2UgcmV2aWV3LgoKRWR1YXJkbyBIYWJrb3N0IDxlaGFi a29zdEByZWRoYXQuY29tPiB3cml0ZXM6Cgo+IHhlbi1iYWNrZW5kIGNhbiBiZSBwbHVnZ2VkL3Vu cGx1Z2dlZCBkeW5hbWljYWxseSB3aGVuIHVzaW5nIHRoZQo+IFhlbiBhY2NlbGVyYXRvciwgc28g a2VlcCB0aGUgdXNlcl9jcmVhdGFibGUgZmxhZyBvbiB0aGUgZGV2aWNlCj4gY2xhc3MgYW5kIHJl bW92ZSB0aGUgRklYTUUgY29tbWVudC4KPgo+IENjOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3Vz ZS5jb20+LAo+IENjOiBQZXRlciBNYXlkZWxsIDxwZXRlci5tYXlkZWxsQGxpbmFyby5vcmc+LAo+ IENjOiBUaG9tYXMgSHV0aCA8dGh1dGhAcmVkaGF0LmNvbT4KPiBDYzogc3N0YWJlbGxpbmlAa2Vy bmVsLm9yZwo+IENjOiBNYXJrdXMgQXJtYnJ1c3RlciA8YXJtYnJ1QHJlZGhhdC5jb20+LAo+IENj OiBNYXJjZWwgQXBmZWxiYXVtIDxtYXJjZWxAcmVkaGF0LmNvbT4sCj4gQ2M6IExhc3psbyBFcnNl ayA8bGVyc2VrQHJlZGhhdC5jb20+Cj4gQWNrZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0Bz dXNlLmNvbT4KPiBBY2tlZC1ieTogTWFyY2VsIEFwZmVsYmF1bSA8bWFyY2VsQHJlZGhhdC5jb20+ Cj4gU2lnbmVkLW9mZi1ieTogRWR1YXJkbyBIYWJrb3N0IDxlaGFia29zdEByZWRoYXQuY29tPgo+ IC0tLQo+IENoYW5nZXMgc2VyaWVzIHYxIC0+IHYyOgo+ICogKE5ldyBwYXRjaCBhZGRlZCB0byBz ZXJpZXMpCj4gLS0tCj4gIGh3L3hlbi94ZW5fYmFja2VuZC5jIHwgNSArLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv aHcveGVuL3hlbl9iYWNrZW5kLmMgYi9ody94ZW4veGVuX2JhY2tlbmQuYwo+IGluZGV4IDY3Y2I0 Y2I5ZjAuLjJiOTFkMmQ0NTggMTAwNjQ0Cj4gLS0tIGEvaHcveGVuL3hlbl9iYWNrZW5kLmMKPiAr KysgYi9ody94ZW4veGVuX2JhY2tlbmQuYwo+IEBAIC02MTksMTAgKzYxOSw3IEBAIHN0YXRpYyB2 b2lkIHhlbmRldl9jbGFzc19pbml0KE9iamVjdENsYXNzICprbGFzcywgdm9pZCAqZGF0YSkKPiAg Cj4gICAgICBkYy0+cHJvcHMgPSB4ZW5kZXZfcHJvcGVydGllczsKPiAgICAgIHNldF9iaXQoREVW SUNFX0NBVEVHT1JZX01JU0MsIGRjLT5jYXRlZ29yaWVzKTsKPiAtICAgIC8qCj4gLSAgICAgKiBG SVhNRTogU2V0IG9ubHkgYmVjYXVzZSB3ZSBhcmUgbm90IHN1cmUgeWV0IGlmIHRoaXMgZGV2aWNl Cj4gLSAgICAgKiB3aWxsIGJlIG91dHNpZGUgdGhlIHEzNSBzeXNidXMgd2hpdGVsaXN0Lgo+IC0g ICAgICovCj4gKyAgICAvKiB4ZW4tYmFja2VuZCBkZXZpY2VzIGNhbiBiZSBwbHVnZ2VkL3VucGx1 Z2dlZCBkeW5hbWljYWxseSAqLwo+ICAgICAgZGMtPnVzZXJfY3JlYXRhYmxlID0gdHJ1ZTsKPiAg fQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhl bi5vcmcveGVuLWRldmVsCg==