From: Markus Armbruster <armbru@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting
Date: Mon, 24 Apr 2017 09:20:06 +0200 [thread overview]
Message-ID: <878tmqqnkp.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170421122710.15373-1-famz@redhat.com> (Fam Zheng's message of "Fri, 21 Apr 2017 20:26:56 +0800")
Fam Zheng <famz@redhat.com> writes:
> These are patches to:
>
> 1) reorder the function parameters so that Error **errp comes
> last.
>
> Error pointer in the middle of a function parameter list is very uncommon, and
> does caused mistakes, thus is not a good style. Change to the usual way.
>
> 2) apply the error_propagate_null.cocci semantics patch again.
Applied with the commit message typo found by Eric corrected. Thanks!
prev parent reply other threads:[~2017-04-24 7:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 12:26 [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting Fam Zheng
2017-04-21 12:26 ` [Qemu-devel] [PATCH 01/14] socket: Make errp the last parameter of socket_connect Fam Zheng
2017-04-21 12:26 ` [Qemu-devel] [PATCH 02/14] socket: Make errp the last parameter of inet_connect_saddr Fam Zheng
2017-04-21 12:26 ` [Qemu-devel] [PATCH 03/14] socket: Make errp the last parameter of unix_connect_saddr Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 04/14] socket: Make errp the last parameter of vsock_connect_saddr Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 05/14] block: Make errp the last parameter of bdrv_img_create Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 06/14] crypto: Make errp the last parameter of functions Fam Zheng
2017-04-21 14:35 ` Eric Blake
2017-04-24 8:28 ` Daniel P. Berrange
2017-04-24 8:43 ` Fam Zheng
2017-04-24 9:24 ` Markus Armbruster
2017-04-24 9:27 ` Daniel P. Berrange
2017-04-21 12:27 ` [Qemu-devel] [PATCH 07/14] mirror: Make errp the last parameter of mirror_start_job Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 08/14] block: Make errp the last parameter of commit_active_start Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 09/14] nfs: Make errp the last parameter of nfs_client_open Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 10/14] fdc: Make errp the last parameter of fdctrl_connect_drives Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 11/14] scsi: Make errp the last parameter of virtio_scsi_common_realize Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 12/14] migration: Make errp the last parameter of local functions Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 13/14] qga: Make errp the last parameter of qga_vss_fsfreeze Fam Zheng
2017-04-21 12:27 ` [Qemu-devel] [PATCH 14/14] error: Apply error_propagate_null.cocci again Fam Zheng
2017-04-21 14:45 ` [Qemu-devel] [PATCH 00/14] Trivial cleanups around error reporting Eric Blake
2017-04-21 14:57 ` Markus Armbruster
2017-04-24 7:20 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tmqqnkp.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.