Re: [Qemu-devel] [RFC v2 for-2.9 09/10] squash! nbd: Tidy up blockdev-add interface

[Markus Armbruster <armbru@redhat.com>]

Eric Blake <eblake@redhat.com> writes:

> On 03/30/2017 08:15 AM, Markus Armbruster wrote:
>> Drop backward -drive server.data.* compatibility gunk.  On squash,
>> replace commit message's last paragraph "Unfortunately, SocketAddress
>> is also visible..." by:
>
> Maybe I should glance at the whole thread before reviewing without
> realizing what is coming later ;)

Maybe I should point out such stunts in my cover letters :)

>> Unfortunately, SocketAddress is also visible in -drive since 2.8:
>> 
>>     -drive if=none,driver=nbd,server.type=inet,server.data.host=127.0.0.1,server.data.port=12345
>> 
>> Nobody should be using it, as it's fairly new and has never been
>> documented, so adding still more compatibility gunk to keep it working
>> isn't worth the trouble.  You now have to use
>> 
>>     -drive if=none,driver=nbd,server.type=inet,server.host=127.0.0.1,server.port=12345
>
> As pointed out on 8/10, it might be worth documenting that while legacy
> 'port' is optional, the new 'server.port' is mandatory.

The combined commit message doesn't mention the "bare" legacy syntax.
I'd have to explain it first.  I'm afraid it would be a distraction.
server.port is mandatory elsewhere, too.

>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  block/nbd.c | 41 +----------------------------------------
>>  1 file changed, 1 insertion(+), 40 deletions(-)
>> 
>
> When squashed with 8/10, it does make that patch more palatable (all the
> concerns I expressed there were ripped out here).  So if no one else has
> a strong argument for keeping 'server.data.*' back-compat, then the
> squash of 8+9 together can have:
>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!