Re: [PATCH] Revert "bcma: init serial console directly from ChipCommon code"

[Kalle Valo <kvalo@codeaurora.org>]

Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> writes:

> On 13 January 2017 at 11:16, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> writes:
>>
>>> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>>>
>>> This reverts commit 4c81acab3816 ("bcma: init serial console directly
>>> from ChipCommon code") as it broke IRQ assignment. Getting IRQ with
>>> bcma_core_irq helper on SoC requires MIPS core to be set. It happens
>>> *after* ChipCommon initialization so we can't do this so early.
>>>
>>> This fixes a regression but it seems noone noticed it for about a year.
>>> It could be it was because serial was still somehow working, just
>>> without IRQs. It doesn't look like a critical patch / fix.
>>>
>>> Reported-by: Felix Fietkau <nbd@nbd.name>
>>> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>>
>> So this is for 4.11? What about CC stable?
>>
>> I'll add a Fixes line:
>>
>> Fixes: 4c81acab3816 ("bcma: init serial console directly from ChipCommon=
 code")
>
> After hearing about policy for fixes getting more strict, I thought we
> can get it for next only.

As this is a user reported regression it would qualify for 4.10, but on
the other hand quite old regression so can easily wait for 4.11 as well.
Up to you really.

But I would like to add CC stable so that this gets backported to older
releases. Is that ok?

> Thanks for "Fixes:", I wasn't sure if we need that for reverts.

If you are fixing a regression it's always a good idea to add the Fixes
line. Makes it easier to backport the fix.

--=20
Kalle Valo