From: Andi Kleen <andi@firstfloor.org>
To: Borislav Petkov <bp@suse.de>
Cc: "Luck\, Tony" <tony.luck@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/mce: Include the PPIN in machine check records when it is available
Date: Fri, 18 Nov 2016 09:02:56 -0800 [thread overview]
Message-ID: <878tsg67r3.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <20161118130022.vcnodxrslg6khycc@pd.tnic> (Borislav Petkov's message of "Fri, 18 Nov 2016 14:00:22 +0100")
Borislav Petkov <bp@suse.de> writes:
>
>> @@ -2134,8 +2140,37 @@ static int __init mcheck_enable(char *str)
>> }
>> __setup("mce", mcheck_enable);
>>
>> +static void mcheck_intel_ppin_init(void)
>
> So this functionality could all be moved to arch/x86/kernel/cpu/intel.c
> where you could set an artificial X86_FEATURE_PPIN and get rid of the
> have_ppin var.
That means that a tiny kernel that compiles out machine check
functionality has this unnecessary code.
In general it doesn't make any sense to define a FEATURE flag for
a single user. It's better to just check it where it is needed.
-Andi
next prev parent reply other threads:[~2016-11-18 17:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 0:35 [PATCH 2/2] mcelog: Print the PPIN in machine check records when it is available Luck, Tony
2016-11-18 0:35 ` [PATCH 1/2] x86/mce: Include " Luck, Tony
2016-11-18 13:00 ` Borislav Petkov
2016-11-18 16:42 ` Luck, Tony
2016-11-18 17:02 ` Andi Kleen [this message]
2016-11-18 17:45 ` Borislav Petkov
2016-11-18 17:48 ` [PATCH v2] " Luck, Tony
2016-11-23 11:48 ` Borislav Petkov
2016-11-23 13:29 ` Henrique de Moraes Holschuh
2016-11-23 13:37 ` Borislav Petkov
2016-11-23 14:05 ` Borislav Petkov
2016-11-23 16:42 ` Tony Luck
2016-11-23 16:55 ` Borislav Petkov
2016-11-23 17:29 ` Henrique de Moraes Holschuh
2016-11-23 20:56 ` Tony Luck
2016-11-24 11:20 ` Henrique de Moraes Holschuh
2016-11-23 15:58 ` [tip:ras/core] x86/mce: Include the PPIN in MCE records when available tip-bot for Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tsg67r3.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor.org \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.