From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60030)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bz1uV-0007DC-7R
	for qemu-devel@nongnu.org; Tue, 25 Oct 2016 09:37:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bz1uR-0001ma-5f
	for qemu-devel@nongnu.org; Tue, 25 Oct 2016 09:36:59 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1475246744-29302-1-git-send-email-berrange@redhat.com>
	<1475246744-29302-6-git-send-email-berrange@redhat.com>
Date: Tue, 25 Oct 2016 15:36:43 +0200
In-Reply-To: <1475246744-29302-6-git-send-email-berrange@redhat.com> (Daniel
	P. Berrange's message of "Fri, 30 Sep 2016 15:45:28 +0100")
Message-ID: <878ttc1rf8.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v14 05/21] qapi: rename QmpOutputVisitor to
 QObjectOutputVisitor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

"Daniel P. Berrange" <berrange@redhat.com> writes:

> The QmpOutputVisitor has no direct dependency on QMP. It is
> valid to use it anywhere that one wants a QObject. Rename it
> to better reflect its functionality as a generic QAPI
> to QObject converter.
>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  block/qapi.c                                       |   4 +-
>  blockdev.c                                         |   4 +-
>  docs/qapi-code-gen.txt                             |   2 +-
>  ...p-output-visitor.h => qobject-output-visitor.h} |  10 +-
>  qapi/Makefile.objs                                 |   2 +-
>  qapi/qapi-clone-visitor.c                          |   2 +-
>  qapi/qmp-output-visitor.c                          | 256 ---------------------
>  qapi/qobject-output-visitor.c                      | 254 ++++++++++++++++++++
>  qemu-img.c                                         |   8 +-
>  qom/object_interfaces.c                            |   2 +-
>  qom/qom-qobject.c                                  |   4 +-
>  scripts/qapi-commands.py                           |   4 +-
>  scripts/qapi-event.py                              |   4 +-
>  tests/.gitignore                                   |   2 +-
>  tests/Makefile.include                             |   8 +-
>  tests/check-qnull.c                                |   4 +-
>  ...put-visitor.c => test-outqobject-output-visitor.c} |   6 +-
>  tests/test-string-output-visitor.c                 |   2 +-
>  tests/test-visitor-serialization.c                 |   4 +-
>  util/qemu-sockets.c                                |   2 +-
>  20 files changed, 291 insertions(+), 293 deletions(-)
>  rename include/qapi/{qmp-output-visitor.h => qobject-output-visitor.h} (66%)
>  delete mode 100644 qapi/qmp-output-visitor.c
>  create mode 100644 qapi/qobject-output-visitor.c
>  rename tests/{test-qmp-output-visitor.c => test-qobject-output-visitor.c} (99%)

Renaming the file and the identifiers at the same time defeats rename
detection, and thus git-log --follow.  Since this would be quite
annoying, I'm going to split this patch into one that renames files and
one that renames C identifiers.