From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, paolo.bonzini@gmail.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props
Date: Wed, 05 Oct 2016 09:47:42 +0200 [thread overview]
Message-ID: <878tu31bkx.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20160922203927.28241-2-marcandre.lureau@redhat.com> ("Marc-André Lureau"'s message of "Fri, 23 Sep 2016 00:39:25 +0400")
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> Since commit ad739706bbadee49, user_creatable_add_type() expects to be
> given a qdict. However, if object-add is called without props, you reach
> the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type:
> Assertion `qdict' failed.", because the qdict isn't created in this
> case (it's optional).
>
> Furthermore, qmp_input_visitor_new() is not meant to be called without a
> dict, and a further commit will assert in this situation.
>
> If none given, create an empty qdict in qmp to avoid the
> user_creatable_add_type() assert(qdict).
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2016-10-05 7:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 20:39 [Qemu-devel] [PATCH v4 0/3] Fix some qapi assert() Marc-André Lureau
2016-09-22 20:39 ` [Qemu-devel] [PATCH v4 1/3] qmp: fix object-add assert() without props Marc-André Lureau
2016-09-23 6:52 ` Xiao Long Jiang
2016-09-29 15:23 ` Markus Armbruster
2016-10-05 10:27 ` Christian Borntraeger
2016-10-10 6:49 ` Xiao Long Jiang
2016-10-05 7:47 ` Markus Armbruster [this message]
2016-09-22 20:39 ` [Qemu-devel] [PATCH v4 2/3] qapi: fix crash when a parameter is missing Marc-André Lureau
2016-09-29 15:42 ` Markus Armbruster
2016-10-05 8:18 ` Markus Armbruster
2016-10-05 8:34 ` Marc-André Lureau
2016-09-22 20:39 ` [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests Marc-André Lureau
2016-09-29 16:28 ` Markus Armbruster
2016-10-05 9:56 ` Markus Armbruster
2016-10-05 10:16 ` Marc-André Lureau
2016-10-05 12:35 ` Markus Armbruster
2016-10-05 13:02 ` Marc-André Lureau
2016-10-05 14:38 ` Markus Armbruster
2016-10-05 15:14 ` Marc-André Lureau
2016-10-06 13:26 ` Markus Armbruster
2016-10-07 18:15 ` Markus Armbruster
2016-10-10 8:24 ` Marc-André Lureau
2016-10-10 13:14 ` Markus Armbruster
2016-10-04 15:23 ` [Qemu-devel] [PATCH 2.5/3] tests/test-qmp-input-strict: Cover missing struct members Markus Armbruster
2016-10-04 16:34 ` no-reply
2016-10-06 13:26 ` [Qemu-devel] [PATCH v4 0/3] Fix some qapi assert() Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tu31bkx.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=paolo.bonzini@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.