All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, berto@igalia.com
Subject: Re: [Qemu-devel] [PATCH 3/3] iotests: fix expected error message
Date: Wed, 21 Sep 2016 17:14:56 +0200	[thread overview]
Message-ID: <878tulxp1r.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20160921103629.6410-4-marcandre.lureau@redhat.com> ("Marc-André Lureau"'s message of "Wed, 21 Sep 2016 14:36:29 +0400")

Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Missing argument returns a corresponding error message for all types
> now.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/qemu-iotests/087.out | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/087.out b/tests/qemu-iotests/087.out
> index a95c4b0..b213db2 100644
> --- a/tests/qemu-iotests/087.out
> +++ b/tests/qemu-iotests/087.out
> @@ -60,7 +60,7 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 encryption=on
>  Testing: -S
>  QMP_VERSION
>  {"return": {}}
> -{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'driver', expected: string"}}
> +{"error": {"class": "GenericError", "desc": "Parameter 'driver' is missing"}}
>  {"return": {}}
>  {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "SHUTDOWN"}

Did this regress in PATCH 1?

  parent reply	other threads:[~2016-09-21 15:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21 10:36 [Qemu-devel] [PATCH 0/3] qapi: return 'missing parameter' error Marc-André Lureau
2016-09-21 10:36 ` [Qemu-devel] [PATCH 1/3] qapi: return a " Marc-André Lureau
2016-09-21 12:57   ` Alberto Garcia
2016-09-21 14:33   ` Markus Armbruster
2016-09-21 15:05     ` Marc-André Lureau
2016-09-21 16:07     ` Marc-André Lureau
2016-09-22 11:02       ` Markus Armbruster
2016-09-21 10:36 ` [Qemu-devel] [PATCH 2/3] qapi: clear given pointer Marc-André Lureau
2016-09-21 12:57   ` Alberto Garcia
2016-09-21 14:41   ` Daniel P. Berrange
2016-09-21 15:17     ` Marc-André Lureau
2016-09-21 15:34       ` Daniel P. Berrange
2016-09-21 15:24   ` Markus Armbruster
2016-09-21 10:36 ` [Qemu-devel] [PATCH 3/3] iotests: fix expected error message Marc-André Lureau
2016-09-21 12:58   ` Alberto Garcia
2016-09-21 15:14   ` Markus Armbruster [this message]
2016-09-21 15:32     ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tulxp1r.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.