Re: [PATCH 1/2] usb: dwc3: drop FIFO resizing logic

[Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]


Hi,

Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org> writes:
>> Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org> writes:
>>> Hi Felipe,
>>>
>>> On Thursday 04 February 2016 05:48 PM, Felipe Balbi wrote:
>>>> That FIFO resizing logic was added to support OMAP5
>>>> ES1.0 which had a bogus default FIFO size. I can't
>>>> remember the exact size of default FIFO, but it was
>>>> less than one bulk superspeed packet (<1024) which
>>>> would prevent USB3 from ever working on OMAP5 ES1.0.
>>>>
>>>> However, OMAP5 ES1.0 support has been dropped by
>>>> commit aa2f4b16f830 ("ARM: OMAP5: id: Remove ES1.0
>>>> support") which renders FIFO resizing unnecessary.
>>>>
>>>> Signed-off-by: Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>>
>>> tested this series on both dra7-evm and dra72-evm using mass storage gadget and
>>> msc.sh
>> 
>> both HS and SS ?
>
> yes.. but the logs here were for only SS.

cool thanks. Did you notice any speed regression or is it all the same ?

>>> Let me know if you want me to do any other testing on dra7.
>> 
>> yeah, run testusb for a week or so, that usually catches odd bugs.
>
> Okay. I'll start the test before I go for vacation next week.

great

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]