From: Byongho Lee <bhlee.kernel@gmail.com>
To: Zhao Lei <zhaolei@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: fix memory leaks in error path
Date: Fri, 21 Aug 2015 14:32:18 +0900 [thread overview]
Message-ID: <878u95i4v1.fsf@gmail.com> (raw)
In-Reply-To: <013101d0dbc4$7e5ab090$7b1011b0$@cn.fujitsu.com>
Zhao Lei writes:
> Hi, Byongho Lee
>
>> -----Original Message-----
>> From: linux-btrfs-owner@vger.kernel.org
>> [mailto:linux-btrfs-owner@vger.kernel.org] On Behalf Of Byongho Lee
>> Sent: Friday, August 21, 2015 11:10 AM
>> To: linux-btrfs@vger.kernel.org
>> Subject: [PATCH] btrfs-progs: fix memory leaks in error path
>>
>> This patch includes below fixes in error path:
>> 1. fix memory leaks if realloc() fails
>> 2. add missing call free_history() before return error in scrub_read_file()
>>
>> Signed-off-by: Byongho Lee <bhlee.kernel@gmail.com>
>> ---
>> btrfs-list.c | 8 ++++++++
>> cmds-scrub.c | 18 ++++++++++++++----
>> qgroup.c | 8 ++++++++
>
>
> Similar problem in cmds-send.c:
> cmds-send.c: s->clone_sources = realloc(s->clone_sources,
>
Thank you for feedback.
You're right, I missed that point.
I'll prepare v2 patch.
Regards,
Lee
next prev parent reply other threads:[~2015-08-21 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 3:10 [PATCH] btrfs-progs: fix memory leaks in error path Byongho Lee
2015-08-21 3:50 ` Zhao Lei
2015-08-21 5:32 ` Byongho Lee [this message]
2015-08-25 15:36 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u95i4v1.fsf@gmail.com \
--to=bhlee.kernel@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.