From: Rusty Russell <rusty@rustcorp.com.au>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, Jiang Liu <jiang.liu@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [patch 2/7] x86/lguest: Do not setup unused irq vectors
Date: Tue, 04 Aug 2015 13:57:07 +0930 [thread overview]
Message-ID: <878u9r7k6c.fsf@rustcorp.com.au> (raw)
In-Reply-To: <alpine.DEB.2.11.1508031044420.3825@nanos>
Thomas Gleixner <tglx@linutronix.de> writes:
> On Mon, 3 Aug 2015, Rusty Russell wrote:
>> Thomas Gleixner <tglx@linutronix.de> writes:
>> > +
>> > + /* Some systems map "vectors" to interrupts weirdly. Not us! */
>> > + __this_cpu_write(vector_irq[FIRST_EXTERNAL_VECTOR + irq, irq);
>>
>> Missing ].
>
> Doh.
>
>> [ 17.751889] do_IRQ: 0.33 No irq handler for vector (irq -1)
>>
>> You broke interrupts :(
>
> Right, because I missed the other place which fiddles with
> interrupts. Does the patch below fix the issue?
Yep. I added error handling.
I reworked it into two patches: one which staticizes lguest_setup_irq()
and moves it up, the other of which applies your changes.
Will post, you can take them...
Thanks,
Rusty.
next prev parent reply other threads:[~2015-08-04 4:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 20:38 [patch 0/7] x86: Store irq descriptor in vector array Thomas Gleixner
2015-08-02 20:38 ` [patch 1/7] x86/irq: Protect smp_cleanup_move Thomas Gleixner
2015-08-05 22:19 ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2015-08-02 20:38 ` [patch 3/7] x86/irq: Replace numeric constant Thomas Gleixner
2015-08-05 22:19 ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2015-08-02 20:38 ` [patch 2/7] x86/lguest: Do not setup unused irq vectors Thomas Gleixner
2015-08-03 2:47 ` Rusty Russell
2015-08-03 9:40 ` Thomas Gleixner
2015-08-04 4:27 ` Rusty Russell [this message]
2015-08-04 4:32 ` [PATCH 1/2] x86/lguest: clean up lguest_setup_irq Rusty Russell
2015-08-04 4:32 ` [PATCH 2/2] x86/lguest: Do not setup unused irq vectors Rusty Russell
2015-08-05 22:19 ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2015-08-05 22:18 ` [tip:x86/apic] x86/lguest: Clean up lguest_setup_irq tip-bot for Rusty Russell
2015-08-02 20:38 ` [patch 4/7] x86/irq: Rename VECTOR_UNDEFINED to VECTOR_UNUSED Thomas Gleixner
2015-08-05 22:20 ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2015-08-02 20:38 ` [patch 5/7] x86/irq: Get rid of an indentation level Thomas Gleixner
2015-08-05 22:20 ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2015-08-02 20:38 ` [patch 6/7] genirq: Provide irq_desc_has_action Thomas Gleixner
2015-08-05 22:20 ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2015-08-02 20:38 ` [patch 7/7] x86/irq: Store irq descriptor in vector array Thomas Gleixner
2015-08-05 22:21 ` [tip:x86/apic] " tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u9r7k6c.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=bhelgaas@google.com \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.