From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [git pull] drm tree for 4.2 Date: Tue, 30 Jun 2015 16:00:12 +0300 Message-ID: <878ub1wdur.fsf@intel.com> References: <1435581800.3453.27.camel@gmail.com> <87381ay3fi.fsf@intel.com> <20150629153511.GW30960@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150629153511.GW30960@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx , Linux Kernel Mailing List , DRI mailing list , Dave Airlie , Daniel Vetter , Linus Torvalds List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAyOSBKdW4gMjAxNSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBNb24sIEp1biAyOSwgMjAxNSBhdCAwNTo1MDowOVBNICswMzAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gT24gTW9uLCAyOSBKdW4gMjAxNSwgQW5kZXIgQ29uc2VsdmFuIERlIE9saXZl aXJhIDxjb25zZWx2YW4yQGdtYWlsLmNvbT4gd3JvdGU6Cj4+ID4gT24gRnJpLCAyMDE1LTA2LTI2 IGF0IDE0OjQzIC0wNzAwLCBMaW51cyBUb3J2YWxkcyB3cm90ZToKPj4gPj4gT24gVGh1LCBKdW4g MjUsIDIwMTUgYXQgNjowMCBQTSwgRGF2ZSBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+IHdyb3Rl Ogo+PiA+PiA+Cj4+ID4+ID4gVGhpcyBpcyB0aGUgbWFpbiBkcm0gcHVsbCByZXF1ZXN0IGZvciB2 NC4yLgo+PiA+PiAKPj4gPj4gSXQgc2VlbXMgdG8gd29yayBvayBmb3IgbWUsIGJ1dCBpdCBjYXVz ZXMgcXVpdGUgYSBmZXcgbmV3IHdhcm5pbmdzIG9uCj4+ID4+IG15IFNvbnkgVkFJTyBQcm8gbGFw dG9wLiBJdCdzIChvbmNlIG1vcmUpIGEgcmVndWxhciBpNS00MjAwVSBDUFUgKGFrYQo+PiA+PiBI YXN3ZWxsLCBha2EgNHRoIGdlbiBJbnRlbCBDb3JlIGk1KQo+PiA+PiAKPj4gPj4gTW9zdCBvZiB0 aGVtIGFyZSBpbiBjaGVja19jcnRjX3N0YXRlKCksIGFuZCBJIGN1cnJlbnRseSBoYXZlIDE4IG9m Cj4+ID4+IHRoZXNlIGluIG15IGxvZzoKPj4gPj4gCj4+ID4+ICAgW2RybTpjaGVja19jcnRjX3N0 YXRlIFtpOTE1XV0gKkVSUk9SKiBtaXNtYXRjaCBpbgo+PiA+PiBkcGxsX2h3X3N0YXRlLndycGxs IChleHBlY3RlZCAweDkwMjgwMjAyLCBmb3VuZCAweDAwMDAwMDAwKQo+PiA+PiAgIFdBUk5JTkc6 IENQVTogMCBQSUQ6IDExNSBhdAo+PiA+PiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmM6MTIzMTkKPj4gPj4gY2hlY2tfY3J0Y19zdGF0ZSsweDhiZS8weGY2MCBbaTkxNV0oKQo+ PiA+PiAgIHBpcGUgc3RhdGUgZG9lc24ndCBtYXRjaCEKPj4gPj4gCj4+ID4+IGJ1dCB0aGVyZSdz IGEgZmV3IG90aGVycyB0b286Cj4+ID4+IAo+PiA+PiAgIFdBUk5JTkc6IENQVTogMyBQSUQ6IDE4 NzEgYXQKPj4gPj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jOjEzNjIgaHN3 X2Rpc2FibGVfaXBzKzB4MzQvMHgxNjAKPj4gPj4gW2k5MTVdKCkKPj4gPj4gICBwbGFuZSBBIGFz c2VydGlvbiBmYWlsdXJlIChleHBlY3RlZCBvbiwgY3VycmVudCBvZmYpCj4+ID4+IAo+PiA+PiAg IFdBUk5JTkc6IENQVTogMyBQSUQ6IDE4NzEgYXQgZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYzox MTYyCj4+ID4+IGRybV93YWl0X29uZV92YmxhbmsrMHgxNDgvMHgxYTAgW2RybV0oKQo+PiA+PiAg IHZibGFuayBub3QgYXZhaWxhYmxlIG9uIGNydGMgMCwgcmV0PS0yMgo+PiA+PiAKPj4gPj4gYW5k IHRoZSBiYWNrdHJhY2VzIGFyZW4ndCBhbGwgdGhhdCBpbnRlcmVzdGluZywgYnV0IEknbSBhdHRh Y2hpbmcgdGhlCj4+ID4+IGNsZWFuZWQtdXAgZG1lc2csIGR1cGxpY2F0ZSBjYWxsY2hhaW5zIGFu ZCBhbGwuCj4+ID4KPj4gPiBQbGVhc2UgcHJvdmlkZSBhIGZ1bGwgZG1lc2cgd2l0aCBkcm0uZGVi dWc9MHgxZiBpbiB0aGUga2VybmVsIGNvbW1hbmQKPj4gPiBsaW5lLgo+PiAKPj4gQW5kZXIsIEkg dGhpbmsgSSB3YXMgYWJsZSB0byByZXByb2R1Y2UgdGhpcyBvbiB0aGUgQkRXIE5VQyBoZXJlLiBC aXNlY3QKPj4gcG9pbnRzIGF0Li4uCj4+IAo+PiBjb21taXQgZGQzY2Q3NGFjZjEyNzIzMDQ1YTY0 ZjFmMmM2Mjk4YWM3YjM0YTVkNQo+PiBBdXRob3I6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWly YSA8YW5kZXIuY29uc2VsdmFuLmRlLm9saXZlaXJhQGludGVsLmNvbT4KPj4gRGF0ZTogICBGcmkg TWF5IDE1IDEzOjM0OjI5IDIwMTUgKzAzMDAKPj4gCj4+ICAgICBkcm0vaTkxNTogRG9uJ3Qgb3Zl cndyaXRlIChlKURQIFBMTCBzZWxlY3Rpb24gb24gU0tMCj4+ICAgICAKPj4gICAgIEluIHRoZSBm b2xsb3dpbmcgY29tbWl0LCB0aGUgcGxhY2Ugd2hlcmUgdGhlIGNvbnRlbnRzIG9mIGRwbGxfaHdf c3RhdGUKPj4gICAgIGluIGNydGNfc3RhdGUgd2hlcmUgemVyb2VkIHdhcyBjaGFuZ2VkLiBQcmlv ciB0byB0aGF0IGNvbW1pdCwgaXQKPj4gICAgIGhhcHBlbmVkIHdoZW4gdGhlIG5ldyBzdGF0ZSB3 YXMgYWxsb2NhdGVkLCBidXQgbm93IHRoYXQgaGFwcGVucyBqdXN0Cj4+ICAgICBiZWZvcmUgdGhl IGNhbGwgdGhlIC5jcnRjX2NvbXB1dGVfY2xvY2soKSBob29rLiBUaGUgRFAgY29kZSBmb3IgU0tM LAo+PiAgICAgaG93ZXZlciwgc2V0cyB1cCB0aGUgKHByaXZhdGUpIFBMTCBpbiB0aGUgZW5jb2Rl ciBjb21wdXRlIGNvbmZpZwo+PiAgICAgZnVuY3Rpb24gdGhhdCBoYXMgYWxyZWFkeSBydW4gYnkg dGhlIHRpbWUgdGhhdCBtZW1zZXQoKSBpcyByZWFjaGVkLAo+PiAgICAgY2F1c2luZyB0aGUgcHJl dmlvdXMgdmFsdWUgdG8gYmUgbG9zdC4KPj4gICAgIAo+PiAgICAgVGhpcyBwYXRjaCBmaXhlcyB0 aGUgaXNzdWUgYnkgbW92aW5nIHRoZSBtZW1zZXQoKSBkb3duIHRoZSBjYWxsIGNoYWluLAo+PiAg ICAgc28gdGhhdCBpdCBpcyBvbmx5IGNhbGxlZCBpZiB0aGUgdmFsdWVzIGluIGRwbGxfaHdfc3Rh dGUgYXJlIGdvaW5nIHRvIGJlCj4+ICAgICB1cGRhdGVkLgo+PiAgICAgCj4+ICAgICBjb21taXQg NDk3OGNjOTNkOWFjMjQwYjQzNWNlNjA0MzFhZWYyNDIzOWI0YzI3MAo+PiAgICAgQXV0aG9yOiBB bmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGFuZGVyLmNvbnNlbHZhbi5kZS5vbGl2ZWlyYUBp bnRlbC5jb20+Cj4+ICAgICBEYXRlOiAgIFR1ZSBBcHIgMjEgMTc6MTM6MjEgMjAxNSArMDMwMAo+ PiAgICAgCj4+ICAgICAgICAgZHJtL2k5MTU6IFByZXNlcnZlIHNoYXJlZCBEUExMIGluZm9ybWF0 aW9uIGluIG5ldyBwaXBlX2NvbmZpZwo+PiAgICAgCj4+ICAgICBCdWd6aWxsYTogaHR0cHM6Ly9i dWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA0NjIKPj4gICAgIFNpZ25lZC1v ZmYtYnk6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRlLm9s aXZlaXJhQGludGVsLmNvbT4KPj4gICAgIFJldmlld2VkLWJ5OiBEYW1pZW4gTGVzcGlhdSA8ZGFt aWVuLmxlc3BpYXVAaW50ZWwuY29tPgo+PiAgICAgUmVwb3J0ZWQtYW5kLXRlc3RlZC1ieTogVHZy dGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4LmludGVsLmNvbT4KPj4gICAgIFNpZ25l ZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4+IAo+PiBU aGlzIGRvZXNuJ3QgcmV2ZXJ0IGNsZWFubHkgb24gTGludXMnIG1hc3RlciwgYW5kIEkgZGlkbid0 IGhhdmUgdGhlIHRpbWUKPj4gdG8gbG9vayBkZWVwZXIgcmlnaHQgbm93LiBIb3dldmVyIEkgY29u ZmlybWVkIHRoYXQgdGhpcyBjb21taXQgZmFpbHMgYW5kCj4+IGl0cyBwYXJlbnQgZG9lc24ndC4K Pgo+IE5vdGUgdGhhdCB0aGVyZSBzZWVtcyB0byBiZSB0d28gYnVncyBoZXJlOiBGaXJzIG9uZSBp cyBkaXNwbGF5IHN0YXRlCj4gY2hlY2tlciBnZXR0aW5nIGFubm95ZWQsIHdoaWNoIGlzIHByb2Jh Ymx5IHRoZSBvbmUgSmFuaSBiaXNlY3RlZCB0byBoZXJlCj4gKHBsZWFzZSBjb25maXJtKS4KClJp Z2h0LCB0aGUgYWJvdmUgYmlzZWN0IGlzIGZvciB0aGUgIltkcm06Y2hlY2tfY3J0Y19zdGF0ZSBb aTkxNV1dCipFUlJPUiogbWlzbWF0Y2ggaW4gZHBsbF9od19zdGF0ZS53cnBsbCAoZXhwZWN0ZWQg MHg5MDI4MDIwMiwgZm91bmQKMHgwMDAwMDAwMCkiIHdhcm5pbmcuCgo+IFRoZSBvdGhlciBpcyB0 aGUgdHdvIGJhY2t0cmFjZXMgY29tcGxhaW5pbmcgdGhhdCB0aGUgcGlwZSBpcyBvZmYgKGJvdGgg dGhlCj4gZHJtX2lycS5jIGFuZCB0aGUgb25lIGluIGhzd19kaXNwbGF5X2lwcyBhbW91bnQgdG8g dGhhdCkgYmVjYXVzZSB3ZSBzZWVtCj4gdG8gY2FsbCBkaXNhYmxlX3BsYW5lcyBvbiBhIGRpc2Fi bGUgcGlwZSwgd2hpY2ggaXMgYnVsbG9ja3MgKHdpdGggcnVudGltZQo+IHBtIHRoZSBodyBpcyBk ZWFkIGFuZCB3aWxsIGp1c3QgZHJvcCB0aGUgd3JpdGVzKS4KClRoZSAidmJsYW5rIG5vdCBhdmFp bGFibGUgb24gY3J0YyAwLCByZXQ9LTIyIiB3YXJuaW5nIGJpc2VjdHMgdG8KCmNvbW1pdCA4Yzdi NWNjYjcyOTg3MGU2MDYzMjFiMzcwM2UyYzJlNjk4YzQ5YTk1CkF1dGhvcjogQW5kZXIgQ29uc2Vs dmFuIGRlIE9saXZlaXJhIDxhbmRlci5jb25zZWx2YW4uZGUub2xpdmVpcmFAaW50ZWwuY29tPgpE YXRlOiAgIFR1ZSBBcHIgMjEgMTc6MTM6MTkgMjAxNSArMDMwMAoKICAgIGRybS9pOTE1OiBVc2Ug YXRvbWljIGhlbHBlcnMgZm9yIGNvbXB1dGluZyBjaGFuZ2VkIGZsYWdzCiAgICAKICAgIFJlcGxh Y2UgdGhlIGRyaXZlcnMgb3duIGxvZ2ljIGZvciBjb21wdXRpbmcgbW9kZV9jaGFuZ2VkLCBhY3Rp dmVfY2hhbmdlZAogICAgYW5kIHBsYW5lc19jaGFuZ2VkIGZsYWdzIHdpdGggdGhlIGNoZWNrX21v ZGVzZXQoKSBhdG9taWMgaGVscGVyLiBTaW5jZQogICAgdGhhdCBmdW5jdGlvbiBuZWVkcyB0byBj b21wYXJlIHRoZSBjcnRjJ3MgbmV3IG1vZGUgd2l0aCB0aGUgY3VycmVudCwKICAgIHRoaXMgcGF0 Y2ggYWxzbyBtb3ZlcyB0aGUgc2V0IHVwIG9mIGNydGNfc3RhdGUtPm1vZGUgZWFybGllciBpbiB0 aGUgY2FsbAogICAgY2hhaW4uCiAgICAKICAgIE5vdGUgdGhhdCBmb3IgdGhlIGNhbGwgdG8gY2hl Y2tfcGxhbmUoKSB0byB3b3JrIHByb3Blcmx5LCB3ZSBuZWVkIHRvCiAgICBjaGVjayBuZXcgcGxh bmUgc3RhdGUgYWdhaW5zdCBuZXcgY3J0YyBzdGF0ZS4gQnV0IHNpbmNlIHdlIHN0aWxsIHVzZSB0 aGUKICAgIHBsYW5lIHVwZGF0ZSBoZWxwZXIsIHdoaWNoIGRvZXNuJ3QgaGF2ZSBhIGZ1bGwgYXRv bWljIHN0YXRlLCB3ZSBuZWVkIHRvCiAgICBoYWNrIGFyb3VuZCB0aGF0IGluIGludGVsX3BsYW5l X2F0b21pY19jaGVjaygpLgogICAgCiAgICBTaWduZWQtb2ZmLWJ5OiBBbmRlciBDb25zZWx2YW4g ZGUgT2xpdmVpcmEgPGFuZGVyLmNvbnNlbHZhbi5kZS5vbGl2ZWlyYUBpbnRlbC5jb20+CiAgICBS ZXZpZXdlZC1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4Lmlu dGVsLmNvbT4KICAgIFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJA ZmZ3bGwuY2g+CgoKQlIsCkphbmkuCgoKPiAtRGFuaWVsCj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+ IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xs LmNoCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVy Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbbF3M6I (ORCPT ); Tue, 30 Jun 2015 08:58:08 -0400 Received: from mga14.intel.com ([192.55.52.115]:56046 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753141AbbF3M5v (ORCPT ); Tue, 30 Jun 2015 08:57:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,377,1432623600"; d="scan'208";a="753245916" From: Jani Nikula To: Daniel Vetter Cc: Ander Conselvan De Oliveira , Linus Torvalds , Dave Airlie , Daniel Vetter , intel-gfx , Linux Kernel Mailing List , DRI mailing list Subject: Re: [Intel-gfx] [git pull] drm tree for 4.2 In-Reply-To: <20150629153511.GW30960@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1435581800.3453.27.camel@gmail.com> <87381ay3fi.fsf@intel.com> <20150629153511.GW30960@phenom.ffwll.local> User-Agent: Notmuch/0.19+112~g77230b0 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 30 Jun 2015 16:00:12 +0300 Message-ID: <878ub1wdur.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Jun 2015, Daniel Vetter wrote: > On Mon, Jun 29, 2015 at 05:50:09PM +0300, Jani Nikula wrote: >> On Mon, 29 Jun 2015, Ander Conselvan De Oliveira wrote: >> > On Fri, 2015-06-26 at 14:43 -0700, Linus Torvalds wrote: >> >> On Thu, Jun 25, 2015 at 6:00 PM, Dave Airlie wrote: >> >> > >> >> > This is the main drm pull request for v4.2. >> >> >> >> It seems to work ok for me, but it causes quite a few new warnings on >> >> my Sony VAIO Pro laptop. It's (once more) a regular i5-4200U CPU (aka >> >> Haswell, aka 4th gen Intel Core i5) >> >> >> >> Most of them are in check_crtc_state(), and I currently have 18 of >> >> these in my log: >> >> >> >> [drm:check_crtc_state [i915]] *ERROR* mismatch in >> >> dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000) >> >> WARNING: CPU: 0 PID: 115 at >> >> drivers/gpu/drm/i915/intel_display.c:12319 >> >> check_crtc_state+0x8be/0xf60 [i915]() >> >> pipe state doesn't match! >> >> >> >> but there's a few others too: >> >> >> >> WARNING: CPU: 3 PID: 1871 at >> >> drivers/gpu/drm/i915/intel_display.c:1362 hsw_disable_ips+0x34/0x160 >> >> [i915]() >> >> plane A assertion failure (expected on, current off) >> >> >> >> WARNING: CPU: 3 PID: 1871 at drivers/gpu/drm/drm_irq.c:1162 >> >> drm_wait_one_vblank+0x148/0x1a0 [drm]() >> >> vblank not available on crtc 0, ret=-22 >> >> >> >> and the backtraces aren't all that interesting, but I'm attaching the >> >> cleaned-up dmesg, duplicate callchains and all. >> > >> > Please provide a full dmesg with drm.debug=0x1f in the kernel command >> > line. >> >> Ander, I think I was able to reproduce this on the BDW NUC here. Bisect >> points at... >> >> commit dd3cd74acf12723045a64f1f2c6298ac7b34a5d5 >> Author: Ander Conselvan de Oliveira >> Date: Fri May 15 13:34:29 2015 +0300 >> >> drm/i915: Don't overwrite (e)DP PLL selection on SKL >> >> In the following commit, the place where the contents of dpll_hw_state >> in crtc_state where zeroed was changed. Prior to that commit, it >> happened when the new state was allocated, but now that happens just >> before the call the .crtc_compute_clock() hook. The DP code for SKL, >> however, sets up the (private) PLL in the encoder compute config >> function that has already run by the time that memset() is reached, >> causing the previous value to be lost. >> >> This patch fixes the issue by moving the memset() down the call chain, >> so that it is only called if the values in dpll_hw_state are going to be >> updated. >> >> commit 4978cc93d9ac240b435ce60431aef24239b4c270 >> Author: Ander Conselvan de Oliveira >> Date: Tue Apr 21 17:13:21 2015 +0300 >> >> drm/i915: Preserve shared DPLL information in new pipe_config >> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90462 >> Signed-off-by: Ander Conselvan de Oliveira >> Reviewed-by: Damien Lespiau >> Reported-and-tested-by: Tvrtko Ursulin >> Signed-off-by: Daniel Vetter >> >> This doesn't revert cleanly on Linus' master, and I didn't have the time >> to look deeper right now. However I confirmed that this commit fails and >> its parent doesn't. > > Note that there seems to be two bugs here: Firs one is display state > checker getting annoyed, which is probably the one Jani bisected to here > (please confirm). Right, the above bisect is for the "[drm:check_crtc_state [i915]] *ERROR* mismatch in dpll_hw_state.wrpll (expected 0x90280202, found 0x00000000)" warning. > The other is the two backtraces complaining that the pipe is off (both the > drm_irq.c and the one in hsw_display_ips amount to that) because we seem > to call disable_planes on a disable pipe, which is bullocks (with runtime > pm the hw is dead and will just drop the writes). The "vblank not available on crtc 0, ret=-22" warning bisects to commit 8c7b5ccb729870e606321b3703e2c2e698c49a95 Author: Ander Conselvan de Oliveira Date: Tue Apr 21 17:13:19 2015 +0300 drm/i915: Use atomic helpers for computing changed flags Replace the drivers own logic for computing mode_changed, active_changed and planes_changed flags with the check_modeset() atomic helper. Since that function needs to compare the crtc's new mode with the current, this patch also moves the set up of crtc_state->mode earlier in the call chain. Note that for the call to check_plane() to work properly, we need to check new plane state against new crtc state. But since we still use the plane update helper, which doesn't have a full atomic state, we need to hack around that in intel_plane_atomic_check(). Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Maarten Lankhorst Signed-off-by: Daniel Vetter BR, Jani. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Jani Nikula, Intel Open Source Technology Center