From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39267)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Z5txu-0006Mj-SC
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:56:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Z5txq-0006zK-RU
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:56:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45912)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Z5txq-0006z5-D8
	for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:56:02 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <20150619095853.12531.15450.stgit@bahia.huguette.org>
	<20150619120638-mutt-send-email-mst@redhat.com>
	<CAFEAcA_GR2-t7sUUT6ob-rRd4wdGUdZZc3nhXgF6z-1chYj6HA@mail.gmail.com>
	<20150619121512-mutt-send-email-mst@redhat.com>
Date: Fri, 19 Jun 2015 12:55:57 +0200
In-Reply-To: <20150619121512-mutt-send-email-mst@redhat.com> (Michael
	S. Tsirkin's message of "Fri, 19 Jun 2015 12:15:50 +0200")
Message-ID: <878ubgq85e.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote:
>> On 19 June 2015 at 11:07, Michael S. Tsirkin <mst@redhat.com> wrote:
>> > On Fri, Jun 19, 2015 at 12:00:53PM +0200, Greg Kurz wrote:
>> >> In case NDEBUG is defined, assert() expands to nothing and
>> >> vhost_net_set_vnet_endian() doesn't get called...
>> >>
>> >> Suggested-by: Thomas Huth <thuth@redhat.com>
>> >> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
>> >
>> > Not sure what the point is.
>> > We don't support building with NDEBUG.
>> 
>> Putting functional behaviour inside an assert() is still a really
>> bad idea. If you're reading the code you probably skim over the
>> assert() as not functionally relevant...
>> 
>> -- PMM
>
> I can apply this if commit log explains it's a readability
> enhancement, not a bugfix.

Easy:

vhost_net: fix misuse of assert()

In case NDEBUG is defined, assert() expands to nothing and
vhost_net_set_vnet_endian() doesn't get called...

Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>

We don't support building with NDEBUG, but putting functional behaviour
inside an assert() is still a really bad idea.  If you're reading the
code you probably skim over the assert() as not functionally relevant...

Signed-off-by: Michael S. Tsirkin" <mst@redhat.com>