From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Guo, Lei" <guol-fnst@cn.fujitsu.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Wang, Chunping" <wangcp@cn.fujitsu.com>
Subject: Re: [Qemu-devel] Add CMP2 instruction
Date: Fri, 07 Nov 2014 11:10:45 +0000 [thread overview]
Message-ID: <878ujnnu4q.fsf@linaro.org> (raw)
In-Reply-To: <36D1AB4E1AAC4541A1C88167C7231D0B74BAAD@G08CNEXMBPEKD02.g08.fujitsu.local>
Guo, Lei <guol-fnst@cn.fujitsu.com> writes:
> This patch aims to add CMP2 instruction for m68k family.
>
> Description: Compares the value in Rn to each bound. The effective address contains the
> bounds pair: upper bound following the lower bound. For signed comparisons, the
> arithmetically smaller value should be used as the lower bound. For unsigned
> comparisons, the logically smaller value should be the lower bound.
> The size of the data and the bounds can be specified as byte, word, or long. If Rn is a
> data register and the operation size is byte or word, only the appropriate low-order part
> of Rn is checked. If Rn is an address register and the operation size is byte or word,
> the bounds operands are sign-extended to 32 bits, and the resultant operands are
> compared to the full 32 bits of An.
> If the upper bound equals the lower bound, the valid range is a single value.
>
>
> signed-off-by: Guolei <guol-fnst@cn.fujitsu.com
> <mailto:guol-fnst@cn.fujitsu.com%20> >
incorrect Signed-off-by: format
>
> ---
> target-m68k/translate.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 74 insertions(+)
I'm fairly sure this fails scripts/checkpatch.pl but I was unable to run
it as your email seems to be html with a base64 uuencoded blob in it.
Please check your patch with checkpatch.pl before re-sending.
Also please fix your mailer to send plain text emails or better yet use
git-send-email to send the patch.
--
Alex Bennée
next prev parent reply other threads:[~2014-11-07 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 10:14 [Qemu-devel] Add CMP2 instruction Guo, Lei
2014-11-07 11:10 ` Alex Bennée [this message]
2014-11-07 11:15 ` Andreas Färber
2014-11-10 3:21 ` [Qemu-devel] 答复: " Guo, Lei
2014-11-10 11:30 ` Laurent Vivier
2014-11-07 11:26 ` [Qemu-devel] " Richard Henderson
2014-11-07 11:57 ` Laurent Vivier
2014-11-07 13:44 ` Laurent Vivier
2014-11-07 20:05 ` Andreas Schwab
-- strict thread matches above, loose matches on Subject: below --
2014-11-10 1:35 Guo, Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ujnnu4q.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=guol-fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=wangcp@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.