From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYwFs-0001Gk-Jn for qemu-devel@nongnu.org; Tue, 30 Sep 2014 08:10:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYwFo-0007ok-A0 for qemu-devel@nongnu.org; Tue, 30 Sep 2014 08:10:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYwFo-0007ge-3e for qemu-devel@nongnu.org; Tue, 30 Sep 2014 08:10:04 -0400 From: Markus Armbruster References: <1412046159-5144-1-git-send-email-arei.gonglei@huawei.com> <20140930113528.GE7089@redhat.com> Date: Tue, 30 Sep 2014 14:09:50 +0200 In-Reply-To: <20140930113528.GE7089@redhat.com> (Michael S. Tsirkin's message of "Tue, 30 Sep 2014 14:35:28 +0300") Message-ID: <878ul12ttd.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: weidong.huang@huawei.com, stefanha@redhat.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, arei.gonglei@huawei.com, aliguori@amazon.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de "Michael S. Tsirkin" writes: > On Tue, Sep 30, 2014 at 11:02:34AM +0800, arei.gonglei@huawei.com wrote: >> From: Gonglei >> >> This patch series based on qom-next tree: >> https://github.com/afaerber/qemu-cpu/commits/qom-next >> >> Add a description field in both ObjectProperty and PropertyInfo struct. >> The descriptions can serve as documentation in the code, >> and they can be used to provide better help. For example: >> >> Before this patch series: >> >> $./qemu-system-x86_64 -device virtio-blk-pci,? >> >> virtio-blk-pci.iothread=link >> virtio-blk-pci.x-data-plane=bool >> virtio-blk-pci.scsi=bool >> virtio-blk-pci.config-wce=bool >> virtio-blk-pci.serial=str >> virtio-blk-pci.secs=uint32 >> virtio-blk-pci.heads=uint32 >> virtio-blk-pci.cyls=uint32 >> virtio-blk-pci.discard_granularity=uint32 >> virtio-blk-pci.bootindex=int32 >> virtio-blk-pci.opt_io_size=uint32 >> virtio-blk-pci.min_io_size=uint16 >> virtio-blk-pci.physical_block_size=uint16 >> virtio-blk-pci.logical_block_size=uint16 >> virtio-blk-pci.drive=str >> virtio-blk-pci.virtio-backend=child >> virtio-blk-pci.command_serr_enable=on/off >> virtio-blk-pci.multifunction=on/off >> virtio-blk-pci.rombar=uint32 >> virtio-blk-pci.romfile=str >> virtio-blk-pci.addr=pci-devfn >> virtio-blk-pci.event_idx=on/off >> virtio-blk-pci.indirect_desc=on/off >> virtio-blk-pci.vectors=uint32 >> virtio-blk-pci.ioeventfd=on/off >> virtio-blk-pci.class=uint32 >> >> After: >> >> $./qemu-system-x86_64 -device virtio-blk-pci,? >> >> virtio-blk-pci.iothread=link >> virtio-blk-pci.x-data-plane=bool (on/off) >> virtio-blk-pci.scsi=bool (on/off) >> virtio-blk-pci.config-wce=bool (on/off) >> virtio-blk-pci.serial=str >> virtio-blk-pci.secs=uint32 >> virtio-blk-pci.heads=uint32 >> virtio-blk-pci.cyls=uint32 >> virtio-blk-pci.discard_granularity=uint32 >> virtio-blk-pci.bootindex=int32 >> virtio-blk-pci.opt_io_size=uint32 >> virtio-blk-pci.min_io_size=uint16 >> virtio-blk-pci.physical_block_size=uint16 (A power of two between >> 512 and 32768) >> virtio-blk-pci.logical_block_size=uint16 (A power of two between 512 >> and 32768) >> virtio-blk-pci.drive=str (ID of a drive to use as a backend) >> virtio-blk-pci.virtio-backend=child >> virtio-blk-pci.command_serr_enable=bool (on/off) >> virtio-blk-pci.multifunction=bool (on/off) >> virtio-blk-pci.rombar=uint32 >> virtio-blk-pci.romfile=str >> virtio-blk-pci.addr=int32 (Slot and function number, example: 06.0) > > Weird. 06.0 is clearly not an int, is it? Yes, it is. 48 in fact ;-P Back to serious. This is a clear improvement over "virtio-blk-pci.addr=pci-devfn". Let's get it in. We can always improve further on top. [...]