From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41593)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XW7Ng-0004l0-Ca
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 13:26:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XW7Nb-0006I7-0u
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 13:26:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55545)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XW7Na-0006GU-PZ
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 13:26:26 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1411310339-27733-1-git-send-email-alex@alex.org.uk>
	<1411310339-27733-3-git-send-email-alex@alex.org.uk>
	<20140922113655.GI14882@redhat.com>
	<9532E4EE-C926-4A57-A77C-66A9F4352B1A@alex.org.uk>
	<20140922121000.GL14882@redhat.com>
	<C3ABED49-2AB0-4BD5-8071-947195FF1CF0@alex.org.uk>
	<54204418.7080500@suse.de>
	<189B143D-0345-40A2-B0D6-47529F1C9D18@alex.org.uk>
Date: Mon, 22 Sep 2014 19:26:06 +0200
In-Reply-To: <189B143D-0345-40A2-B0D6-47529F1C9D18@alex.org.uk> (Alex Bligh's
	message of "Mon, 22 Sep 2014 17:54:02 +0100")
Message-ID: <878ulb36tt.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 2/2] Add configure option
	--enable-pc-1-0-qemu-kvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Ryan Harper <ryan.harper@canonical.com>, Serge Hallyn <serge.hallyn@canonical.com>, "quintela@redhat.com" <quintela@redhat.com>, Libvirt <libvir-list@redhat.com>, Serge Hallyn <serge.hallyn@ubuntu.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, "Michael S.
	Tsirkin" <mst@redhat.com>, Cole Robinson <crobinso@redhat.com>, Amit Shah <amit.shah@redhat.com>, Bruce Rogers <brogers@suse.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>, "Serge E. Hallyn" <serge@hallyn.com>

Alex Bligh <alex@alex.org.uk> writes:

> On 22 Sep 2014, at 16:45, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>
>> What about adding a bool property "qemu-kvm-compat" to the MachineClass?
>> Then a qemu-kvm shell script (like SUSE uses) can pass -global
>> machine.qemu-kvm-compat=3Don whereas qemu-system-x86_64 would run in the

No need to mess with -global, just use -machine qemu-kvm-compat=3Doff.
You can have multiple -machine, and the last key=3Dvalue wins.

>> default non-qemu-kvm mode (config on disk would affect both). It would
>> also allow running -machine pc-0.15,qemu-kvm-compat=3Don, ditching lots =
of
>> new machine names and avoiding the name bikeshedding.
>
> I'd be happy with that. Presumably downstream can then patch
> things so qemu-kvm-compat defaults in the way they want (if
> we don't like the configure option).
>
> However, that's not compatible with using PC_COMPAT as far as I
> know (unless there is some cunning way you can make a machine
> parameter change compat_props things).

Monkey-patching MACHINE_GET_CLASS(machine)->compat_props?  Gross, but I
don't have better ideas to offer.