All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ben Widawsky <ben@bwidawsk.net>, Kenneth Graunke <kenneth@whitecape.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] rendercopy/gen8: Also emit	3DSTATE_WM_DEPTH_STENCIL.
Date: Wed, 04 Jun 2014 10:27:20 +0300	[thread overview]
Message-ID: <878updf82v.fsf@intel.com> (raw)
In-Reply-To: <20140603220458.GA31603@bwidawsk.net>

On Wed, 04 Jun 2014, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Tue, Jun 03, 2014 at 02:52:30PM -0700, Kenneth Graunke wrote:
>> rendercopy was failing to emit 3DSTATE_WM_DEPTH_STENCIL, which is a new
>> packet on Broadwell.  Mesa emits this packet.
>> 
>> This appears to fix various tests on a fresh boot, when Mesa has never
>> run.
>> 
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78890
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78891
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78935

>From this bug,

Tested-by: Guo Jinxian <jinxianx.guo@intel.com>

>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78936
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78937
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78938
>> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
>> Cc: Ben Widawsky <ben@bwidawsk.net>
>
> I sat with Ken all day today (after a few days of debugging myself) and
> it does what it purport to do, and fixes a bunch of tests.
>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
>
> FWIW: I don't think we need to update the null state in the kernel. It's
> actually kind of nice for finding userspace bugs.
>
> -- 
> Ben Widawsky, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center

      reply	other threads:[~2014-06-04  7:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 21:52 [PATCH] rendercopy/gen8: Also emit 3DSTATE_WM_DEPTH_STENCIL Kenneth Graunke
2014-06-03 22:04 ` Ben Widawsky
2014-06-04  7:27   ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878updf82v.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=ben@bwidawsk.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kenneth@whitecape.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.