From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 08/12] ARM/ARM64: KVM: Emulate PSCI v0.2 AFFINITY_INFO
Date: Mon, 28 Apr 2014 15:35:55 +0100 [thread overview]
Message-ID: <878uqpttbo.fsf@approximate.cambridge.arm.com> (raw)
In-Reply-To: <1398085206-30555-9-git-send-email-anup.patel@linaro.org> (Anup Patel's message of "Mon, 21 Apr 2014 14:00:02 +0100")
On Mon, Apr 21 2014 at 2:00:02 pm BST, Anup Patel <anup.patel@linaro.org> wrote:
> This patch adds emulation of PSCI v0.2 AFFINITY_INFO function call
> for KVM ARM/ARM64. This is a VCPU-level function call which will be
> used to determine current state of given affinity level.
>
> Signed-off-by: Anup Patel <anup.patel@linaro.org>
> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
> arch/arm/kvm/psci.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 50 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kvm/psci.c b/arch/arm/kvm/psci.c
> index 4486d0f..122bc67 100644
> --- a/arch/arm/kvm/psci.c
> +++ b/arch/arm/kvm/psci.c
> @@ -27,6 +27,16 @@
> * as described in ARM document number ARM DEN 0022A.
> */
>
> +#define AFFINITY_MASK(level) ~((0x1UL << ((level) * MPIDR_LEVEL_BITS)) - 1)
> +
> +static unsigned long psci_affinity_mask(unsigned long affinity_level)
> +{
> + if (affinity_level <= 3)
> + return MPIDR_HWID_BITMASK & AFFINITY_MASK(affinity_level);
> +
> + return 0;
> +}
> +
> static void kvm_psci_vcpu_off(struct kvm_vcpu *vcpu)
> {
> vcpu->arch.pause = true;
> @@ -85,6 +95,42 @@ static unsigned long kvm_psci_vcpu_on(struct kvm_vcpu *source_vcpu)
> return PSCI_RET_SUCCESS;
> }
>
> +static unsigned long kvm_psci_vcpu_affinity_info(struct kvm_vcpu *vcpu)
> +{
> + int i;
> + unsigned long mpidr;
> + unsigned long target_affinity;
> + unsigned long target_affinity_mask;
> + unsigned long lowest_affinity_level;
> + struct kvm *kvm = vcpu->kvm;
> + struct kvm_vcpu *tmp;
> +
> + target_affinity = *vcpu_reg(vcpu, 1);
> + lowest_affinity_level = *vcpu_reg(vcpu, 2);
> +
> + /* Determine target affinity mask */
> + target_affinity_mask = psci_affinity_mask(lowest_affinity_level);
> + if (!target_affinity_mask)
> + return PSCI_RET_INVALID_PARAMS;
> +
> + /* Ignore other bits of target affinity */
> + target_affinity &= target_affinity_mask;
> +
> + /*
> + * If one or more VCPU matching target affinity are running
> + * then ON else OFF
> + */
> + kvm_for_each_vcpu(i, tmp, kvm) {
> + mpidr = kvm_vcpu_get_mpidr(tmp);
> + if (((mpidr & target_affinity_mask) == target_affinity) &&
> + !tmp->arch.pause) {
> + return PSCI_0_2_AFFINITY_LEVEL_ON;
> + }
> + }
> +
> + return PSCI_0_2_AFFINITY_LEVEL_OFF;
> +}
> +
> static void kvm_prepare_system_event(struct kvm_vcpu *vcpu, u32 type)
> {
> memset(&vcpu->run->system_event, 0, sizeof(vcpu->run->system_event));
> @@ -132,6 +178,10 @@ static int kvm_psci_0_2_call(struct kvm_vcpu *vcpu)
> case PSCI_0_2_FN64_CPU_ON:
> val = kvm_psci_vcpu_on(vcpu);
> break;
> + case PSCI_0_2_FN_AFFINITY_INFO:
> + case PSCI_0_2_FN64_AFFINITY_INFO:
> + val = kvm_psci_vcpu_affinity_info(vcpu);
> + break;
> case PSCI_0_2_FN_SYSTEM_OFF:
> kvm_psci_system_off(vcpu);
> val = PSCI_RET_INTERNAL_FAILURE;
> @@ -143,12 +193,10 @@ static int kvm_psci_0_2_call(struct kvm_vcpu *vcpu)
> ret = 0;
> break;
> case PSCI_0_2_FN_CPU_SUSPEND:
> - case PSCI_0_2_FN_AFFINITY_INFO:
> case PSCI_0_2_FN_MIGRATE:
> case PSCI_0_2_FN_MIGRATE_INFO_TYPE:
> case PSCI_0_2_FN_MIGRATE_INFO_UP_CPU:
> case PSCI_0_2_FN64_CPU_SUSPEND:
> - case PSCI_0_2_FN64_AFFINITY_INFO:
> case PSCI_0_2_FN64_MIGRATE:
> case PSCI_0_2_FN64_MIGRATE_INFO_UP_CPU:
> val = PSCI_RET_NOT_SUPPORTED;
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Anup Patel <anup.patel@linaro.org>
Cc: "kvmarm\@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"kvm\@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-arm-kernel\@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linaro-kernel\@lists.linaro.org"
<linaro-kernel@lists.linaro.org>,
"patches\@apm.com" <patches@apm.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
"rob.herring\@linaro.org" <rob.herring@linaro.org>,
Pranavkumar Sawargaonkar <pranavkumar@linaro.org>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>
Subject: Re: [PATCH v10 08/12] ARM/ARM64: KVM: Emulate PSCI v0.2 AFFINITY_INFO
Date: Mon, 28 Apr 2014 15:35:55 +0100 [thread overview]
Message-ID: <878uqpttbo.fsf@approximate.cambridge.arm.com> (raw)
In-Reply-To: <1398085206-30555-9-git-send-email-anup.patel@linaro.org> (Anup Patel's message of "Mon, 21 Apr 2014 14:00:02 +0100")
On Mon, Apr 21 2014 at 2:00:02 pm BST, Anup Patel <anup.patel@linaro.org> wrote:
> This patch adds emulation of PSCI v0.2 AFFINITY_INFO function call
> for KVM ARM/ARM64. This is a VCPU-level function call which will be
> used to determine current state of given affinity level.
>
> Signed-off-by: Anup Patel <anup.patel@linaro.org>
> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
> Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
> arch/arm/kvm/psci.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 50 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kvm/psci.c b/arch/arm/kvm/psci.c
> index 4486d0f..122bc67 100644
> --- a/arch/arm/kvm/psci.c
> +++ b/arch/arm/kvm/psci.c
> @@ -27,6 +27,16 @@
> * as described in ARM document number ARM DEN 0022A.
> */
>
> +#define AFFINITY_MASK(level) ~((0x1UL << ((level) * MPIDR_LEVEL_BITS)) - 1)
> +
> +static unsigned long psci_affinity_mask(unsigned long affinity_level)
> +{
> + if (affinity_level <= 3)
> + return MPIDR_HWID_BITMASK & AFFINITY_MASK(affinity_level);
> +
> + return 0;
> +}
> +
> static void kvm_psci_vcpu_off(struct kvm_vcpu *vcpu)
> {
> vcpu->arch.pause = true;
> @@ -85,6 +95,42 @@ static unsigned long kvm_psci_vcpu_on(struct kvm_vcpu *source_vcpu)
> return PSCI_RET_SUCCESS;
> }
>
> +static unsigned long kvm_psci_vcpu_affinity_info(struct kvm_vcpu *vcpu)
> +{
> + int i;
> + unsigned long mpidr;
> + unsigned long target_affinity;
> + unsigned long target_affinity_mask;
> + unsigned long lowest_affinity_level;
> + struct kvm *kvm = vcpu->kvm;
> + struct kvm_vcpu *tmp;
> +
> + target_affinity = *vcpu_reg(vcpu, 1);
> + lowest_affinity_level = *vcpu_reg(vcpu, 2);
> +
> + /* Determine target affinity mask */
> + target_affinity_mask = psci_affinity_mask(lowest_affinity_level);
> + if (!target_affinity_mask)
> + return PSCI_RET_INVALID_PARAMS;
> +
> + /* Ignore other bits of target affinity */
> + target_affinity &= target_affinity_mask;
> +
> + /*
> + * If one or more VCPU matching target affinity are running
> + * then ON else OFF
> + */
> + kvm_for_each_vcpu(i, tmp, kvm) {
> + mpidr = kvm_vcpu_get_mpidr(tmp);
> + if (((mpidr & target_affinity_mask) == target_affinity) &&
> + !tmp->arch.pause) {
> + return PSCI_0_2_AFFINITY_LEVEL_ON;
> + }
> + }
> +
> + return PSCI_0_2_AFFINITY_LEVEL_OFF;
> +}
> +
> static void kvm_prepare_system_event(struct kvm_vcpu *vcpu, u32 type)
> {
> memset(&vcpu->run->system_event, 0, sizeof(vcpu->run->system_event));
> @@ -132,6 +178,10 @@ static int kvm_psci_0_2_call(struct kvm_vcpu *vcpu)
> case PSCI_0_2_FN64_CPU_ON:
> val = kvm_psci_vcpu_on(vcpu);
> break;
> + case PSCI_0_2_FN_AFFINITY_INFO:
> + case PSCI_0_2_FN64_AFFINITY_INFO:
> + val = kvm_psci_vcpu_affinity_info(vcpu);
> + break;
> case PSCI_0_2_FN_SYSTEM_OFF:
> kvm_psci_system_off(vcpu);
> val = PSCI_RET_INTERNAL_FAILURE;
> @@ -143,12 +193,10 @@ static int kvm_psci_0_2_call(struct kvm_vcpu *vcpu)
> ret = 0;
> break;
> case PSCI_0_2_FN_CPU_SUSPEND:
> - case PSCI_0_2_FN_AFFINITY_INFO:
> case PSCI_0_2_FN_MIGRATE:
> case PSCI_0_2_FN_MIGRATE_INFO_TYPE:
> case PSCI_0_2_FN_MIGRATE_INFO_UP_CPU:
> case PSCI_0_2_FN64_CPU_SUSPEND:
> - case PSCI_0_2_FN64_AFFINITY_INFO:
> case PSCI_0_2_FN64_MIGRATE:
> case PSCI_0_2_FN64_MIGRATE_INFO_UP_CPU:
> val = PSCI_RET_NOT_SUPPORTED;
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny.
next prev parent reply other threads:[~2014-04-28 14:35 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 12:59 [PATCH v10 00/12] In-kernel PSCI v0.2 emulation for KVM ARM/ARM64 Anup Patel
2014-04-21 12:59 ` Anup Patel
2014-04-21 12:59 ` [PATCH v10 01/12] KVM: Add capability to advertise PSCI v0.2 support Anup Patel
2014-04-21 12:59 ` Anup Patel
2014-04-21 12:59 ` [PATCH v10 02/12] ARM/ARM64: KVM: Add common header for PSCI related defines Anup Patel
2014-04-21 12:59 ` Anup Patel
2014-04-28 14:16 ` Christoffer Dall
2014-04-28 14:16 ` Christoffer Dall
2014-04-28 17:13 ` Anup Patel
2014-04-28 17:13 ` Anup Patel
2014-04-28 17:19 ` Ashwin Chaugule
2014-04-28 17:19 ` Ashwin Chaugule
2014-04-21 12:59 ` [PATCH v10 03/12] ARM/ARM64: KVM: Add base for PSCI v0.2 emulation Anup Patel
2014-04-21 12:59 ` Anup Patel
2014-04-21 12:59 ` [PATCH v10 04/12] KVM: Documentation: Add info regarding KVM_ARM_VCPU_PSCI_0_2 feature Anup Patel
2014-04-21 12:59 ` Anup Patel
2014-04-21 12:59 ` [PATCH v10 05/12] ARM/ARM64: KVM: Make kvm_psci_call() return convention more flexible Anup Patel
2014-04-21 12:59 ` Anup Patel
2014-04-28 14:17 ` Christoffer Dall
2014-04-28 14:17 ` Christoffer Dall
2014-04-28 14:27 ` Marc Zyngier
2014-04-28 14:27 ` Marc Zyngier
2014-04-21 13:00 ` [PATCH v10 06/12] KVM: Add KVM_EXIT_SYSTEM_EVENT to user space API header Anup Patel
2014-04-21 13:00 ` Anup Patel
2014-04-21 13:00 ` [PATCH v10 07/12] ARM/ARM64: KVM: Emulate PSCI v0.2 SYSTEM_OFF and SYSTEM_RESET Anup Patel
2014-04-21 13:00 ` Anup Patel
2014-04-28 14:34 ` Marc Zyngier
2014-04-28 14:34 ` Marc Zyngier
2014-04-28 17:04 ` Anup Patel
2014-04-28 17:04 ` Anup Patel
2014-04-21 13:00 ` [PATCH v10 08/12] ARM/ARM64: KVM: Emulate PSCI v0.2 AFFINITY_INFO Anup Patel
2014-04-21 13:00 ` Anup Patel
2014-04-28 14:35 ` Marc Zyngier [this message]
2014-04-28 14:35 ` Marc Zyngier
2014-04-21 13:00 ` [PATCH v10 09/12] ARM/ARM64: KVM: Emulate PSCI v0.2 MIGRATE_INFO_TYPE and related functions Anup Patel
2014-04-21 13:00 ` Anup Patel
2014-04-21 13:00 ` [PATCH v10 10/12] ARM/ARM64: KVM: Fix CPU_ON emulation for PSCI v0.2 Anup Patel
2014-04-21 13:00 ` Anup Patel
2014-04-21 13:00 ` [PATCH v10 11/12] ARM/ARM64: KVM: Emulate PSCI v0.2 CPU_SUSPEND Anup Patel
2014-04-21 13:00 ` Anup Patel
2014-04-28 14:23 ` Christoffer Dall
2014-04-28 14:23 ` Christoffer Dall
2014-04-28 14:40 ` Marc Zyngier
2014-04-28 14:40 ` Marc Zyngier
2014-04-21 13:00 ` [PATCH v10 12/12] ARM/ARM64: KVM: Advertise KVM_CAP_ARM_PSCI_0_2 to user space Anup Patel
2014-04-21 13:00 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uqpttbo.fsf@approximate.cambridge.arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.