From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56171)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ncmike@ncultra.org>) id 1W1bkQ-0002wZ-NJ
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 08:03:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ncmike@ncultra.org>) id 1W1bkG-0006Zk-4a
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 08:03:38 -0500
Received: from mail-qa0-f49.google.com ([209.85.216.49]:33700)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ncmike@ncultra.org>) id 1W1bkF-0006ZZ-W8
	for qemu-devel@nongnu.org; Fri, 10 Jan 2014 08:03:28 -0500
Received: by mail-qa0-f49.google.com with SMTP id w8so2725510qac.8
	for <qemu-devel@nongnu.org>; Fri, 10 Jan 2014 05:03:27 -0800 (PST)
From: Mike Day <ncmike@ncultra.org>
In-Reply-To: <52CF4F37.4050306@ozlabs.ru>
References: <1389245648-10300-1-git-send-email-aik@ozlabs.ru>
	<87ppo0na45.fsf@pixel.localdomain> <52CF1ECC.3040208@ozlabs.ru>
	<D1E4D3FD-6107-46D1-9B3A-F40AD1F8E4AF@suse.de>
	<52CF4F37.4050306@ozlabs.ru>
Date: Fri, 10 Jan 2014 08:03:25 -0500
Message-ID: <878uuof0pu.fsf@pixel.localdomain>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [RFC PATCH v2] PPC: smp: autodetect numbers of
	threads per core
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, Alexander Graf <agraf@suse.de>
Cc: Paul Mackerras <paulus@samba.org>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>


Alexey Kardashevskiy <aik@ozlabs.ru> writes:

> On 01/10/2014 10:40 AM, Alexander Graf wrote:
>> 
>
>> What if we make the max thread count a property of our cpu class? The
>> we
> can add a threads=max option which will be identical between kvm and tcg.
>
>
> You lost me here :)
> Right now the sequence is:
> 1. smp_parse
> 2. config_accelerator
> 3. machine_init
>
> I proposed
> 1. config_accelerator - reads max threads from KVM (and initializes "host"
> type)
> 2. smp_parse - does the parsing using smp_threads tweaked in 1)
> 3. machine_init - creates CPUs which may or may be not "host".

The patch as it its now is very simple and well-contained. I wonder how
much it would expand if we added a max thread count to the cpu class. It
seems like the need for a max thread count is idiomatic to powerpc. 

Mike

-- 
Mike Day | "Endurance is a Virtue"