From mboxrd@z Thu Jan  1 00:00:00 1970
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Subject: Re: [PATCH 1/1] fs/fat: fix ENOSPC condition of directory entries.
Date: Mon, 23 Dec 2013 22:06:31 +0900
Message-ID: <878uvbn2co.fsf@devron.myhome.or.jp>
References: <1387778129-6028-1-git-send-email-nodakai@gmail.com>
	<87d2knn7y6.fsf@devron.myhome.or.jp>
Mime-Version: 1.0
Content-Type: text/plain
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org
To: "NODA\, Kai" <nodakai@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail.parknet.co.jp ([210.171.160.6]:34644 "EHLO
	mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756990Ab3LWNGj (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 23 Dec 2013 08:06:39 -0500
In-Reply-To: <87d2knn7y6.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of
	"Mon, 23 Dec 2013 20:05:37 +0900")
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:

> "NODA, Kai" <nodakai@gmail.com> writes:
>
>> From: "NODA, Kai" <nodakai@gmail.com>
>>
>> FAT_MAX_DIR_ENTRIES entries in a normal directory should be permitted as
>> per the FAT spec.  Previously the max number of entries was
>> FAT_MAX_DIR_ENTRIES - 1 due to the bug.
>>
>> Signed-off-by: NODA, Kai <nodakai@gmail.com>
>
> Looks good.
>
> Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

NAK, after re-read.

Actually, this was wrong fix. After read last entry of block, fat_get_entry()
returns -1. So, pos is not checked. In short, this allows
FAT_MAX_DIR_ENTRIES+1, not FAT_MAX_DIR_ENTRIES, right?

Please fix the patch, and really test it.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>