From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gcc: don't patch gcc if there are no patches to apply
Date: Mon, 11 Nov 2013 23:21:17 +0100 [thread overview]
Message-ID: <878uwu60ma.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <52815482.4010802@mind.be> (Arnout Vandecappelle's message of "Mon, 11 Nov 2013 23:04:50 +0100")
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 11/11/13 22:59, Peter Korsgaard wrote:
>>>>>>> "Mischa" == Mischa Jonker <Mischa.Jonker@synopsys.com> writes:
>>
>>> While the generic package handler checks for a directory with patches
>>> before starting apply-patches.sh, this is not the case for gcc: the
>>> script is called, even if there is no directory with patches. This results
>>> into a build failure, as apply-patches exits with error code 1 if the
>>> directory doesn't exist.
>>
>> Arnout already posted another patch solving the same issue, but I prefer
>> this one for 2013.11 - So committed, thanks.
> Should I refresh my patch on top of this or do you want to drop my patch?
I think it's still a better aproach long term (especially if/when we get
out-of-tree support), so yes - Please do.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2013-11-11 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 14:36 [Buildroot] [PATCH] gcc: don't patch gcc if there are no patches to apply Mischa Jonker
2013-11-11 21:59 ` Peter Korsgaard
2013-11-11 22:04 ` Arnout Vandecappelle
2013-11-11 22:21 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uwu60ma.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.