From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Support arch_irq_work_raise() via self IPIs
Date: Mon, 28 Oct 2013 18:58:40 -0700 [thread overview]
Message-ID: <878uxcq1m7.fsf@linaro.org> (raw)
In-Reply-To: <1382984701-2371-1-git-send-email-sboyd@codeaurora.org> (Stephen Boyd's message of "Mon, 28 Oct 2013 11:25:01 -0700")
Stephen Boyd <sboyd@codeaurora.org> writes:
> This will allow the scheduler tick to be restarted if we're in
> full NOHZ mode.
>
> Cc: Kevin Hilman <khilman@linaro.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Minor nit, but I'd prefer a more verbose changelog (I forget things
quickly and like to rely on changelogs for my memory.) Probably worth
adding something like: "By default, irq_work is tied to the tick
processing (update_process_times()) but in full NOHZ mode, no tick means
no IRQ work. In order for IRQ work to be done in full NOHZ mode, a
self-IPI is used to process IRQ work."
Other than the changelog nit, patch looks good, feel free to add
Reviewed-by: Kevin Hilman <khilman@linaro.org>
If Russell is OK with this, it can go to his patch system.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] ARM: Support arch_irq_work_raise() via self IPIs
Date: Mon, 28 Oct 2013 18:58:40 -0700 [thread overview]
Message-ID: <878uxcq1m7.fsf@linaro.org> (raw)
In-Reply-To: <1382984701-2371-1-git-send-email-sboyd@codeaurora.org> (Stephen Boyd's message of "Mon, 28 Oct 2013 11:25:01 -0700")
Stephen Boyd <sboyd@codeaurora.org> writes:
> This will allow the scheduler tick to be restarted if we're in
> full NOHZ mode.
>
> Cc: Kevin Hilman <khilman@linaro.org>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Minor nit, but I'd prefer a more verbose changelog (I forget things
quickly and like to rely on changelogs for my memory.) Probably worth
adding something like: "By default, irq_work is tied to the tick
processing (update_process_times()) but in full NOHZ mode, no tick means
no IRQ work. In order for IRQ work to be done in full NOHZ mode, a
self-IPI is used to process IRQ work."
Other than the changelog nit, patch looks good, feel free to add
Reviewed-by: Kevin Hilman <khilman@linaro.org>
If Russell is OK with this, it can go to his patch system.
Kevin
next prev parent reply other threads:[~2013-10-29 1:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 13:58 [tip:timers/core] ARM: Kconfig: allow full nohz CPU accounting tip-bot for Kevin Hilman
2013-10-16 12:14 ` Frederic Weisbecker
2013-10-16 12:14 ` Frederic Weisbecker
2013-10-18 16:37 ` Stephen Boyd
2013-10-18 16:37 ` Stephen Boyd
2013-10-25 9:38 ` Frederic Weisbecker
2013-10-25 9:38 ` Frederic Weisbecker
2013-10-28 1:32 ` Kevin Hilman
2013-10-28 1:32 ` Kevin Hilman
2013-10-28 16:18 ` Stephen Boyd
2013-10-28 16:18 ` Stephen Boyd
2013-10-28 18:25 ` [PATCH] ARM: Support arch_irq_work_raise() via self IPIs Stephen Boyd
2013-10-28 18:25 ` Stephen Boyd
2013-10-29 1:58 ` Kevin Hilman [this message]
2013-10-29 1:58 ` Kevin Hilman
2013-10-29 6:00 ` Stephen Boyd
2013-10-29 6:00 ` Stephen Boyd
2013-10-29 8:25 ` Frederic Weisbecker
2013-10-29 8:25 ` Frederic Weisbecker
2013-10-29 18:55 ` Kevin Hilman
2013-10-29 18:55 ` Kevin Hilman
2013-11-08 20:06 ` Olof Johansson
2013-11-08 20:06 ` Olof Johansson
2013-11-08 20:45 ` Olof Johansson
2013-11-08 20:45 ` Olof Johansson
2013-11-08 21:53 ` Stephen Boyd
2013-11-08 21:53 ` Stephen Boyd
2013-11-08 23:35 ` Olof Johansson
2013-11-08 23:35 ` Olof Johansson
2013-11-08 23:39 ` Stephen Boyd
2013-11-08 23:39 ` Stephen Boyd
2013-11-09 0:01 ` Russell King - ARM Linux
2013-11-09 0:01 ` Russell King - ARM Linux
2013-11-09 0:07 ` Olof Johansson
2013-11-09 0:07 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uxcq1m7.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.