From: ebiederm@xmission.com (Eric W. Biederman)
To: Jan Kaluza <jkaluza@redhat.com>
Cc: davem@davemloft.net, LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, eparis@redhat.com, rgb@redhat.com
Subject: Re: [PATCH 2/3] Send comm and cmdline in SCM_PROCINFO
Date: Sun, 08 Sep 2013 23:52:44 -0700 [thread overview]
Message-ID: <878uz6bi6b.fsf@xmission.com> (raw)
In-Reply-To: <1377614400-27122-3-git-send-email-jkaluza@redhat.com> (Jan Kaluza's message of "Tue, 27 Aug 2013 16:39:59 +0200")
Jan Kaluza <jkaluza@redhat.com> writes:
Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Whatever the benefits of the other pieces of information sending the
process command line is absolutely wrong. It is a just a random string
from user space and there is absolutely no benefit in sending it in a
kernel verified way. The process can just as easily pass the
information in userspace directly.
Furthermore the implementation of scm_get_current_procinfo is so far
from idiomatic for reading information about the current process that I
think it is fair to call it broken.
Eric
next prev parent reply other threads:[~2013-09-09 6:52 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 14:39 [PATCH 0/3] Send audit/procinfo/cgroup data in socket-level control message Jan Kaluza
2013-08-27 14:39 ` [PATCH 1/3] Send loginuid and sessionid in SCM_AUDIT Jan Kaluza
2013-08-27 14:39 ` [PATCH 2/3] Send comm and cmdline in SCM_PROCINFO Jan Kaluza
2013-09-09 6:52 ` Eric W. Biederman [this message]
2013-08-27 14:40 ` [PATCH 3/3] Send cgroup_path in SCM_CGROUP Jan Kaluza
2013-08-28 14:00 ` Tejun Heo
[not found] ` <1377614400-27122-1-git-send-email-jkaluza-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-08-29 14:13 ` [PATCH v2 0/3] Send audit/procinfo/cgroup data in socket-level control message Jan Kaluza
2013-08-29 14:13 ` Jan Kaluza
[not found] ` <1377785602-10766-1-git-send-email-jkaluza-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-08-29 14:13 ` [PATCH v2 1/3] Send loginuid and sessionid in SCM_AUDIT Jan Kaluza
2013-08-29 14:13 ` Jan Kaluza
2013-08-29 14:13 ` [PATCH v2 2/3] Send comm and cmdline in SCM_PROCINFO Jan Kaluza
2013-08-29 14:13 ` Jan Kaluza
2013-08-29 14:13 ` [PATCH v2 3/3] Send cgroup_path in SCM_CGROUP Jan Kaluza
2013-08-29 14:13 ` Jan Kaluza
[not found] ` <1377785602-10766-4-git-send-email-jkaluza-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-09-02 17:17 ` Kay Sievers
2013-09-02 17:17 ` Kay Sievers
2013-09-04 6:14 ` [PATCH v3 0/3] Send audit/procinfo/cgroup data in socket-level control message Jan Kaluza
2013-09-04 6:14 ` Jan Kaluza
[not found] ` <1378275261-4553-1-git-send-email-jkaluza-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-09-04 6:14 ` [PATCH v3 1/3] Send loginuid and sessionid in SCM_AUDIT Jan Kaluza
2013-09-04 6:14 ` Jan Kaluza
[not found] ` <1378275261-4553-2-git-send-email-jkaluza-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-09-04 7:22 ` Eric W. Biederman
2013-09-04 7:22 ` Eric W. Biederman
2013-09-04 7:22 ` Eric W. Biederman
[not found] ` <87bo49gifv.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-09-04 9:07 ` Jan Kaluža
2013-09-04 9:07 ` Jan Kaluža
2013-09-04 6:14 ` [PATCH v3 2/3] Send comm and cmdline in SCM_PROCINFO Jan Kaluza
2013-09-04 6:14 ` Jan Kaluza
2013-09-04 6:14 ` [PATCH v3 3/3] Send cgroup_path in SCM_CGROUP Jan Kaluza
2013-09-04 7:42 ` [PATCH v3 0/3] Send audit/procinfo/cgroup data in socket-level control message Eric W. Biederman
2013-09-04 7:42 ` Eric W. Biederman
2013-09-04 7:42 ` Eric W. Biederman
[not found] ` <878uzdf2xp.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-09-04 14:45 ` Tejun Heo
2013-09-04 14:45 ` Tejun Heo
2013-09-04 14:58 ` Richard Guy Briggs
2013-09-04 14:58 ` Richard Guy Briggs
[not found] ` <20130904145830.GC28517-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org>
2013-09-04 15:04 ` Jan Kaluža
2013-09-04 15:04 ` Jan Kaluža
2013-09-04 15:04 ` Jan Kaluža
2013-09-04 15:20 ` Richard Guy Briggs
2013-09-04 15:20 ` Richard Guy Briggs
2013-09-04 15:20 ` Richard Guy Briggs
[not found] ` <20130904152022.GD28517-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org>
2013-09-04 15:30 ` Eric Dumazet
2013-09-04 15:30 ` Eric Dumazet
2013-09-04 15:40 ` Jan Kaluža
2013-09-04 15:40 ` Jan Kaluža
2013-09-04 15:40 ` Jan Kaluža
2013-09-04 6:14 ` [PATCH v3 3/3] Send cgroup_path in SCM_CGROUP Jan Kaluza
2014-01-13 8:01 ` [PATCH v4 0/3] Send audit/procinfo/cgroup data in socket-level control message Jan Kaluza
2014-01-13 8:01 ` Jan Kaluza
2014-01-13 19:44 ` Casey Schaufler
[not found] ` <52D44206.2000906-iSGtlc1asvQWG2LlvL+J4A@public.gmane.org>
2014-01-14 8:25 ` Jan Kaluža
2014-01-14 8:25 ` Jan Kaluža
[not found] ` <1389600109-30739-1-git-send-email-jkaluza-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-13 8:01 ` [PATCH v4 1/3] Send loginuid and sessionid in SCM_AUDIT Jan Kaluza
2014-01-13 8:01 ` Jan Kaluza
[not found] ` <1389600109-30739-2-git-send-email-jkaluza-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-15 4:02 ` Richard Guy Briggs
2014-01-15 4:02 ` Richard Guy Briggs
2014-01-13 8:01 ` [PATCH v4 2/3] Send comm and cmdline in SCM_PROCINFO Jan Kaluza
2014-01-13 8:01 ` Jan Kaluza
[not found] ` <1389600109-30739-3-git-send-email-jkaluza-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-15 4:03 ` Richard Guy Briggs
2014-01-15 4:03 ` Richard Guy Briggs
2014-01-13 8:01 ` [PATCH v4 3/3] Send cgroup_path in SCM_CGROUP Jan Kaluza
2014-01-13 8:01 ` Jan Kaluza
[not found] ` <1389600109-30739-4-git-send-email-jkaluza-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-13 16:52 ` Tejun Heo
2014-01-13 16:52 ` Tejun Heo
2014-01-13 16:55 ` [PATCH v4 0/3] Send audit/procinfo/cgroup data in socket-level control message Tejun Heo
2014-01-13 16:55 ` Tejun Heo
2014-01-13 19:44 ` Casey Schaufler
2014-01-15 20:17 ` David Miller
2014-01-15 20:17 ` David Miller
[not found] ` <20140115.121730.1984913330507219167.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-01-15 23:21 ` Eric Paris
2014-01-15 23:21 ` Eric Paris
[not found] ` <1389828103.681.34.camel-OjZBOOqb7SR7cYLChsl7DafLeoKvNuZc@public.gmane.org>
2014-01-15 23:23 ` Tejun Heo
2014-01-15 23:23 ` Tejun Heo
[not found] ` <20140115232345.GA22237-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2014-01-16 9:29 ` Jan Kaluža
2014-01-16 9:29 ` Jan Kaluža
[not found] ` <52D7A68F.5030700-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-01-23 19:31 ` Kay Sievers
2014-01-23 19:31 ` Kay Sievers
2014-01-23 19:31 ` Kay Sievers
2014-01-23 19:31 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uz6bi6b.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=jkaluza@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.