From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCVdx-0003oV-7A for qemu-devel@nongnu.org; Thu, 22 Aug 2013 10:13:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCVds-0007jA-B6 for qemu-devel@nongnu.org; Thu, 22 Aug 2013 10:13:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCVds-0007iw-3u for qemu-devel@nongnu.org; Thu, 22 Aug 2013 10:13:40 -0400 From: Markus Armbruster References: <1377175700-16229-1-git-send-email-marcel.a@redhat.com> <5216197C.2060509@suse.de> Date: Thu, 22 Aug 2013 16:13:36 +0200 In-Reply-To: <5216197C.2060509@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?= =?utf-8?Q?'s?= message of "Thu, 22 Aug 2013 16:00:28 +0200") Message-ID: <878uztstin.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: pbonzini@redhat.com, aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, Marcel Apfelbaum Andreas F=C3=A4rber writes: > Am 22.08.2013 14:48, schrieb Marcel Apfelbaum: >> This patch follows Markus Armbruster suggestion: >>=20 >> A possibly better way to group help by category: instead of adding >> categories to each line, add category headlines, like this: >>=20 >> Controller/Bridge/Hub devices: >> name "NAME", bus "BUS"... >> ... >> USB devices: >> name "NAME", bus "BUS"... >> ... >> Storage devices: >> ... >>=20 >> This way, showing devices with multiple categories once per category >> actually makes sense. >>=20 >> Note that the "categories to each line" is kept for 2 reasons: >> 1. Preparation for multifunction devices >> 2. Ability to grep by category >>=20 >> Signed-off-by: Marcel Apfelbaum >> --- >> qdev-monitor.c | 2 ++ >> 1 file changed, 2 insertions(+) >>=20 >> diff --git a/qdev-monitor.c b/qdev-monitor.c >> index 410cdcb..a7329b0 100644 >> --- a/qdev-monitor.c >> +++ b/qdev-monitor.c >> @@ -156,6 +156,8 @@ static void qdev_print_category_devices(DeviceCatego= ry category) >> DeviceClass *dc; >> GSList *list, *curr; >>=20=20 >> + error_printf("%s devices:\n", qdev_category_get_name(category)); > > Why is that an error? Shouldn't it go to stdout? Output of -device help has always gone to stderr, and that has always annoyed me. Just not enough to fix it. [...]